fix upload file size contract (#3408)

backend/tests/test_uploads_router.py

@@ -56,12 +56,40 @@ def test_upload_files_writes_thread_storage_and_skips_local_sandbox_sync(tmp_pat
 
     assert result.success is True
     assert len(result.files) == 1
-    assert result.files[0]["filename"] == "notes.txt"
+    assert result.files[0].filename == "notes.txt"
+    assert result.files[0].size == len(b"hello uploads")
     assert (thread_uploads_dir / "notes.txt").read_bytes() == b"hello uploads"
 
     sandbox.update_file.assert_not_called()
 
 
+def test_upload_and_list_response_models_expose_size_as_int(tmp_path):
+    thread_uploads_dir = tmp_path / "uploads"
+    thread_uploads_dir.mkdir(parents=True)
+    (thread_uploads_dir / "notes.txt").write_bytes(b"hello uploads")
+
+    paths = MagicMock()
+    paths.sandbox_uploads_dir.return_value = thread_uploads_dir
+
+    with (
+        patch.object(uploads, "get_uploads_dir", return_value=thread_uploads_dir),
+        patch.object(uploads, "get_paths", return_value=paths),
+    ):
+        result = asyncio.run(call_unwrapped(uploads.list_uploaded_files, "thread-local", request=MagicMock()))
+
+    assert result.count == 1
+    assert result.files[0].filename == "notes.txt"
+    assert result.files[0].size == len(b"hello uploads")
+
+
+def test_upload_openapi_schema_exposes_file_size_as_integer():
+    upload_schema = uploads.UploadResponse.model_json_schema()
+    list_schema = uploads.UploadListResponse.model_json_schema()
+
+    assert upload_schema["$defs"]["UploadedFileInfo"]["properties"]["size"]["type"] == "integer"
+    assert list_schema["$defs"]["UploadedFileInfo"]["properties"]["size"]["type"] == "integer"
+
+
 def test_upload_files_auto_renames_duplicate_form_filenames(tmp_path):
     thread_uploads_dir = tmp_path / "uploads"
     thread_uploads_dir.mkdir(parents=True)
@@ -88,9 +116,9 @@ def test_upload_files_auto_renames_duplicate_form_filenames(tmp_path):
         )
 
     assert result.success is True
-    assert [file_info["filename"] for file_info in result.files] == ["data.txt", "data_1.txt"]
-    assert "original_filename" not in result.files[0]
-    assert result.files[1]["original_filename"] == "data.txt"
+    assert [file_info.filename for file_info in result.files] == ["data.txt", "data_1.txt"]
+    assert result.files[0].original_filename is None
+    assert result.files[1].original_filename == "data.txt"
     assert (thread_uploads_dir / "data.txt").read_bytes() == b"first"
     assert (thread_uploads_dir / "data_1.txt").read_bytes() == b"second"
 
@@ -138,8 +166,8 @@ def test_upload_files_does_not_auto_convert_documents_by_default(tmp_path):
 
     assert result.success is True
     assert len(result.files) == 1
-    assert result.files[0]["filename"] == "report.pdf"
-    assert "markdown_file" not in result.files[0]
+    assert result.files[0].filename == "report.pdf"
+    assert result.files[0].markdown_file is None
     convert_mock.assert_not_called()
     assert not (thread_uploads_dir / "report.md").exists()
 
@@ -172,8 +200,8 @@ def test_upload_files_syncs_non_local_sandbox_and_marks_markdown_file(tmp_path):
     assert result.success is True
     assert len(result.files) == 1
     file_info = result.files[0]
-    assert file_info["filename"] == "report.pdf"
-    assert file_info["markdown_file"] == "report.md"
+    assert file_info.filename == "report.pdf"
+    assert file_info.markdown_file == "report.md"
 
     assert (thread_uploads_dir / "report.pdf").read_bytes() == b"pdf-bytes"
     assert (thread_uploads_dir / "report.md").read_text(encoding="utf-8") == "converted"
@@ -516,7 +544,7 @@ def test_upload_files_rejects_dotdot_and_dot_filenames(tmp_path):
         result = asyncio.run(call_unwrapped(uploads.upload_files, "thread-local", request=MagicMock(), files=[file], config=SimpleNamespace()))
         assert result.success is True
         assert len(result.files) == 1
-        assert result.files[0]["filename"] == "passwd"
+        assert result.files[0].filename == "passwd"
 
     # Only the safely normalised file should exist
     assert [f.name for f in thread_uploads_dir.iterdir()] == ["passwd"]
@@ -616,7 +644,7 @@ def test_upload_files_overwrites_existing_regular_file(tmp_path):
         result = asyncio.run(uploads.upload_files("thread-local", files=[file]))
 
     assert result.success is True
-    assert [file_info["filename"] for file_info in result.files] == ["notes.txt"]
+    assert [file_info.filename for file_info in result.files] == ["notes.txt"]
     assert existing_file.read_bytes() == b"new upload"
     assert existing_file.stat().st_nlink == 1