furyhawk/deer-flow
1
0
Fork 0
mirror of https://github.com/bytedance/deer-flow.git synced 2026-06-15 11:56:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(frontend): cap deeply nested list indentation to prevent render crash (#3393) (#3570)

Browse Source 
* fix(frontend): cap deeply nested list indentation to prevent render crash

Deeply nested lists make marked's recursive list tokenizer overflow the
call stack during Streamdown's lexing useMemo, throwing an uncaught
"RangeError: Maximum call stack size exceeded" that replaces the chat
route with an error page (issue #3393); on larger stacks the same input
exhausts the heap, which the render error boundary cannot catch.

Mirror the existing capBlockquoteNesting guard with capListNesting, which
clamps leading whitespace to 200 columns (~100 nesting levels) only when
pathologically deep indentation is present, leaving normal content and
fenced code untouched. Wire both through capMarkdownNesting.

* fix(frontend): satisfy prettier format check in preprocess test

* fix(frontend): exempt indented code from list-indent cap (PR #3570 review)

* fix(frontend): keep capping all deep indentation outside fenced code

Revert the indented-code exemption from the PR #3570 review nit. Taken
literally the suggested guard (insideFence || INDENTED_CODE_RE.test(line))
no-ops capListNesting, because INDENTED_CODE_RE matches every line with
4+ leading spaces — i.e. exactly the deep-indent lines the cap targets.
A context-aware exemption (only treat 4+-space lines as code after a
blank line) instead reopens the crash: blank-separated deeply nested list
items get exempted and still blow up marked (verified: OOM at depth ~1.5k).

Unlike blockquotes (markers take <=3 leading spaces, so deep-quote lines
never look like indented code), list vs. indented-code indentation is
ambiguous line-by-line, so any exemption is exploitable. Keep capping all
deep indentation outside fenced code; the only cost is mild corruption of
a >200-column indented-code line, which never occurs in real content and
is strictly preferable to a render crash. Add a regression test locking
the blank-line case.
This commit is contained in:
Eilen Shin
2026-06-14 22:19:54 +08:00
committed by GitHub
parent 34e126ee4b
commit 25fbd25b05
3 changed files with 101 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/components/ai-elements/streamdown.tsx
+7 -4
View File
@@ -4,7 +4,7 @@ import { Component, useMemo, type ComponentProps, type ReactNode } from "react";
import { Streamdown } from "streamdown";
import { installClipboardFallback } from "@/core/clipboard";
import { capBlockquoteNesting } from "@/core/streamdown/preprocess";
import { capMarkdownNesting } from "@/core/streamdown/preprocess";
export type ClipboardSafeStreamdownProps = ComponentProps<typeof Streamdown>;
@@ -58,11 +58,14 @@ export function ClipboardSafeStreamdown({
children,
...props
}: ClipboardSafeStreamdownProps) {
// Fast path for the dominant pathological input (pure ">" chains) so the
// error boundary below rarely has to absorb a full stack overflow.
// Fast path for the dominant pathological inputs (deep ">" chains and deeply
// nested lists both blow up marked's recursive tokenizers) so the error
// boundary below rarely has to absorb a stack overflow — and never has to
// face the heap exhaustion the same lists cause on larger stacks, which it
// cannot catch.
const safeChildren = useMemo(
() =>
typeof children === "string" ? capBlockquoteNesting(children) : children,
typeof children === "string" ? capMarkdownNesting(children) : children,
[children],
);
return (