furyhawk/deer-flow
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(feedback): add UNIQUE(thread_id, run_id, user_id) constraint

Browse Source 
Add UNIQUE constraint to FeedbackRow to enforce one feedback per user per run,
enabling upsert behavior in Task 2. Update tests to use distinct user_ids for
multiple feedback records per run, and pass user_id=None to list_by_run for
admin-style queries that bypass user isolation.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
rayhpeng
2026-04-10 18:18:04 +08:00
parent b2ec1f99b9
commit 60a5ad7279
2 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/packages/harness/deerflow/persistence/feedback/model.py
+5 -1
View File
@@ -4,7 +4,7 @@ from __future__ import annotations
from datetime import UTC, datetime from datetime import UTC, datetime
from sqlalchemy import DateTime, String, Text from sqlalchemy import DateTime, String, Text, UniqueConstraint
from sqlalchemy.orm import Mapped, mapped_column from sqlalchemy.orm import Mapped, mapped_column
from deerflow.persistence.base import Base from deerflow.persistence.base import Base
@@ -13,6 +13,10 @@ from deerflow.persistence.base import Base
class FeedbackRow(Base): class FeedbackRow(Base):
__tablename__ = "feedback" __tablename__ = "feedback"
__table_args__ = (
UniqueConstraint("thread_id", "run_id", "user_id", name="uq_feedback_thread_run_user"),
)
feedback_id: Mapped[str] = mapped_column(String(64), primary_key=True) feedback_id: Mapped[str] = mapped_column(String(64), primary_key=True)
run_id: Mapped[str] = mapped_column(String(64), nullable=False, index=True) run_id: Mapped[str] = mapped_column(String(64), nullable=False, index=True)
thread_id: Mapped[str] = mapped_column(String(64), nullable=False, index=True) thread_id: Mapped[str] = mapped_column(String(64), nullable=False, index=True)
backend/tests/test_feedback.py
+7 -7
View File
@@ -97,10 +97,10 @@ class TestFeedbackRepository:
@pytest.mark.anyio @pytest.mark.anyio
async def test_list_by_run(self, tmp_path): async def test_list_by_run(self, tmp_path):
repo = await _make_feedback_repo(tmp_path) repo = await _make_feedback_repo(tmp_path)
await repo.create(run_id="r1", thread_id="t1", rating=1) await repo.create(run_id="r1", thread_id="t1", rating=1, user_id="user-1")
await repo.create(run_id="r1", thread_id="t1", rating=-1) await repo.create(run_id="r1", thread_id="t1", rating=-1, user_id="user-2")
await repo.create(run_id="r2", thread_id="t1", rating=1) await repo.create(run_id="r2", thread_id="t1", rating=1, user_id="user-1")
results = await repo.list_by_run("t1", "r1") results = await repo.list_by_run("t1", "r1", user_id=None)
assert len(results) == 2 assert len(results) == 2
assert all(r["run_id"] == "r1" for r in results) assert all(r["run_id"] == "r1" for r in results)
await _cleanup() await _cleanup()
@@ -135,9 +135,9 @@ class TestFeedbackRepository:
@pytest.mark.anyio @pytest.mark.anyio
async def test_aggregate_by_run(self, tmp_path): async def test_aggregate_by_run(self, tmp_path):
repo = await _make_feedback_repo(tmp_path) repo = await _make_feedback_repo(tmp_path)
await repo.create(run_id="r1", thread_id="t1", rating=1) await repo.create(run_id="r1", thread_id="t1", rating=1, user_id="user-1")
await repo.create(run_id="r1", thread_id="t1", rating=1) await repo.create(run_id="r1", thread_id="t1", rating=1, user_id="user-2")
await repo.create(run_id="r1", thread_id="t1", rating=-1) await repo.create(run_id="r1", thread_id="t1", rating=-1, user_id="user-3")
stats = await repo.aggregate_by_run("t1", "r1") stats = await repo.aggregate_by_run("t1", "r1")
assert stats["total"] == 3 assert stats["total"] == 3
assert stats["positive"] == 2 assert stats["positive"] == 2