From c002596ab4310b6f3fa6d52b89aa65ef7230a6c3 Mon Sep 17 00:00:00 2001 From: AochenShen99 Date: Fri, 12 Jun 2026 22:48:47 +0800 Subject: [PATCH] chore(todo): remove unused completion reminder counter (#3530) --- .../agents/middlewares/todo_middleware.py | 5 ----- backend/tests/test_todo_middleware.py | 19 ------------------- 2 files changed, 24 deletions(-) diff --git a/backend/packages/harness/deerflow/agents/middlewares/todo_middleware.py b/backend/packages/harness/deerflow/agents/middlewares/todo_middleware.py index 3e3ebdd81..15125b74f 100644 --- a/backend/packages/harness/deerflow/agents/middlewares/todo_middleware.py +++ b/backend/packages/harness/deerflow/agents/middlewares/todo_middleware.py @@ -46,11 +46,6 @@ def _reminder_in_messages(messages: list[Any]) -> bool: return False -def _completion_reminder_count(messages: list[Any]) -> int: - """Return the number of todo_completion_reminder HumanMessages in *messages*.""" - return sum(1 for msg in messages if isinstance(msg, HumanMessage) and getattr(msg, "name", None) == "todo_completion_reminder") - - def _format_todos(todos: list[Todo]) -> str: """Format a list of Todo items into a human-readable string.""" lines: list[str] = [] diff --git a/backend/tests/test_todo_middleware.py b/backend/tests/test_todo_middleware.py index 1848b906e..4e7b2c61c 100644 --- a/backend/tests/test_todo_middleware.py +++ b/backend/tests/test_todo_middleware.py @@ -11,7 +11,6 @@ from pydantic import PrivateAttr from deerflow.agents.middlewares.todo_middleware import ( TodoMiddleware, - _completion_reminder_count, _format_todos, _has_tool_call_intent_or_error, _reminder_in_messages, @@ -189,10 +188,6 @@ class TestAbeforeModel: assert result["messages"][0].name == "todo_reminder" -def _completion_reminder_msg(): - return HumanMessage(name="todo_completion_reminder", content="finish your todos") - - def _todo_completion_reminders(messages): reminders = [] for message in messages: @@ -264,20 +259,6 @@ def _all_completed_todos(): ] -class TestCompletionReminderCount: - def test_zero_when_no_reminders(self): - msgs = [HumanMessage(content="hi"), _ai_no_tool_calls()] - assert _completion_reminder_count(msgs) == 0 - - def test_counts_completion_reminders(self): - msgs = [_completion_reminder_msg(), _completion_reminder_msg()] - assert _completion_reminder_count(msgs) == 2 - - def test_does_not_count_todo_reminders(self): - msgs = [_reminder_msg(), _completion_reminder_msg()] - assert _completion_reminder_count(msgs) == 1 - - class TestToolCallIntentOrError: def test_false_for_plain_final_answer(self): assert _has_tool_call_intent_or_error(_ai_no_tool_calls()) is False