refactor: thread release config through lead path (#2612)

Co-authored-by: greatmengqi <chenmengqi.0376@bytedance.com>

backend/packages/harness/deerflow/skills/loader.py

@@ -2,6 +2,8 @@ import logging
 import os
 from pathlib import Path
 
+from deerflow.config.app_config import AppConfig
+
 from .parser import parse_skill_file
 from .types import Skill
 
@@ -22,7 +24,7 @@ def get_skills_root_path() -> Path:
     return skills_dir
 
 
-def load_skills(skills_path: Path | None = None, use_config: bool = True, enabled_only: bool = False) -> list[Skill]:
+def load_skills(skills_path: Path | None = None, use_config: bool = True, enabled_only: bool = False, *, app_config: AppConfig | None = None) -> list[Skill]:
     """
     Load all skills from the skills directory.
 
@@ -44,7 +46,7 @@ def load_skills(skills_path: Path | None = None, use_config: bool = True, enable
             try:
                 from deerflow.config import get_app_config
 
-                config = get_app_config()
+                config = app_config or get_app_config()
                 skills_path = config.skills.get_skills_path()
             except Exception:
                 # Fallback to default if config fails

backend/packages/harness/deerflow/skills/manager.py

@@ -10,6 +10,7 @@ from pathlib import Path
 from typing import Any
 
 from deerflow.config import get_app_config
+from deerflow.config.app_config import AppConfig
 from deerflow.skills.loader import load_skills
 from deerflow.skills.validation import _validate_skill_frontmatter
 
@@ -20,16 +21,17 @@ ALLOWED_SUPPORT_SUBDIRS = {"references", "templates", "scripts", "assets"}
 _SKILL_NAME_PATTERN = re.compile(r"^[a-z0-9]+(?:-[a-z0-9]+)*$")
 
 
-def get_skills_root_dir() -> Path:
-    return get_app_config().skills.get_skills_path()
+def get_skills_root_dir(*, app_config: AppConfig | None = None) -> Path:
+    config = app_config or get_app_config()
+    return config.skills.get_skills_path()
 
 
-def get_public_skills_dir() -> Path:
-    return get_skills_root_dir() / "public"
+def get_public_skills_dir(*, app_config: AppConfig | None = None) -> Path:
+    return get_skills_root_dir(app_config=app_config) / "public"
 
 
-def get_custom_skills_dir() -> Path:
-    path = get_skills_root_dir() / "custom"
+def get_custom_skills_dir(*, app_config: AppConfig | None = None) -> Path:
+    path = get_skills_root_dir(app_config=app_config) / "custom"
     path.mkdir(parents=True, exist_ok=True)
     return path
 
@@ -43,46 +45,46 @@ def validate_skill_name(name: str) -> str:
     return normalized
 
 
-def get_custom_skill_dir(name: str) -> Path:
-    return get_custom_skills_dir() / validate_skill_name(name)
+def get_custom_skill_dir(name: str, *, app_config: AppConfig | None = None) -> Path:
+    return get_custom_skills_dir(app_config=app_config) / validate_skill_name(name)
 
 
-def get_custom_skill_file(name: str) -> Path:
-    return get_custom_skill_dir(name) / SKILL_FILE_NAME
+def get_custom_skill_file(name: str, *, app_config: AppConfig | None = None) -> Path:
+    return get_custom_skill_dir(name, app_config=app_config) / SKILL_FILE_NAME
 
 
-def get_custom_skill_history_dir() -> Path:
-    path = get_custom_skills_dir() / HISTORY_DIR_NAME
+def get_custom_skill_history_dir(*, app_config: AppConfig | None = None) -> Path:
+    path = get_custom_skills_dir(app_config=app_config) / HISTORY_DIR_NAME
     path.mkdir(parents=True, exist_ok=True)
     return path
 
 
-def get_skill_history_file(name: str) -> Path:
-    return get_custom_skill_history_dir() / f"{validate_skill_name(name)}.jsonl"
+def get_skill_history_file(name: str, *, app_config: AppConfig | None = None) -> Path:
+    return get_custom_skill_history_dir(app_config=app_config) / f"{validate_skill_name(name)}.jsonl"
 
 
-def get_public_skill_dir(name: str) -> Path:
-    return get_public_skills_dir() / validate_skill_name(name)
+def get_public_skill_dir(name: str, *, app_config: AppConfig | None = None) -> Path:
+    return get_public_skills_dir(app_config=app_config) / validate_skill_name(name)
 
 
-def custom_skill_exists(name: str) -> bool:
-    return get_custom_skill_file(name).exists()
+def custom_skill_exists(name: str, *, app_config: AppConfig | None = None) -> bool:
+    return get_custom_skill_file(name, app_config=app_config).exists()
 
 
-def public_skill_exists(name: str) -> bool:
-    return (get_public_skill_dir(name) / SKILL_FILE_NAME).exists()
+def public_skill_exists(name: str, *, app_config: AppConfig | None = None) -> bool:
+    return (get_public_skill_dir(name, app_config=app_config) / SKILL_FILE_NAME).exists()
 
 
-def ensure_custom_skill_is_editable(name: str) -> None:
-    if custom_skill_exists(name):
+def ensure_custom_skill_is_editable(name: str, *, app_config: AppConfig | None = None) -> None:
+    if custom_skill_exists(name, app_config=app_config):
         return
-    if public_skill_exists(name):
+    if public_skill_exists(name, app_config=app_config):
         raise ValueError(f"'{name}' is a built-in skill. To customise it, create a new skill with the same name under skills/custom/.")
     raise FileNotFoundError(f"Custom skill '{name}' not found.")
 
 
-def ensure_safe_support_path(name: str, relative_path: str) -> Path:
-    skill_dir = get_custom_skill_dir(name).resolve()
+def ensure_safe_support_path(name: str, relative_path: str, *, app_config: AppConfig | None = None) -> Path:
+    skill_dir = get_custom_skill_dir(name, app_config=app_config).resolve()
     if not relative_path or relative_path.endswith("/"):
         raise ValueError("Supporting file path must include a filename.")
     relative = Path(relative_path)
@@ -124,8 +126,8 @@ def atomic_write(path: Path, content: str) -> None:
     tmp_path.replace(path)
 
 
-def append_history(name: str, record: dict[str, Any]) -> None:
-    history_path = get_skill_history_file(name)
+def append_history(name: str, record: dict[str, Any], *, app_config: AppConfig | None = None) -> None:
+    history_path = get_skill_history_file(name, app_config=app_config)
     history_path.parent.mkdir(parents=True, exist_ok=True)
     payload = {
         "ts": datetime.now(UTC).isoformat(),
@@ -136,8 +138,8 @@ def append_history(name: str, record: dict[str, Any]) -> None:
         f.write("\n")
 
 
-def read_history(name: str) -> list[dict[str, Any]]:
-    history_path = get_skill_history_file(name)
+def read_history(name: str, *, app_config: AppConfig | None = None) -> list[dict[str, Any]]:
+    history_path = get_skill_history_file(name, app_config=app_config)
     if not history_path.exists():
         return []
     records: list[dict[str, Any]] = []
@@ -148,12 +150,12 @@ def read_history(name: str) -> list[dict[str, Any]]:
     return records
 
 
-def list_custom_skills() -> list:
-    return [skill for skill in load_skills(enabled_only=False) if skill.category == "custom"]
+def list_custom_skills(*, app_config: AppConfig | None = None) -> list:
+    return [skill for skill in load_skills(enabled_only=False, app_config=app_config) if skill.category == "custom"]
 
 
-def read_custom_skill_content(name: str) -> str:
-    skill_file = get_custom_skill_file(name)
+def read_custom_skill_content(name: str, *, app_config: AppConfig | None = None) -> str:
+    skill_file = get_custom_skill_file(name, app_config=app_config)
     if not skill_file.exists():
         raise FileNotFoundError(f"Custom skill '{name}' not found.")
     return skill_file.read_text(encoding="utf-8")

backend/packages/harness/deerflow/skills/security_scanner.py

@@ -8,6 +8,7 @@ import re
 from dataclasses import dataclass
 
 from deerflow.config import get_app_config
+from deerflow.config.app_config import AppConfig
 from deerflow.models import create_chat_model
 
 logger = logging.getLogger(__name__)
@@ -35,7 +36,7 @@ def _extract_json_object(raw: str) -> dict | None:
         return None
 
 
-async def scan_skill_content(content: str, *, executable: bool = False, location: str = "SKILL.md") -> ScanResult:
+async def scan_skill_content(content: str, *, executable: bool = False, location: str = "SKILL.md", app_config: AppConfig | None = None) -> ScanResult:
     """Screen skill content before it is written to disk."""
     rubric = (
         "You are a security reviewer for AI agent skills. "
@@ -47,9 +48,9 @@ async def scan_skill_content(content: str, *, executable: bool = False, location
     prompt = f"Location: {location}\nExecutable: {str(executable).lower()}\n\nReview this content:\n-----\n{content}\n-----"
 
     try:
-        config = get_app_config()
+        config = app_config or get_app_config()
         model_name = config.skill_evolution.moderation_model_name
-        model = create_chat_model(name=model_name, thinking_enabled=False) if model_name else create_chat_model(thinking_enabled=False)
+        model = create_chat_model(name=model_name, thinking_enabled=False, app_config=config) if model_name else create_chat_model(thinking_enabled=False, app_config=config)
         response = await model.ainvoke(
             [
                 {"role": "system", "content": rubric},