feat: support manual add and edit for memory facts (#1538)

* feat: support manual add and edit for memory facts * fix: restore memory updater save helper * fix: address memory fact review feedback * fix: remove duplicate memory fact edit action * docs: simplify memory fact review setup * docs: relax memory review startup instructions * fix: clear rebase marker in memory settings page * fix: address memory fact review and format issues * fix: address memory fact review feedback * refactor: make memory fact updates explicit patch semantics --------- Co-authored-by: Willem Jiang <willem.jiang@gmail.com>
2026-05-21 15:36:48 +00:00 · 2026-03-29 23:53:23 +08:00
parent cdb2a3a017
commit fc7de7fffe
15 changed files with 977 additions and 52 deletions
@@ -36,6 +36,37 @@ def test_clear_memory_route_returns_cleared_memory() -> None:
    assert response.json()["facts"] == []


+def test_create_memory_fact_route_returns_updated_memory() -> None:
+    app = FastAPI()
+    app.include_router(memory.router)
+    updated_memory = _sample_memory(
+        facts=[
+            {
+                "id": "fact_new",
+                "content": "User prefers concise code reviews.",
+                "category": "preference",
+                "confidence": 0.88,
+                "createdAt": "2026-03-20T00:00:00Z",
+                "source": "manual",
+            }
+        ]
+    )
+
+    with patch("app.gateway.routers.memory.create_memory_fact", return_value=updated_memory):
+        with TestClient(app) as client:
+            response = client.post(
+                "/api/memory/facts",
+                json={
+                    "content": "User prefers concise code reviews.",
+                    "category": "preference",
+                    "confidence": 0.88,
+                },
+            )
+
+    assert response.status_code == 200
+    assert response.json()["facts"] == updated_memory["facts"]
+
+
 def test_delete_memory_fact_route_returns_updated_memory() -> None:
    app = FastAPI()
    app.include_router(memory.router)
@@ -70,3 +101,106 @@ def test_delete_memory_fact_route_returns_404_for_missing_fact() -> None:

    assert response.status_code == 404
    assert response.json()["detail"] == "Memory fact 'fact_missing' not found."
+
+
+def test_update_memory_fact_route_returns_updated_memory() -> None:
+    app = FastAPI()
+    app.include_router(memory.router)
+    updated_memory = _sample_memory(
+        facts=[
+            {
+                "id": "fact_edit",
+                "content": "User prefers spaces",
+                "category": "workflow",
+                "confidence": 0.91,
+                "createdAt": "2026-03-20T00:00:00Z",
+                "source": "manual",
+            }
+        ]
+    )
+
+    with patch("app.gateway.routers.memory.update_memory_fact", return_value=updated_memory):
+        with TestClient(app) as client:
+            response = client.patch(
+                "/api/memory/facts/fact_edit",
+                json={
+                    "content": "User prefers spaces",
+                    "category": "workflow",
+                    "confidence": 0.91,
+                },
+            )
+
+    assert response.status_code == 200
+    assert response.json()["facts"] == updated_memory["facts"]
+
+
+def test_update_memory_fact_route_preserves_omitted_fields() -> None:
+    app = FastAPI()
+    app.include_router(memory.router)
+    updated_memory = _sample_memory(
+        facts=[
+            {
+                "id": "fact_edit",
+                "content": "User prefers spaces",
+                "category": "preference",
+                "confidence": 0.8,
+                "createdAt": "2026-03-20T00:00:00Z",
+                "source": "manual",
+            }
+        ]
+    )
+
+    with patch("app.gateway.routers.memory.update_memory_fact", return_value=updated_memory) as update_fact:
+        with TestClient(app) as client:
+            response = client.patch(
+                "/api/memory/facts/fact_edit",
+                json={
+                    "content": "User prefers spaces",
+                },
+            )
+
+    assert response.status_code == 200
+    update_fact.assert_called_once_with(
+        fact_id="fact_edit",
+        content="User prefers spaces",
+        category=None,
+        confidence=None,
+    )
+    assert response.json()["facts"] == updated_memory["facts"]
+
+
+def test_update_memory_fact_route_returns_404_for_missing_fact() -> None:
+    app = FastAPI()
+    app.include_router(memory.router)
+
+    with patch("app.gateway.routers.memory.update_memory_fact", side_effect=KeyError("fact_missing")):
+        with TestClient(app) as client:
+            response = client.patch(
+                "/api/memory/facts/fact_missing",
+                json={
+                    "content": "User prefers spaces",
+                    "category": "workflow",
+                    "confidence": 0.91,
+                },
+            )
+
+    assert response.status_code == 404
+    assert response.json()["detail"] == "Memory fact 'fact_missing' not found."
+
+
+def test_update_memory_fact_route_returns_specific_error_for_invalid_confidence() -> None:
+    app = FastAPI()
+    app.include_router(memory.router)
+
+    with patch("app.gateway.routers.memory.update_memory_fact", side_effect=ValueError("confidence")):
+        with TestClient(app) as client:
+            response = client.patch(
+                "/api/memory/facts/fact_edit",
+                json={
+                    "content": "User prefers spaces",
+                    "confidence": 0.91,
+                },
+            )
+
+    assert response.status_code == 400
+    assert response.json()["detail"] == "Invalid confidence value; must be between 0 and 1."