Files
deer-flow/frontend/src/components/workspace/agents/agent-card.tsx
T
Xinmin Zeng 7679f21edf fix(frontend): truncate overflowing text in agent cards (#3391)
* fix(frontend): truncate overflowing text in agent cards

Long custom agent names, descriptions, skills and tool-group labels
overflowed the agent card and broke its layout (issue #3389). The title
already had `truncate`, but it never took effect: an ancestor flex
container lacked `min-w-0`, so the flex item refused to shrink below its
content width.

- Restore the truncation chain by adding `min-w-0` to the title's flex
  ancestors so `truncate` can finally take effect.
- Cap and ellipsize model / skill / tool-group badges via a small
  `TruncatedBadge` (`block max-w-full truncate`).
- Reveal the full value on hover, but only when the text is actually
  clipped (`TruncatedTooltip`, width + height detection), so names,
  descriptions and labels stay readable without popping redundant
  tooltips on short cards.

* fix(frontend): wrap unbreakable strings in agent card tooltips

A long token with no break opportunity (no spaces or hyphens) could still
overflow the tooltip horizontally. Add `break-words` next to the existing
`text-wrap` so such strings wrap instead of overflowing.

Addresses Copilot review feedback on tooltip wrapping robustness.

* fix(frontend): show agent card tooltips instantly

Drop the explicit `delayDuration` so card tooltips fall back to the
provider's default 0ms delay. Instant feedback is better UX for revealing
text that is already clipped, per maintainer review.

---------

Co-authored-by: Willem Jiang <willem.jiang@gmail.com>
2026-06-07 23:29:59 +08:00

227 lines
6.5 KiB
TypeScript

"use client";
import { BotIcon, MessageSquareIcon, Trash2Icon } from "lucide-react";
import { useRouter } from "next/navigation";
import { type ComponentProps, type ReactElement, useState } from "react";
import { toast } from "sonner";
import { Badge } from "@/components/ui/badge";
import { Button } from "@/components/ui/button";
import {
Card,
CardContent,
CardDescription,
CardFooter,
CardHeader,
CardTitle,
} from "@/components/ui/card";
import {
Dialog,
DialogContent,
DialogDescription,
DialogFooter,
DialogHeader,
DialogTitle,
} from "@/components/ui/dialog";
import {
Tooltip,
TooltipContent,
TooltipTrigger,
} from "@/components/ui/tooltip";
import { useDeleteAgent } from "@/core/agents";
import type { Agent } from "@/core/agents";
import { useI18n } from "@/core/i18n/hooks";
import { cn } from "@/lib/utils";
interface AgentCardProps {
agent: Agent;
}
/**
* Reveals the full text in a tooltip ONLY when its trigger is actually clipped.
* Clipping is measured on pointer enter against the trigger's own box, covering
* both single-line `truncate` (width) and multi-line `line-clamp` (height), so
* untruncated content never pops a redundant tooltip.
*/
function TruncatedTooltip({
text,
children,
}: {
text: string;
children: ReactElement;
}) {
const [truncated, setTruncated] = useState(false);
return (
<Tooltip>
<TooltipTrigger
asChild
onPointerEnter={(e) => {
const el = e.currentTarget;
setTruncated(
el.scrollWidth > el.clientWidth ||
el.scrollHeight > el.clientHeight,
);
}}
>
{children}
</TooltipTrigger>
{truncated && (
<TooltipContent className="max-w-xs text-wrap break-words">
{text}
</TooltipContent>
)}
</Tooltip>
);
}
/**
* Long, user-controlled labels (agent model, skills, tool groups) that must
* never break the card layout: width is capped to the parent and the text is
* truncated with an ellipsis, with the full value revealed on hover.
*/
function TruncatedBadge({
label,
variant,
className,
}: {
label: string;
variant: ComponentProps<typeof Badge>["variant"];
className?: string;
}) {
return (
<TruncatedTooltip text={label}>
<Badge
variant={variant}
className={cn("block max-w-full truncate", className)}
>
{label}
</Badge>
</TruncatedTooltip>
);
}
export function AgentCard({ agent }: AgentCardProps) {
const { t } = useI18n();
const router = useRouter();
const deleteAgent = useDeleteAgent();
const [deleteOpen, setDeleteOpen] = useState(false);
function handleChat() {
router.push(`/workspace/agents/${agent.name}/chats/new`);
}
async function handleDelete() {
try {
await deleteAgent.mutateAsync(agent.name);
toast.success(t.agents.deleteSuccess);
setDeleteOpen(false);
} catch (err) {
toast.error(err instanceof Error ? err.message : String(err));
}
}
return (
<>
<Card className="group flex flex-col transition-shadow hover:shadow-md">
<CardHeader className="pb-3">
<div className="flex min-w-0 items-start justify-between gap-2">
<div className="flex min-w-0 items-center gap-2">
<div className="bg-primary/10 text-primary flex h-9 w-9 shrink-0 items-center justify-center rounded-lg">
<BotIcon className="h-5 w-5" />
</div>
<div className="min-w-0">
<TruncatedTooltip text={agent.name}>
<CardTitle className="truncate text-base">
{agent.name}
</CardTitle>
</TruncatedTooltip>
{agent.model && (
<TruncatedBadge
label={agent.model}
variant="secondary"
className="mt-0.5 text-xs"
/>
)}
</div>
</div>
</div>
{agent.description && (
<TruncatedTooltip text={agent.description}>
<CardDescription className="mt-2 line-clamp-2 text-sm">
{agent.description}
</CardDescription>
</TruncatedTooltip>
)}
</CardHeader>
{(agent.tool_groups?.length ?? agent.skills?.length ?? 0) > 0 && (
<CardContent className="pt-0 pb-3">
<div className="flex flex-wrap gap-1">
{agent.tool_groups?.map((group) => (
<TruncatedBadge
key={`tg:${group}`}
label={group}
variant="outline"
className="text-xs"
/>
))}
{agent.skills?.map((skill) => (
<TruncatedBadge
key={`sk:${skill}`}
label={skill}
variant="secondary"
className="text-xs"
/>
))}
</div>
</CardContent>
)}
<CardFooter className="mt-auto flex items-center justify-between gap-2 pt-3">
<Button size="sm" className="flex-1" onClick={handleChat}>
<MessageSquareIcon className="mr-1.5 h-3.5 w-3.5" />
{t.agents.chat}
</Button>
<div className="flex gap-1">
<Button
size="icon"
variant="ghost"
className="text-destructive hover:text-destructive h-8 w-8 shrink-0"
onClick={() => setDeleteOpen(true)}
title={t.agents.delete}
>
<Trash2Icon className="h-3.5 w-3.5" />
</Button>
</div>
</CardFooter>
</Card>
{/* Delete Confirm */}
<Dialog open={deleteOpen} onOpenChange={setDeleteOpen}>
<DialogContent>
<DialogHeader>
<DialogTitle>{t.agents.delete}</DialogTitle>
<DialogDescription>{t.agents.deleteConfirm}</DialogDescription>
</DialogHeader>
<DialogFooter>
<Button
variant="outline"
onClick={() => setDeleteOpen(false)}
disabled={deleteAgent.isPending}
>
{t.common.cancel}
</Button>
<Button
variant="destructive"
onClick={handleDelete}
disabled={deleteAgent.isPending}
>
{deleteAgent.isPending ? t.common.loading : t.common.delete}
</Button>
</DialogFooter>
</DialogContent>
</Dialog>
</>
);
}