mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-07-21 02:05:45 +00:00
Ryker_FengandGitHub
41658c5ff4
* feat(skills): add skill review quality gate * fix(skills): skip review eval fixtures in CI * fix(skills): ignore review eval fixtures in bundled scans * fix(skill-review): harden review gate boundaries * fix(skills): address skill review gate feedback
57 lines
1.8 KiB
Python
57 lines
1.8 KiB
Python
import logging
|
|
from typing import Protocol
|
|
|
|
from deerflow.skills.types import Skill
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
class NamedTool(Protocol):
|
|
name: str
|
|
|
|
|
|
# Framework built-ins that remain available even when an active skill declares
|
|
# allowed-tools. They support controlled framework workflows rather than
|
|
# extending the reviewed/activated skill's own tool authority.
|
|
ALWAYS_AVAILABLE_BUILTIN_TOOL_NAMES = frozenset({"read_file", "review_skill_package"})
|
|
|
|
|
|
def allowed_tool_names_for_skills(skills: list[Skill]) -> set[str] | None:
|
|
"""Return the union of explicit skill allowed-tools declarations.
|
|
|
|
None means legacy allow-all behavior. It is returned only when no loaded
|
|
skill declares allowed-tools. Once any skill declares the field, legacy
|
|
skills without the field contribute no tools instead of disabling the
|
|
explicit restrictions from other skills.
|
|
"""
|
|
if not skills:
|
|
return None
|
|
|
|
allowed: set[str] = set()
|
|
has_explicit_declaration = False
|
|
for skill in skills:
|
|
if skill.allowed_tools is None:
|
|
continue
|
|
has_explicit_declaration = True
|
|
if not skill.allowed_tools:
|
|
logger.info("Skill %s declared empty allowed-tools", skill.name)
|
|
allowed.update(skill.allowed_tools)
|
|
|
|
if not has_explicit_declaration:
|
|
return None
|
|
return allowed
|
|
|
|
|
|
def filter_tools_by_skill_allowed_tools[ToolT: NamedTool](
|
|
tools: list[ToolT],
|
|
skills: list[Skill],
|
|
*,
|
|
always_allowed_tool_names: set[str] | frozenset[str] = frozenset(),
|
|
) -> list[ToolT]:
|
|
allowed = allowed_tool_names_for_skills(skills)
|
|
if allowed is None:
|
|
return tools
|
|
|
|
allowed_with_framework_tools = allowed | set(always_allowed_tool_names)
|
|
return [tool for tool in tools if tool.name in allowed_with_framework_tools]
|