mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-07-21 02:05:45 +00:00
Ryker_FengandGitHub
41658c5ff4
* feat(skills): add skill review quality gate * fix(skills): skip review eval fixtures in CI * fix(skills): ignore review eval fixtures in bundled scans * fix(skill-review): harden review gate boundaries * fix(skills): address skill review gate feedback
35 lines
1.3 KiB
Python
35 lines
1.3 KiB
Python
"""Validate every bundled SKILL.md under skills/public/.
|
|
|
|
Catches regressions like #2443 — a SKILL.md whose YAML front-matter fails to
|
|
parse (e.g. an unquoted description containing a colon, which YAML interprets
|
|
as a nested mapping). Each bundled skill is checked individually so the
|
|
failure message identifies the exact file.
|
|
"""
|
|
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from deerflow.skills.package_paths import is_eval_fixture_skill_md
|
|
from deerflow.skills.validation import _validate_skill_frontmatter
|
|
|
|
SKILLS_PUBLIC_DIR = Path(__file__).resolve().parents[2] / "skills" / "public"
|
|
|
|
|
|
BUNDLED_SKILL_DIRS = sorted(p.parent for p in SKILLS_PUBLIC_DIR.rglob("SKILL.md") if not is_eval_fixture_skill_md(p.relative_to(SKILLS_PUBLIC_DIR)))
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"skill_dir",
|
|
BUNDLED_SKILL_DIRS,
|
|
ids=lambda p: str(p.relative_to(SKILLS_PUBLIC_DIR)),
|
|
)
|
|
def test_bundled_skill_frontmatter_is_valid(skill_dir: Path) -> None:
|
|
valid, msg, name = _validate_skill_frontmatter(skill_dir)
|
|
assert valid, f"{skill_dir.relative_to(SKILLS_PUBLIC_DIR)}: {msg}"
|
|
assert name, f"{skill_dir.relative_to(SKILLS_PUBLIC_DIR)}: no name extracted"
|
|
|
|
|
|
def test_skills_public_dir_has_skills() -> None:
|
|
assert BUNDLED_SKILL_DIRS, f"no SKILL.md found under {SKILLS_PUBLIC_DIR}"
|