mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-06-10 17:35:57 +00:00
2ace78d1e5
* fix(frontend): surface backend detail when agent name check fails The new-agent page caught AgentNameCheckError but only branched on reason === "backend_unreachable". Everything else (notably the 422 "Invalid agent name '...'. Must match ^[A-Za-z0-9-]+$" response from GET /api/agents/check when the user submits a name with disallowed characters — trailing space, dot, Chinese, invisible whitespace from copy-paste) fell through to the generic fallback "Could not verify name availability — please try again", swallowing the detail that already told the user exactly what to fix. Add a request_failed branch that surfaces err.message (which checkAgentName already populates from the backend's detail at core/agents/api.ts). The disabled / backend_unreachable / unknown- error paths are unchanged. Pin the contract with unit tests covering: 200 success, fetch rejection, 502/503/504 network errors, agents_api disabled detail, 422 validation detail carried verbatim, statusText fallback when detail is absent, and a regression guard against misclassifying a 422 as agents_api disabled. Closes #3041 * fix(frontend): localise the error prefix when surfacing backend detail The previous commit surfaced the backend's raw `err.message` on the new-agent page when the name check failed. The detail itself is English (backend's `_validate_agent_name` text, any 5xx business message, etc.) and dropping it bare into a zh-CN page produced a jarring English-among-Chinese line that didn't match neighbouring strings like "已存在同名智能体" / "无法验证名称可用性". Add `nameStepCheckErrorWithDetail` as a templated string ("Name check failed: {detail}" / "名称校验失败:{detail}"), mirroring the existing `nameStepBootstrapMessage` `{name}` template pattern. The page wraps `err.message` in it when present and falls back to the plain `nameStepCheckError` when the detail is empty. Rendered output (verified locally with a Console fetch mock that returns 500 + detail): zh-CN: 名称校验失败:Database connection lost: SQLAlchemy connection pool exhausted (max 5 connections, all in use) en-US: Name check failed: Database connection lost: SQLAlchemy connection pool exhausted (max 5 connections, all in use) The localised prefix tells the user *what operation* failed; the raw detail tells them *why*. Translating the detail itself would be lossy (any unbounded backend string would need a translation table) and would break the debuggability the previous commit delivered. Refs #3041 * fix(frontend): distinguish backend detail from generated fallback in AgentNameCheckError Addresses Copilot's review on #3048: the previous commits keyed off `err.message`, but `checkAgentName` substitutes a generated fallback string ("Failed to check agent name: ${statusText}") when the backend sent no detail. That guaranteed `err.message` was always truthy, made the `nameStepCheckError` fallback branch unreachable in practice, and could surface awkward strings like "名称校验失败:Failed to check agent name: Bad Gateway" in the UI. Add an explicit `detail: string | null` field to AgentNameCheckError. `checkAgentName` populates it only when the backend response actually carried a string `detail` (defensive guard against the dict-shaped detail that other deer-flow endpoints use for typed error codes). The new-agent page now selects on `err.detail` instead of `err.message` so the localised fallback wins when no real detail exists. Also fix the prettier formatting that broke lint-frontend CI on the previous push. Test changes: - The 422 carry-through test now asserts both `detail` and `message` hold the backend string verbatim. - A new "falls back to statusText in message but leaves detail null" test pins the contract that no real detail ⇒ no UI surface leak. - A new "treats non-string detail as null" test guards against future backend schema drift toward dict-shaped detail. Refs #3041 #3048
417 lines
13 KiB
TypeScript
417 lines
13 KiB
TypeScript
"use client";
|
|
|
|
import {
|
|
ArrowLeftIcon,
|
|
BotIcon,
|
|
CheckCircleIcon,
|
|
InfoIcon,
|
|
MoreHorizontalIcon,
|
|
SaveIcon,
|
|
} from "lucide-react";
|
|
import { useRouter } from "next/navigation";
|
|
import { useCallback, useEffect, useMemo, useState } from "react";
|
|
import { toast } from "sonner";
|
|
|
|
import {
|
|
PromptInput,
|
|
PromptInputFooter,
|
|
PromptInputSubmit,
|
|
PromptInputTextarea,
|
|
} from "@/components/ai-elements/prompt-input";
|
|
import { Alert, AlertDescription } from "@/components/ui/alert";
|
|
import { Button } from "@/components/ui/button";
|
|
import {
|
|
DropdownMenu,
|
|
DropdownMenuContent,
|
|
DropdownMenuItem,
|
|
DropdownMenuTrigger,
|
|
} from "@/components/ui/dropdown-menu";
|
|
import { Input } from "@/components/ui/input";
|
|
import { ArtifactsProvider } from "@/components/workspace/artifacts";
|
|
import { MessageList } from "@/components/workspace/messages";
|
|
import { ThreadContext } from "@/components/workspace/messages/context";
|
|
import type { Agent } from "@/core/agents";
|
|
import {
|
|
AgentNameCheckError,
|
|
AgentsApiDisabledError,
|
|
checkAgentName,
|
|
getAgent,
|
|
} from "@/core/agents/api";
|
|
import { useI18n } from "@/core/i18n/hooks";
|
|
import { useThreadStream } from "@/core/threads/hooks";
|
|
import { uuid } from "@/core/utils/uuid";
|
|
import { isIMEComposing } from "@/lib/ime";
|
|
import { cn } from "@/lib/utils";
|
|
|
|
type Step = "name" | "chat";
|
|
type SetupAgentStatus = "idle" | "requested" | "completed";
|
|
|
|
const NAME_RE = /^[A-Za-z0-9-]+$/;
|
|
const SAVE_HINT_STORAGE_KEY = "deerflow.agent-create.save-hint-seen";
|
|
const AGENT_READ_RETRY_DELAYS_MS = [200, 500, 1_000, 2_000];
|
|
|
|
function wait(ms: number) {
|
|
return new Promise((resolve) => window.setTimeout(resolve, ms));
|
|
}
|
|
|
|
async function getAgentWithRetry(agentName: string) {
|
|
for (const delay of [0, ...AGENT_READ_RETRY_DELAYS_MS]) {
|
|
if (delay > 0) {
|
|
await wait(delay);
|
|
}
|
|
|
|
try {
|
|
return await getAgent(agentName);
|
|
} catch {
|
|
// Retry until the write settles or the attempts are exhausted.
|
|
}
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
export default function NewAgentPage() {
|
|
const { t } = useI18n();
|
|
const router = useRouter();
|
|
|
|
const [step, setStep] = useState<Step>("name");
|
|
const [nameInput, setNameInput] = useState("");
|
|
const [nameError, setNameError] = useState("");
|
|
const [isCheckingName, setIsCheckingName] = useState(false);
|
|
const [agentName, setAgentName] = useState("");
|
|
const [agent, setAgent] = useState<Agent | null>(null);
|
|
const [showSaveHint, setShowSaveHint] = useState(false);
|
|
const [setupAgentStatus, setSetupAgentStatus] =
|
|
useState<SetupAgentStatus>("idle");
|
|
|
|
const threadId = useMemo(() => uuid(), []);
|
|
|
|
const { thread, sendMessage } = useThreadStream({
|
|
threadId: undefined,
|
|
context: {
|
|
mode: "flash",
|
|
is_bootstrap: true,
|
|
},
|
|
onFinish() {
|
|
if (!agent && setupAgentStatus === "requested") {
|
|
setSetupAgentStatus("idle");
|
|
}
|
|
},
|
|
onToolEnd({ name }) {
|
|
if (name !== "setup_agent" || !agentName) return;
|
|
setSetupAgentStatus("completed");
|
|
void getAgentWithRetry(agentName).then((fetched) => {
|
|
if (fetched) {
|
|
setAgent(fetched);
|
|
return;
|
|
}
|
|
|
|
toast.error(t.agents.agentCreatedPendingRefresh);
|
|
});
|
|
},
|
|
});
|
|
|
|
useEffect(() => {
|
|
if (typeof window === "undefined" || step !== "chat") {
|
|
return;
|
|
}
|
|
if (window.localStorage.getItem(SAVE_HINT_STORAGE_KEY) === "1") {
|
|
return;
|
|
}
|
|
setShowSaveHint(true);
|
|
window.localStorage.setItem(SAVE_HINT_STORAGE_KEY, "1");
|
|
}, [step]);
|
|
|
|
const handleConfirmName = useCallback(async () => {
|
|
const trimmed = nameInput.trim();
|
|
if (!trimmed) return;
|
|
if (!NAME_RE.test(trimmed)) {
|
|
setNameError(t.agents.nameStepInvalidError);
|
|
return;
|
|
}
|
|
|
|
setNameError("");
|
|
setIsCheckingName(true);
|
|
try {
|
|
const result = await checkAgentName(trimmed);
|
|
if (!result.available) {
|
|
setNameError(t.agents.nameStepAlreadyExistsError);
|
|
return;
|
|
}
|
|
} catch (err) {
|
|
if (err instanceof AgentsApiDisabledError) {
|
|
setNameError(t.agents.nameStepApiDisabledError);
|
|
} else if (
|
|
err instanceof AgentNameCheckError &&
|
|
err.reason === "backend_unreachable"
|
|
) {
|
|
setNameError(t.agents.nameStepNetworkError);
|
|
} else if (
|
|
err instanceof AgentNameCheckError &&
|
|
err.reason === "request_failed"
|
|
) {
|
|
// Surface the backend-provided detail (e.g. validation error) when
|
|
// one is present, wrapped in a localised prefix so zh-CN users
|
|
// don't see a bare English string next to the surrounding Chinese
|
|
// UI. Falls back to the generic localised fallback when the backend
|
|
// sent no detail — `err.message` is unreliable for this branch
|
|
// because `checkAgentName` substitutes a generated fallback string
|
|
// ("Failed to check agent name: ${statusText}") when `detail` is
|
|
// missing, so testing `err.message` would always be truthy and the
|
|
// generated fallback would leak through.
|
|
setNameError(
|
|
err.detail
|
|
? t.agents.nameStepCheckErrorWithDetail.replace(
|
|
"{detail}",
|
|
err.detail,
|
|
)
|
|
: t.agents.nameStepCheckError,
|
|
);
|
|
} else {
|
|
setNameError(t.agents.nameStepCheckError);
|
|
}
|
|
return;
|
|
} finally {
|
|
setIsCheckingName(false);
|
|
}
|
|
|
|
setAgentName(trimmed);
|
|
setStep("chat");
|
|
await sendMessage(
|
|
threadId,
|
|
{
|
|
text: t.agents.nameStepBootstrapMessage.replace("{name}", trimmed),
|
|
files: [],
|
|
},
|
|
{ agent_name: trimmed },
|
|
);
|
|
}, [
|
|
nameInput,
|
|
sendMessage,
|
|
t.agents.nameStepAlreadyExistsError,
|
|
t.agents.nameStepApiDisabledError,
|
|
t.agents.nameStepNetworkError,
|
|
t.agents.nameStepBootstrapMessage,
|
|
t.agents.nameStepCheckError,
|
|
t.agents.nameStepCheckErrorWithDetail,
|
|
t.agents.nameStepInvalidError,
|
|
threadId,
|
|
]);
|
|
|
|
const handleNameKeyDown = (e: React.KeyboardEvent<HTMLInputElement>) => {
|
|
if (e.key === "Enter" && !isIMEComposing(e)) {
|
|
e.preventDefault();
|
|
void handleConfirmName();
|
|
}
|
|
};
|
|
|
|
const handleChatSubmit = useCallback(
|
|
async (text: string) => {
|
|
const trimmed = text.trim();
|
|
if (!trimmed || thread.isLoading) return;
|
|
await sendMessage(
|
|
threadId,
|
|
{ text: trimmed, files: [] },
|
|
{ agent_name: agentName },
|
|
);
|
|
},
|
|
[agentName, sendMessage, thread.isLoading, threadId],
|
|
);
|
|
|
|
const handleSaveAgent = useCallback(async () => {
|
|
if (
|
|
!agentName ||
|
|
agent ||
|
|
thread.isLoading ||
|
|
setupAgentStatus !== "idle"
|
|
) {
|
|
return;
|
|
}
|
|
|
|
setSetupAgentStatus("requested");
|
|
setShowSaveHint(false);
|
|
try {
|
|
await sendMessage(
|
|
threadId,
|
|
{ text: t.agents.saveCommandMessage, files: [] },
|
|
{ agent_name: agentName },
|
|
{ additionalKwargs: { hide_from_ui: true } },
|
|
);
|
|
toast.success(t.agents.saveRequested);
|
|
} catch (error) {
|
|
setSetupAgentStatus("idle");
|
|
toast.error(error instanceof Error ? error.message : String(error));
|
|
}
|
|
}, [
|
|
agent,
|
|
agentName,
|
|
sendMessage,
|
|
setupAgentStatus,
|
|
t.agents.saveCommandMessage,
|
|
t.agents.saveRequested,
|
|
thread.isLoading,
|
|
threadId,
|
|
]);
|
|
|
|
const header = (
|
|
<header className="flex shrink-0 items-center justify-between gap-3 border-b px-4 py-3">
|
|
<div className="flex items-center gap-3">
|
|
<Button
|
|
variant="ghost"
|
|
size="icon-sm"
|
|
onClick={() => router.push("/workspace/agents")}
|
|
>
|
|
<ArrowLeftIcon className="h-4 w-4" />
|
|
</Button>
|
|
<h1 className="text-sm font-semibold">{t.agents.createPageTitle}</h1>
|
|
</div>
|
|
|
|
{step === "chat" ? (
|
|
<DropdownMenu>
|
|
<DropdownMenuTrigger asChild>
|
|
<Button variant="ghost" size="icon-sm" aria-label={t.agents.more}>
|
|
<MoreHorizontalIcon className="h-4 w-4" />
|
|
</Button>
|
|
</DropdownMenuTrigger>
|
|
<DropdownMenuContent align="end">
|
|
<DropdownMenuItem
|
|
onSelect={() => void handleSaveAgent()}
|
|
disabled={[
|
|
Boolean(agent),
|
|
thread.isLoading,
|
|
setupAgentStatus !== "idle",
|
|
].some(Boolean)}
|
|
>
|
|
<SaveIcon className="h-4 w-4" />
|
|
{setupAgentStatus === "requested"
|
|
? t.agents.saving
|
|
: t.agents.save}
|
|
</DropdownMenuItem>
|
|
</DropdownMenuContent>
|
|
</DropdownMenu>
|
|
) : null}
|
|
</header>
|
|
);
|
|
|
|
if (step === "name") {
|
|
return (
|
|
<div className="flex size-full flex-col">
|
|
{header}
|
|
<main className="flex flex-1 flex-col items-center justify-center px-4">
|
|
<div className="w-full max-w-sm space-y-8">
|
|
<div className="space-y-3 text-center">
|
|
<div className="bg-primary/10 mx-auto flex h-14 w-14 items-center justify-center rounded-full">
|
|
<BotIcon className="text-primary h-7 w-7" />
|
|
</div>
|
|
<div className="space-y-1">
|
|
<h2 className="text-xl font-semibold">
|
|
{t.agents.nameStepTitle}
|
|
</h2>
|
|
<p className="text-muted-foreground text-sm">
|
|
{t.agents.nameStepHint}
|
|
</p>
|
|
</div>
|
|
</div>
|
|
|
|
<div className="space-y-3">
|
|
<Input
|
|
autoFocus
|
|
placeholder={t.agents.nameStepPlaceholder}
|
|
value={nameInput}
|
|
onChange={(e) => {
|
|
setNameInput(e.target.value);
|
|
setNameError("");
|
|
}}
|
|
onKeyDown={handleNameKeyDown}
|
|
className={cn(nameError && "border-destructive")}
|
|
/>
|
|
{nameError ? (
|
|
<p className="text-destructive text-sm">{nameError}</p>
|
|
) : null}
|
|
<Button
|
|
className="w-full"
|
|
onClick={() => void handleConfirmName()}
|
|
disabled={!nameInput.trim() || isCheckingName}
|
|
>
|
|
{t.agents.nameStepContinue}
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
</main>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
return (
|
|
<ThreadContext.Provider value={{ thread }}>
|
|
<ArtifactsProvider>
|
|
<div className="flex size-full flex-col">
|
|
{header}
|
|
|
|
<main className="flex min-h-0 flex-1 flex-col">
|
|
{showSaveHint ? (
|
|
<div className="px-4 pt-4">
|
|
<div className="mx-auto w-full max-w-(--container-width-md)">
|
|
<Alert>
|
|
<InfoIcon className="h-4 w-4" />
|
|
<AlertDescription>{t.agents.saveHint}</AlertDescription>
|
|
</Alert>
|
|
</div>
|
|
</div>
|
|
) : null}
|
|
|
|
<div className="flex min-h-0 flex-1 justify-center">
|
|
<MessageList
|
|
className={cn("size-full", showSaveHint ? "pt-4" : "pt-10")}
|
|
threadId={threadId}
|
|
thread={thread}
|
|
/>
|
|
</div>
|
|
|
|
<div className="bg-background flex shrink-0 justify-center border-t px-4 py-4">
|
|
<div className="w-full max-w-(--container-width-md)">
|
|
{agent ? (
|
|
<div className="flex flex-col items-center gap-4 rounded-2xl border py-8 text-center">
|
|
<CheckCircleIcon className="text-primary h-10 w-10" />
|
|
<p className="font-semibold">{t.agents.agentCreated}</p>
|
|
<div className="flex gap-2">
|
|
<Button
|
|
onClick={() =>
|
|
router.push(
|
|
`/workspace/agents/${agentName}/chats/new`,
|
|
)
|
|
}
|
|
>
|
|
{t.agents.startChatting}
|
|
</Button>
|
|
<Button
|
|
variant="outline"
|
|
onClick={() => router.push("/workspace/agents")}
|
|
>
|
|
{t.agents.backToGallery}
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
) : (
|
|
<PromptInput
|
|
onSubmit={({ text }) => void handleChatSubmit(text)}
|
|
>
|
|
<PromptInputTextarea
|
|
autoFocus
|
|
placeholder={t.agents.createPageSubtitle}
|
|
disabled={thread.isLoading}
|
|
/>
|
|
<PromptInputFooter className="justify-end">
|
|
<PromptInputSubmit disabled={thread.isLoading} />
|
|
</PromptInputFooter>
|
|
</PromptInput>
|
|
)}
|
|
</div>
|
|
</div>
|
|
</main>
|
|
</div>
|
|
</ArtifactsProvider>
|
|
</ThreadContext.Provider>
|
|
);
|
|
}
|