mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-05-26 18:06:00 +00:00
AochenShen99
e344be8d94
* feat(tests): add Blockbuster runtime gate for event-loop blocking IO Adds a strict runtime gate that fails CI when sync blocking IO calls run on the asyncio event loop thread through DeerFlow business code. Components: - backend/tests/support/detectors/blocking_io_runtime.py — Blockbuster context scoped to `app.*` and `deerflow.*` so test infrastructure, pytest internals, and third-party libraries stay silent. - backend/tests/blocking_io/conftest.py — pytest_runtest_protocol hookwrapper that wraps every item (setup + call + teardown) with the strict context. Respects `@pytest.mark.allow_blocking_io` opt-out. - backend/tests/blocking_io/test_skills_load.py — regression anchor for the #1917 fix (asyncio.to_thread offload around LocalSkillStorage.load_skills). - backend/tests/blocking_io/test_sqlite_lifespan.py — regression anchor for the #1912 fix (asyncio.to_thread offload around ensure_sqlite_parent_dir). - backend/tests/blocking_io/test_gate_smoke.py — meta-test asserting the gate actually catches unoffloaded blocking IO and that the `@pytest.mark.allow_blocking_io` opt-out works. - backend/Makefile — `make test-blocking-io` target. - .github/workflows/backend-blocking-io-tests.yml — hard-fail PR gate on ubuntu-latest. Windows matrix deferred to follow-up. Dependencies: - blockbuster>=1.5.26,<1.6 added to dev group. Coverage boundary (called out in PR body): the gate only catches blocking IO on code paths the test suite actually exercises. Static AST inventory (separate, informational) is the complementary coverage tool. Three blind spot categories — untested paths, mocked-away paths, env-mismatched paths — are documented in the PR description. Findings surfaced while authoring this PR: - resolve_sqlite_conn_str in runtime/store/_sqlite_utils.py:19 does sync Path.resolve() -> os.path.abspath on the lifespan loop thread, ahead of the #1912 fix. Not addressed here; tracked as follow-up. Tests: 4 passed locally (`make test-blocking-io`). Lint/format: clean (`ruff check` and `ruff format --check`). * fix(tests): scope Blockbuster gate to blocking-io suite * fix(tests): harden Blockbuster runtime gate * test(blocking-io): add project rule extension point * test(blocking-io): address review cleanup
45 lines
1.5 KiB
Python
45 lines
1.5 KiB
Python
"""Strict Blockbuster runtime context scoped to DeerFlow business code.
|
|
|
|
Creates a `BlockBuster` instance with `scanned_modules=("app", "deerflow")`
|
|
so that test infrastructure (pytest, langchain, importlib, third-party libs)
|
|
is out of scope and does not produce false positives. Only loop-blocking
|
|
sync IO whose caller stack passes through `app.*` or `deerflow.*` raises
|
|
`BlockingError`.
|
|
|
|
Used by `backend/tests/blocking_io/conftest.py` to gate the regression suite.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from collections.abc import Iterator
|
|
from contextlib import contextmanager
|
|
|
|
from blockbuster import BlockBuster, BlockBusterFunction, BlockingError
|
|
|
|
_SCANNED_MODULES: tuple[str, ...] = ("app", "deerflow")
|
|
|
|
# Add DeerFlow-local rules here only when Blockbuster's default rule set misses
|
|
# a generic blocking primitive used by production code. If a path is invisible
|
|
# because no test exercises it, add a production-path runtime anchor instead.
|
|
_PROJECT_BLOCKING_RULES: tuple[tuple[str, BlockBusterFunction], ...] = ()
|
|
|
|
|
|
def _install_project_rules(bb: BlockBuster) -> None:
|
|
for name, rule in _PROJECT_BLOCKING_RULES:
|
|
bb.functions[name] = rule
|
|
|
|
|
|
@contextmanager
|
|
def detect_blocking_io_strict() -> Iterator[BlockBuster]:
|
|
"""Activate Blockbuster scoped to app.* and deerflow.* callers only."""
|
|
bb = BlockBuster(scanned_modules=list(_SCANNED_MODULES))
|
|
_install_project_rules(bb)
|
|
try:
|
|
bb.activate()
|
|
yield bb
|
|
finally:
|
|
bb.deactivate()
|
|
|
|
|
|
__all__ = ["BlockingError", "detect_blocking_io_strict"]
|