rayhpeng
439c10d6f2
Following the rename/delete bug fix in PR1, migrate the remaining direct LangGraph Store reads/writes in the threads router and services to the ThreadMetaStore abstraction so that the sqlite and memory backends behave identically and the legacy dual-write paths can be removed. Migrated endpoints (threads.py): - create_thread: idempotency check + write now use thread_meta_repo.get/create instead of dual-writing the LangGraph Store and the SQL row. - get_thread: reads from thread_meta_repo.get; the checkpoint-only fallback for legacy threads is preserved. - patch_thread: replaced _store_get/_store_put with thread_meta_repo.update_metadata. - delete_thread_data: dropped the legacy store.adelete; thread_meta_repo.delete already covers it. Removed dead code (services.py): - _upsert_thread_in_store — redundant with the immediately following thread_meta_repo.create() call. - _sync_thread_title_after_run — worker.py's finally block already syncs the title via thread_meta_repo.update_display_name() after each run. Removed dead code (threads.py): - _store_get / _store_put / _store_upsert helpers (no remaining callers). - THREADS_NS constant. - get_store import (router no longer touches the LangGraph Store directly). New abstract method: - ThreadMetaStore.update_metadata(thread_id, metadata) merges metadata into the thread's metadata field. Implemented in both ThreadMetaRepository (SQL, read-modify-write inside one session) and MemoryThreadMetaStore. Three new unit tests cover merge / empty / nonexistent behaviour. Net change: -134 lines. Full test suite: 1693 passed, 14 skipped. Verified end-to-end with curl in gateway mode against sqlite backend (create / patch / get / rename / search / delete). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
158 lines
5.5 KiB
Python
158 lines
5.5 KiB
Python
"""Tests for ThreadMetaRepository (SQLAlchemy-backed)."""
|
|
|
|
import pytest
|
|
|
|
from deerflow.persistence.thread_meta import ThreadMetaRepository
|
|
|
|
|
|
async def _make_repo(tmp_path):
|
|
from deerflow.persistence.engine import get_session_factory, init_engine
|
|
|
|
url = f"sqlite+aiosqlite:///{tmp_path / 'test.db'}"
|
|
await init_engine("sqlite", url=url, sqlite_dir=str(tmp_path))
|
|
return ThreadMetaRepository(get_session_factory())
|
|
|
|
|
|
async def _cleanup():
|
|
from deerflow.persistence.engine import close_engine
|
|
|
|
await close_engine()
|
|
|
|
|
|
class TestThreadMetaRepository:
|
|
@pytest.mark.anyio
|
|
async def test_create_and_get(self, tmp_path):
|
|
repo = await _make_repo(tmp_path)
|
|
record = await repo.create("t1")
|
|
assert record["thread_id"] == "t1"
|
|
assert record["status"] == "idle"
|
|
assert "created_at" in record
|
|
|
|
fetched = await repo.get("t1")
|
|
assert fetched is not None
|
|
assert fetched["thread_id"] == "t1"
|
|
await _cleanup()
|
|
|
|
@pytest.mark.anyio
|
|
async def test_create_with_assistant_id(self, tmp_path):
|
|
repo = await _make_repo(tmp_path)
|
|
record = await repo.create("t1", assistant_id="agent1")
|
|
assert record["assistant_id"] == "agent1"
|
|
await _cleanup()
|
|
|
|
@pytest.mark.anyio
|
|
async def test_create_with_owner_and_display_name(self, tmp_path):
|
|
repo = await _make_repo(tmp_path)
|
|
record = await repo.create("t1", owner_id="user1", display_name="My Thread")
|
|
assert record["owner_id"] == "user1"
|
|
assert record["display_name"] == "My Thread"
|
|
await _cleanup()
|
|
|
|
@pytest.mark.anyio
|
|
async def test_create_with_metadata(self, tmp_path):
|
|
repo = await _make_repo(tmp_path)
|
|
record = await repo.create("t1", metadata={"key": "value"})
|
|
assert record["metadata"] == {"key": "value"}
|
|
await _cleanup()
|
|
|
|
@pytest.mark.anyio
|
|
async def test_get_nonexistent(self, tmp_path):
|
|
repo = await _make_repo(tmp_path)
|
|
assert await repo.get("nonexistent") is None
|
|
await _cleanup()
|
|
|
|
@pytest.mark.anyio
|
|
async def test_list_by_owner(self, tmp_path):
|
|
repo = await _make_repo(tmp_path)
|
|
await repo.create("t1", owner_id="user1")
|
|
await repo.create("t2", owner_id="user1")
|
|
await repo.create("t3", owner_id="user2")
|
|
results = await repo.list_by_owner("user1")
|
|
assert len(results) == 2
|
|
assert all(r["owner_id"] == "user1" for r in results)
|
|
await _cleanup()
|
|
|
|
@pytest.mark.anyio
|
|
async def test_list_by_owner_with_limit_and_offset(self, tmp_path):
|
|
repo = await _make_repo(tmp_path)
|
|
for i in range(5):
|
|
await repo.create(f"t{i}", owner_id="user1")
|
|
results = await repo.list_by_owner("user1", limit=2, offset=1)
|
|
assert len(results) == 2
|
|
await _cleanup()
|
|
|
|
@pytest.mark.anyio
|
|
async def test_check_access_no_record_allows(self, tmp_path):
|
|
repo = await _make_repo(tmp_path)
|
|
assert await repo.check_access("unknown", "user1") is True
|
|
await _cleanup()
|
|
|
|
@pytest.mark.anyio
|
|
async def test_check_access_owner_matches(self, tmp_path):
|
|
repo = await _make_repo(tmp_path)
|
|
await repo.create("t1", owner_id="user1")
|
|
assert await repo.check_access("t1", "user1") is True
|
|
await _cleanup()
|
|
|
|
@pytest.mark.anyio
|
|
async def test_check_access_owner_mismatch(self, tmp_path):
|
|
repo = await _make_repo(tmp_path)
|
|
await repo.create("t1", owner_id="user1")
|
|
assert await repo.check_access("t1", "user2") is False
|
|
await _cleanup()
|
|
|
|
@pytest.mark.anyio
|
|
async def test_check_access_no_owner_allows_all(self, tmp_path):
|
|
repo = await _make_repo(tmp_path)
|
|
await repo.create("t1") # owner_id=None
|
|
assert await repo.check_access("t1", "anyone") is True
|
|
await _cleanup()
|
|
|
|
@pytest.mark.anyio
|
|
async def test_update_status(self, tmp_path):
|
|
repo = await _make_repo(tmp_path)
|
|
await repo.create("t1")
|
|
await repo.update_status("t1", "busy")
|
|
record = await repo.get("t1")
|
|
assert record["status"] == "busy"
|
|
await _cleanup()
|
|
|
|
@pytest.mark.anyio
|
|
async def test_delete(self, tmp_path):
|
|
repo = await _make_repo(tmp_path)
|
|
await repo.create("t1")
|
|
await repo.delete("t1")
|
|
assert await repo.get("t1") is None
|
|
await _cleanup()
|
|
|
|
@pytest.mark.anyio
|
|
async def test_delete_nonexistent_is_noop(self, tmp_path):
|
|
repo = await _make_repo(tmp_path)
|
|
await repo.delete("nonexistent") # should not raise
|
|
await _cleanup()
|
|
|
|
@pytest.mark.anyio
|
|
async def test_update_metadata_merges(self, tmp_path):
|
|
repo = await _make_repo(tmp_path)
|
|
await repo.create("t1", metadata={"a": 1, "b": 2})
|
|
await repo.update_metadata("t1", {"b": 99, "c": 3})
|
|
record = await repo.get("t1")
|
|
# Existing key preserved, overlapping key overwritten, new key added
|
|
assert record["metadata"] == {"a": 1, "b": 99, "c": 3}
|
|
await _cleanup()
|
|
|
|
@pytest.mark.anyio
|
|
async def test_update_metadata_on_empty(self, tmp_path):
|
|
repo = await _make_repo(tmp_path)
|
|
await repo.create("t1")
|
|
await repo.update_metadata("t1", {"k": "v"})
|
|
record = await repo.get("t1")
|
|
assert record["metadata"] == {"k": "v"}
|
|
await _cleanup()
|
|
|
|
@pytest.mark.anyio
|
|
async def test_update_metadata_nonexistent_is_noop(self, tmp_path):
|
|
repo = await _make_repo(tmp_path)
|
|
await repo.update_metadata("nonexistent", {"k": "v"}) # should not raise
|
|
await _cleanup()
|