furyhawk/milvus
1
0
Fork 0
mirror of https://github.com/milvus-io/milvus.git synced 2026-07-21 10:15:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

enhance: remove hard-coded thread pool size limit of 16

Browse Source 
Remove the hard-coded maximum thread pool size limit of 16 in ThreadPool,
allowing the pool size to be fully controlled by yaml configuration
(CPU_NUM * thread_core_coefficient).

Signed-off-by: sijie-ni-0214 <sijie.ni@zilliz.com>
This commit is contained in:
sijie-ni-0214
2026-02-28 11:55:04 +08:00
parent dfe40bf960
commit ffd3435c4f
1 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/core/src/storage/ThreadPool.h
-10
View File
@@ -72,13 +72,6 @@ class ThreadPool {
max_threads_size_.store(std::max(
1,
static_cast<int>(std::round(CPU_NUM * thread_core_coefficient))));
// only IO pool will set large limit, but the CPU helps nothing to IO operations,
// we need to limit the max thread num, each thread will download 16~64 MiB data,
// according to our benchmark, 16 threads is enough to saturate the network bandwidth.
if (max_threads_size_.load() > 16) {
max_threads_size_.store(16);
}
LOG_INFO("Init thread pool:{}", name_)
<< " with min worker num:" << min_threads_size_
<< " and max worker num:" << max_threads_size_.load();
@@ -151,9 +144,6 @@ class ThreadPool {
//no need to hold mutex here as we don't require
//max_threads_size to take effect instantly, just guaranteed atomic
new_size = std::max(1, new_size);
if (new_size > 16) {
new_size = 16;
}
max_threads_size_.store(new_size);
}