mirror of
https://github.com/milvus-io/milvus.git
synced 2026-07-21 10:15:43 +00:00
wei liuandGitHub
156577c855
## Summary - Port fix from master (#46088, #46348) to 2.5 branch - When dynamically increasing `replicaNum` (e.g. 1→3 via `load()` without release), the old implementation required `readyLeaders >= replicaNum` per channel, causing a permanent deadlock because new replicas had no nodes yet - Switches to per-replica channel readiness check: only requires each channel to have at least one ready leader across all replicas issue: https://github.com/milvus-io/milvus/issues/48778, https://github.com/milvus-io/milvus/issues/46087 pr: https://github.com/milvus-io/milvus/pull/46088 ## Test plan - [x] Unit tests for `shouldUpdateCurrentTarget` (88.4% function coverage) - Empty next target → false - All channels ready → true - Partial channels ready → false - No ready delegators → false - **Replica scaling with empty new replicas** (deadlock fix scenario) → true - Multiple channels across multiple replicas → true - Sync failure / ListIndexes failure error paths - [x] E2E test `TestReplicaScaling1To3`: load(replica=1) → load(replica=3) without release → search OK - [x] Verified on v2.5.27 Docker: deadlock reproduced without fix, resolved with fix - [x] Verified on v2.6.14 Docker (3SN+3QN): no deadlock (architecture change avoids the issue) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Tests
E2E Test
Configuration Requirements
Operating System
| Operating System | Version |
|---|---|
| Amazon Linux | 2023 or above |
| Ubuntu | 20.04 or above |
| Mac | 10.14 or above |
Hardware
| Hardware Type | Recommended Configuration |
|---|---|
| CPU | x86_64 architecture Intel CPU Sandy Bridge or above CPU Instruction Set - SSE4_2 - AVX - AVX2 - AVX512 or arm64 Linux/MacOS |
| Memory | 16 GB or more |
Software
| Software Name | Version |
|---|---|
| Docker | 19.05 or above |
| Docker Compose | 1.25.5 or above |
| jq | 1.3 or above |
| kubectl | 1.14 or above |
| helm | 3.0 or above |
| kind | 0.10.0 or above |
Installing Dependencies
Troubleshooting Docker and Docker Compose
- Confirm that Docker Daemon is running：
$ docker info
-
Ensure that Docker is installed. Refer to the official installation instructions for Docker CE/EE.
-
Start the Docker Daemon if it is not already started.
-
To run Docker without
rootprivileges, create a user group labeleddocker, then add a user to the group withsudo usermod -aG docker $USER. Log out and log back into the terminal for the changes to take effect. For more information, see the official Docker documentation for Managing Docker as a Non-Root User.
- Check the version of Docker-Compose
$ docker compose version
docker compose version 1.25.5, build 8a1c60f6
docker-py version: 4.1.0
CPython version: 3.7.5
OpenSSL version: OpenSSL 1.1.1f 31 Mar 2020
- To install Docker-Compose, see Install Docker Compose
Install jq
Install kubectl
Install helm
- Refer to https://helm.sh/docs/intro/install/
Install kind
Run E2E Tests
$ cd tests/scripts
$ ./e2e-k8s.sh
Getting help
You can get help with the following command:
$ ./e2e-k8s.sh --help