Files
milvus/internal/proxy/trace_log_interceptor.go
wei liuandGitHub 4e1bf7a36c feat: define external snapshot API contracts (part1) (#50393)
issue: https://github.com/milvus-io/milvus/issues/44358

design doc:
docs/design-docs/design_docs/20260609-external-snapshot-export-restore.md

Part 1/3 of the external snapshot cross-bucket restore stack.

This PR defines the API contract and entry surfaces for external
snapshot export and restore:

- Adds the consolidated design document for cross-bucket external
snapshot restore.
- Adds public gRPC, REST, and Go SDK API surfaces for
RestoreExternalSnapshot and ExportSnapshot.
- Adds internal DataCoord proto plumbing and generated code needed by
later implementation PRs.
- Wires Proxy RBAC grouping and database interceptor behavior for the
new APIs.
- Keeps the request contract on a single external_spec field and keeps
db_name for namespace routing rather than permission scoping.

Validation copied from the commit:

- GOTOOLCHAIN=go1.25.10 go test -c -tags dynamic,test -gcflags="all=-N
-l" -ldflags="-r ${RPATH}" -o /tmp/datacoord-commit1.test
github.com/milvus-io/milvus/internal/datacoord
- cd client && GOTOOLCHAIN=go1.25.10 go test -c -o
/tmp/client-milvusclient-commit1.test ./milvusclient
- internal/proxy package compile was blocked locally by missing C++
header internal/core/output/include/segcore/search_result_export_c.h

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2026-07-01 16:32:29 +08:00

126 lines
4.5 KiB
Go

/*
* Licensed to the LF AI & Data foundation under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package proxy
import (
"context"
"path"
"google.golang.org/grpc"
"google.golang.org/protobuf/proto"
"github.com/milvus-io/milvus-proto/go-api/v3/milvuspb"
"github.com/milvus-io/milvus/pkg/v3/mlog"
"github.com/milvus-io/milvus/pkg/v3/util/externalspec"
"github.com/milvus-io/milvus/pkg/v3/util/requestutil"
)
func TraceLogInterceptor(ctx context.Context, req any, info *grpc.UnaryServerInfo, handler grpc.UnaryHandler) (interface{}, error) {
switch Params.CommonCfg.TraceLogMode.GetAsInt() {
case 0: // none
return handler(ctx, req)
case 1: // simple info
fields := GetRequestBaseInfo(ctx, req, info, false)
mlog.Info(ctx, "trace info: simple", fields...)
return handler(ctx, req)
case 2: // detail info
fields := GetRequestBaseInfo(ctx, req, info, true)
fields = append(fields, GetRequestFieldWithoutSensitiveInfo(req))
mlog.Info(ctx, "trace info: detail", fields...)
return handler(ctx, req)
case 3: // detail info with request and response
fields := GetRequestBaseInfo(ctx, req, info, true)
fields = append(fields, GetRequestFieldWithoutSensitiveInfo(req))
mlog.Info(ctx, "trace info: all request", fields...)
resp, err := handler(ctx, req)
if err != nil {
mlog.Info(ctx, "trace info: all, error", mlog.Err(err))
return resp, err
}
if status, ok := requestutil.GetStatusFromResponse(resp); ok {
if status.Code != 0 {
mlog.Info(ctx, "trace info: all, fail", mlog.Any("resp", resp))
}
} else {
mlog.Info(ctx, "trace info: all, unknown", mlog.Any("resp", resp))
}
return resp, nil
default:
return handler(ctx, req)
}
}
func GetRequestBaseInfo(ctx context.Context, req interface{}, info *grpc.UnaryServerInfo, skipBaseRequestInfo bool) []mlog.Field {
var fields []mlog.Field
_, requestName := path.Split(info.FullMethod)
fields = append(fields, mlog.String("request_name", requestName))
username, err := GetCurUserFromContext(ctx)
if err == nil && username != "" {
fields = append(fields, mlog.String("username", username))
}
if !skipBaseRequestInfo {
for baseInfoName, f := range requestutil.TraceLogBaseInfoFuncMap {
baseInfo, ok := f(req)
if !ok {
continue
}
fields = append(fields, mlog.Any(baseInfoName, baseInfo))
}
}
return fields
}
func GetRequestFieldWithoutSensitiveInfo(req interface{}) mlog.Field {
createCredentialReq, ok := req.(*milvuspb.CreateCredentialRequest)
if ok {
return mlog.Any("request", &milvuspb.CreateCredentialRequest{
Base: createCredentialReq.Base,
Username: createCredentialReq.Username,
CreatedUtcTimestamps: createCredentialReq.CreatedUtcTimestamps,
ModifiedUtcTimestamps: createCredentialReq.ModifiedUtcTimestamps,
})
}
updateCredentialReq, ok := req.(*milvuspb.UpdateCredentialRequest)
if ok {
return mlog.Any("request", &milvuspb.UpdateCredentialRequest{
Base: updateCredentialReq.Base,
Username: updateCredentialReq.Username,
CreatedUtcTimestamps: updateCredentialReq.CreatedUtcTimestamps,
ModifiedUtcTimestamps: updateCredentialReq.ModifiedUtcTimestamps,
})
}
restoreExternalSnapshotReq, ok := req.(*milvuspb.RestoreExternalSnapshotRequest)
if ok {
redactedReq := proto.Clone(restoreExternalSnapshotReq).(*milvuspb.RestoreExternalSnapshotRequest)
redactedReq.ExternalSpec = externalspec.RedactExternalSpec(redactedReq.GetExternalSpec())
return mlog.Any("request", redactedReq)
}
exportSnapshotReq, ok := req.(*milvuspb.ExportSnapshotRequest)
if ok {
redactedReq := proto.Clone(exportSnapshotReq).(*milvuspb.ExportSnapshotRequest)
redactedReq.ExternalSpec = externalspec.RedactExternalSpec(redactedReq.GetExternalSpec())
return mlog.Any("request", redactedReq)
}
return mlog.Any("request", req)
}