mirror of
https://github.com/milvus-io/milvus.git
synced 2026-07-21 10:15:43 +00:00
Zhen YeandGitHub
b07c62d53c
issue: #35917 - mlog package: move logger initialization, zap core, async buffered writes, field helpers, and scoped logger binding into pkg/mlog while removing pkg/log. - logging callsites: migrate Milvus logging usage to context-aware mlog APIs and simplify redundant With chains across components, utilities, tests, and tools. - trace propagation: replace logutil trace interceptors with mlog/tracer integration and add client_request_id fallback propagation for server stats handlers. --------- Signed-off-by: chyezh <chyezh@outlook.com>
54 lines
2.5 KiB
Go
54 lines
2.5 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package querycoordv2
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/cockroachdb/errors"
|
|
|
|
"github.com/milvus-io/milvus/internal/querycoordv2/job"
|
|
"github.com/milvus-io/milvus/internal/querycoordv2/meta"
|
|
"github.com/milvus-io/milvus/pkg/v3/mlog"
|
|
"github.com/milvus-io/milvus/pkg/v3/streaming/util/message"
|
|
"github.com/milvus-io/milvus/pkg/v3/util/merr"
|
|
)
|
|
|
|
// alterLoadConfigV2AckCallback is called when the put load config message is acknowledged
|
|
func (s *Server) alterLoadConfigV2AckCallback(ctx context.Context, result message.BroadcastResultAlterLoadConfigMessageV2) error {
|
|
// currently, we only sent the put load config message to the control channel
|
|
// TODO: after we support query view in 3.0, we should broadcast the put load config message to all vchannels.
|
|
job := job.NewLoadCollectionJob(ctx, result, s.dist, s.meta, s.broker, s.targetMgr, s.targetObserver, s.collectionObserver, s.checkerController, s.nodeMgr, s.proxyClientManager)
|
|
if err := job.Execute(); err != nil {
|
|
// The collection's channel is already in dropped-sentinel state, meaning
|
|
// a concurrent DropCollection has landed at the channel level on this
|
|
// cluster (typically on a CDC replica). The load can never succeed; ack
|
|
// the broadcast so the broadcaster stops retrying forever and the
|
|
// pending rootcoord meta cleanup can complete. Mirrors the
|
|
// ErrCollectionNotFound early-return inside LoadCollectionJob.Execute().
|
|
if errors.Is(err, merr.ErrChannelDroppedSentinel) {
|
|
mlog.Warn(ctx, "ack alter load config: collection channel is dropped sentinel",
|
|
mlog.FieldCollectionID(result.Message.Header().GetCollectionId()),
|
|
mlog.Err(err))
|
|
return nil
|
|
}
|
|
return err
|
|
}
|
|
meta.GlobalFailedLoadCache.Remove(result.Message.Header().GetCollectionId())
|
|
return nil
|
|
}
|