mirror of
https://github.com/milvus-io/milvus.git
synced 2026-07-21 18:25:44 +00:00
wei liuandGitHub
821acb5c03
issue: https://github.com/milvus-io/milvus/issues/45881 ## What - Install required external-table Python dependencies in the go-client image and in the go-sdk-e2e runtime path before tests execute. - Derive the go-sdk MinIO address and bucket from the Milvus test address when explicit `MINIO_*` environment variables are not provided. - Remove format-specific dependency skip paths from external-table Go e2e tests so Iceberg, Lance, Vortex, and Parquet coverage is not silently skipped when dependencies are available. - Consolidate Parquet, Lance, Vortex, and Iceberg data generation so each external format has one maintained generator profile. - Keep the latest master snapshot-restore e2e coverage by mapping its Parquet payload to the shared Python generator. ## Why The previous go-sdk-e2e setup could report green while external-table cases were skipped because Python dependencies were missing or the tests assumed a fixed local MinIO address and bucket. This makes the CI image/runtime satisfy those dependencies and lets the tests discover the MinIO endpoint used by the generated go-sdk cluster. ## Validation - `git fetch milvus master` - `git rebase milvus/master` - `git diff --check HEAD~1..HEAD` - `gofmt -l` on changed Go external-table tests - `bash -n tests/go_client/scripts/install_external_table_python_deps.sh` - `python3 -m py_compile` on changed data-generation scripts Signed-off-by: Wei Liu <wei.liu@zilliz.com>