mirror of
https://github.com/milvus-io/milvus.git
synced 2026-07-21 18:25:44 +00:00
## What does this PR do? Adds Python e2e coverage for JSON filtering UNKNOWN semantics in `tests/python_client/milvus_client/expressions/test_milvus_client_json_filtering.py`. This PR covers: - raw filtering paths on growing and sealed segments - JSON arithmetic/filtering UNKNOWN behavior for missing, null, and type-mismatch values - JSON array predicate behavior for missing and non-array values - ARRAY subscript UNKNOWN behavior for null, empty, and out-of-range values - contradiction rewrite cases, including outer `not (...)`, to ensure UNKNOWN is not rewritten into TRUE - JSON path index filtering with `json_cast_type=DOUBLE` - JSON path index filtering with `json_cast_type=VARCHAR` - JSON flat index coverage for currently passing UNKNOWN cases - query/search filter consistency for representative JSON filters, including indexed collections - L2 coverage for boolean JSON values, fractional double values, additional comparison/logical operators, JSON path array subscripts, mixed arrays, and `ARRAY_DOUBLE` JSON path index The known JSON flat index array-vs-scalar comparison mismatch is documented in #51193 and covered by a skipped regression case so the coverage can land first without taking server-side fixes in this PR. issue: #50976 issue: #51193 Related #50699 #50698 ## Test Plan - [x] `git diff --check` - result: passed - [x] `uvx ruff check --config tests/ruff.toml tests/python_client/milvus_client/expressions/test_milvus_client_json_filtering.py` - result: passed - [x] `uvx ruff format --check --config tests/ruff.toml tests/python_client/milvus_client/expressions/test_milvus_client_json_filtering.py` - result: passed - [x] `/Users/yanliang.qiao/fork/milvus/tests/.venv/bin/python -W ignore -m pytest milvus_client/expressions/test_milvus_client_json_filtering.py --collect-only -q` - result: `29 tests collected` - [x] `milvus-dev-cli deploy create harbor.milvus.io/manta/milvus:master-20260709-9a0d7f2 --name json-filtering-l2-9a0d7f2 --namespace chaos-testing --no-auth --wait-timeout 1800 --wait-interval 10` - result: Healthy - endpoint: `lb-6d57ndgl-sw4giqjhodl3bn15.clb.bj-tencentclb.net:19530` - [x] `/Users/yanliang.qiao/fork/milvus/tests/.venv/bin/python -W ignore -m pytest milvus_client/expressions/test_milvus_client_json_filtering.py --uri http://lb-6d57ndgl-sw4giqjhodl3bn15.clb.bj-tencentclb.net:19530 --token "" -s -v --tb=short` - result: `28 passed, 1 skipped in 215.82s` ## Notes The skipped case is `test_json_flat_index_array_scalar_comparison_unknown_semantics_query`, linked to #51193. The skip can be removed after the server-side JSON flat index UNKNOWN semantics issue is fixed. Signed-off-by: Yanliang Qiao <yanliang.qiao@zilliz.com>
Expression Filtering Tests
This directory contains comprehensive test modules for Milvus client expression filtering capabilities.
Test Modules
1. test_milvus_client_scalar_expression_filtering_optimized.py
Primary test module for comprehensive scalar expression filtering
Features:
- Tests all Milvus-supported scalar data types (INT8, INT16, INT32, INT64, BOOL, FLOAT, DOUBLE, VARCHAR, ARRAY, JSON)
- Covers all operators: Comparison (==, !=, >, <, >=, <=), Range (IN, LIKE), Arithmetic (+, -, *, /, %, **), Logical (AND, OR, NOT), Null (IS NULL, IS NOT NULL)
- Single collection design with multiple index types for efficiency
- Index consistency verification (same results for indexed vs non-indexed fields)
- Comprehensive error handling and failure debugging
- Automatic reproduction script generation
- Test complex Json expression (JSON[JSON], JSON[LIST[JSON]], JSON[JSON[LIST]], etc)
Key Design:
- One collection containing all data types
- Each data type has multiple fields representing different index types
- 10% of data is NULL to test IS NULL/IS NOT NULL operators
- Specific VARCHAR patterns:
str_xxx,xxx_str,xxx_str_xxx - Comprehensive LIKE pattern coverage with escape handling
- Create examples of typed, dynamic, and shared keys in json
- Generate expressions to valida query result
2. test_milvus_client_scalar_expression_filtering.py
Legacy comprehensive scalar expression filtering test
Features:
- Original comprehensive test implementation
- Multiple collection approach
- Extensive test coverage for all data types and operators
- Detailed validation logic
3. test_milvus_client_random_expression_generator.py
Random expression generation for edge case testing
Features:
- Generates random complex expressions
- Tests edge cases and unusual combinations
- Stress testing for expression parsing
- Random data generation with various patterns
Data Type Coverage
Supported Scalar Types
- Numeric: INT8, INT16, INT32, INT64, FLOAT, DOUBLE
- Boolean: BOOL
- String: VARCHAR
- Array: ARRAY (with all element types)
- JSON: JSON (with complex nested structures)
Array Element Types
- All scalar types: INT8, INT16, INT32, INT64, BOOL, FLOAT, DOUBLE, VARCHAR
Operator Coverage
Comparison Operators
==,!=,>,<,>=,<=
Range Operators
IN(with array indexing support)LIKE(with comprehensive pattern coverage)
Arithmetic Operators
+,-,*,/,%,**
Logical Operators
AND,OR,NOT
Null Operators
IS NULL,IS NOT NULL
Array Functions
- Array indexing:
field[index]
JSON Functions
- JSON key access:
field['key']
Index Type Support
Scalar Index Types
| Data Types | INVERTED | BITMAP | STL_SORT | Trie | NGRAM | AUTOINDEX |
|---|---|---|---|---|---|---|
| INT8, INT16, INT32, INT64 | yes | yes | yes | no | no | yes |
| BOOL | yes | yes | no | no | no | yes |
| FLOAT, DOUBLE | yes | no | yes | no | no | yes |
| VARCHAR | yes | yes | no | yes | yes | yes |
| JSON | yes | no | no | no | yes* | yes |
| ARRAY (elements: BOOL, INT8, INT16, INT32, INT64, VARCHAR) | yes | yes | no | no | no | yes |
| ARRAY (elements: FLOAT, DOUBLE) | yes | no | no | no | no | yes |
*JSON fields require json_path and json_cast_type: "varchar" parameters for NGRAM index
NGRAM Index Specific Features
The NGRAM index is specialized for efficient text partial matching and fuzzy search on VARCHAR and JSON fields.
Supported Fields:
- VARCHAR: Direct text content indexing
- JSON: Requires
json_pathparameter to specify the JSON field path (e.g.,field_name['key'])
Index Parameters:
min_gram: Minimum n-gram length (required, positive integer)max_gram: Maximum n-gram length (required, positive integer, ≥ min_gram)json_path: JSON field path for JSON fields (e.g.,"json_field['body']")json_cast_type: Must be"varchar"for JSON fields
Performance Characteristics:
- Optimized for LIKE queries with
%and_wildcards - Two-phase query execution: n-gram filtering + secondary validation
- Query strings shorter than
min_gramfall back to full table scan - Supports multilingual text including Chinese, Japanese, and Korean
Example Index Creation:
# VARCHAR field
index_params.add_index(
field_name="content",
index_type="NGRAM",
params={"min_gram": 2, "max_gram": 3}
)
# JSON field
index_params.add_index(
field_name="json_field",
index_type="NGRAM",
params={
"min_gram": 2,
"max_gram": 3,
"json_path": "json_field['body']",
"json_cast_type": "varchar"
}
)
Test Features
Error Handling
- Parsing error detection and skipping
- Graceful handling of unsupported expressions
- Detailed error reporting
Debugging Support
- Automatic debug info saving on failure
- Parquet file export for test data
- Reproduction script generation
- Schema and configuration preservation
Validation Logic
- Ground truth calculation using Python lambdas
- Result count and ID verification
- Index consistency verification
LIKE Pattern Coverage
- Prefix patterns:
str% - Suffix patterns:
%str - Contains patterns:
%str% - Single character wildcard:
str_,_str - Combination patterns:
str_%,%_str - Escape patterns:
str\%,str\_
NGRAM Index Optimization:
- LIKE queries on VARCHAR and JSON fields with NGRAM index are automatically optimized
- Query performance significantly improves for pattern matching operations
- Supports all LIKE patterns with
%and_wildcards - Automatic fallback to full scan when query length <
min_gram
Usage
Running Tests
# Run optimized test
pytest test_milvus_client_scalar_expression_filtering_optimized.py
# Run legacy comprehensive test
pytest test_milvus_client_scalar_expression_filtering.py
# Run random expression generator
pytest test_milvus_client_random_expression_generator.py
# Run NGRAM index specific tests
pytest ../../testcases/indexes/test_ngram.py
Debug Information
On test failure, debug information is automatically saved to /tmp/ci_logs/:
- Test data as Parquet files
- Collection schema and configuration
- Failed expressions list
- Reproduction script
Reproduction Script
The generated reproduction script can:
- Rebuild the entire test environment
- Recreate schema, data, and indexes
- Re-run failed expressions
- Validate results
Design Principles
- Comprehensive Coverage: Test all supported data types, operators, and index types (including NGRAM)
- Efficiency: Single collection design for optimal performance
- Reliability: Robust error handling and debugging
- Maintainability: Clear code structure and documentation
- Reproducibility: Automatic failure reproduction capabilities
- Index Optimization: Validate performance improvements with specialized indexes like NGRAM