mirror of
https://github.com/milvus-io/milvus.git
synced 2026-07-21 02:05:41 +00:00
issue: #51493 ### What #50221 split the `status` label values of `milvus_proxy_req_count` / `milvus_proxy_grpc_latency` in place. Released in **v2.6.19**, that silently zeroes every existing dashboard panel and alert rule matching `status="fail"` / `status="rejected"` — an alert that stops firing rather than erroring. This keeps the classification but moves it onto its own dimension, restoring the status domain to what <= v2.6.18 emitted: ``` status: success | fail | rejected | retry | total | abandon (as before v2.6.19) cause: user | system | cancel | na (new) ``` | v2.6.19 / v2.6.20 | this PR | |---|---| | `status="fail_input"` | `status="fail", cause="user"` | | `status="fail_system"` | `status="fail", cause="system"` | | `status="rejected_user"` | `status="rejected", cause="user"` | | `status="rejected_system"` | `status="rejected", cause="system"` | | `status="cancel"` | `status="fail"` or `"rejected"`, `cause="cancel"` | | `success` / `retry` / `total` / `abandon` | unchanged, `cause="na"` | ### Why a label instead of new status values - **Old queries work unchanged and count each request once.** `status="fail"` is again every hard failure; Prometheus aggregates over `cause` for free. That rollup is what a label dimension *is* — the split forces every consumer who just wants "how many failures" to hand-write `status=~"fail_.*"`. - **Cardinality is unchanged.** `cause` is functionally dependent on the outcome, so the realized `(status, cause)` pairs are exactly the series the split already produces. Additive, not multiplicative. - **New consumers lose nothing**: alert on `status="fail", cause="system"`; route `cause="user"` to the owning application team. The alternative — emitting old and new `status` values side by side during a transition — was rejected: it defers the break rather than removing it (the old values must still be dropped eventually, forcing the same migration later), and meanwhile double-counts every request in unfiltered aggregations. `cancel` is folded into `cause` for the same reason: before v2.6.19 client cancellations were counted as `fail` (cancel in the response status) or `rejected` (cancel at the interceptor), so promoting it to a `status` value quietly makes `status="fail"` under-count versus older releases. As a cause it stays excludable via `cause!="cancel"` without redefining `status`. ### Also in this PR - The 7 `snapshot_impl` sites that emitted a bare `fail` with no classification now report their real cause via `failMetricLabel(err)` (e.g. `snapshot_metadata_uri is required` is `cause="user"`, not a system fault). Their `status` is unchanged. - `deployments/monitor/grafana/milvus-dashboard.json`: the "Faild Request Rate" panel goes back to `status="fail"` — a verbatim revert of what #50221 changed, which is the compatibility claim demonstrated. - Dev docs and stale comments that named the old label values. ### Verification - `TestParseMetricLabelStatusDomainIsStable` pins the status domain, so re-splitting it fails CI rather than shipping. - Adding a label makes every `WithLabelValues` site arity-sensitive **at runtime, not compile time** — a missed site panics in production. Unit tests do not reach all of them (coverage shows `GetRestoreSnapshotState`, `ListRestoreSnapshotJobs`, `PinSnapshotData`, `UnpinSnapshotData` at 0%), so all **58 emit sites were verified statically via AST**, not only the ones tests happen to hit. - Passing: `pkg/metrics`, `pkg/util/requestutil`, `pkg/util/merr`, `internal/distributed/proxy` (incl. `httpserver`, which covers the REST emit path), and the `internal/proxy` snapshot / metric-label tests. `golangci-lint` clean on every touched package. - Pre-existing and unrelated: `service_test.go` bind failures (`listen tcp :19529: address already in use`) reproduce identically on unmodified master — a local process holds the port. ### Rollout Should be cherry-picked to 2.6 so the window in which the fine-grained `status` values exist stays confined to v2.6.19–v2.6.20. Users who already adopted the new values on those two releases need a one-time query change (`status="fail_system"` -> `status="fail", cause="system"`); that is a known, bounded set, and preferable to leaving every pre-2.6.19 dashboard silently broken. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
298 lines
8.5 KiB
Go
298 lines
8.5 KiB
Go
/*
|
|
* Licensed to the LF AI & Data foundation under one
|
|
* or more contributor license agreements. See the NOTICE file
|
|
* distributed with this work for additional information
|
|
* regarding copyright ownership. The ASF licenses this file
|
|
* to you under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package requestutil
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/cockroachdb/errors"
|
|
"google.golang.org/grpc/codes"
|
|
grpcstatus "google.golang.org/grpc/status"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v3/commonpb"
|
|
"github.com/milvus-io/milvus-proto/go-api/v3/schemapb"
|
|
"github.com/milvus-io/milvus/pkg/v3/metrics"
|
|
"github.com/milvus-io/milvus/pkg/v3/util/merr"
|
|
"github.com/milvus-io/milvus/pkg/v3/util/typeutil"
|
|
)
|
|
|
|
type CollectionNameGetter interface {
|
|
GetCollectionName() string
|
|
}
|
|
|
|
func GetCollectionNameFromRequest(req any) (any, bool) {
|
|
getter, ok := req.(CollectionNameGetter)
|
|
if !ok {
|
|
return "", false
|
|
}
|
|
return getter.GetCollectionName(), true
|
|
}
|
|
|
|
type CollectionNamesGetter interface {
|
|
GetCollectionNames() []string
|
|
}
|
|
|
|
func GetCollectionNamesFromRequest(req any) (any, bool) {
|
|
getter, ok := req.(CollectionNamesGetter)
|
|
if !ok {
|
|
return nil, false
|
|
}
|
|
return getter.GetCollectionNames(), true
|
|
}
|
|
|
|
type DBNameGetter interface {
|
|
GetDbName() string
|
|
}
|
|
|
|
func GetDbNameFromRequest(req interface{}) (any, bool) {
|
|
getter, ok := req.(DBNameGetter)
|
|
if !ok {
|
|
return "", false
|
|
}
|
|
return getter.GetDbName(), true
|
|
}
|
|
|
|
type PartitionNameGetter interface {
|
|
GetPartitionName() string
|
|
}
|
|
|
|
func GetPartitionNameFromRequest(req interface{}) (any, bool) {
|
|
getter, ok := req.(PartitionNameGetter)
|
|
if !ok {
|
|
return "", false
|
|
}
|
|
return getter.GetPartitionName(), true
|
|
}
|
|
|
|
type PartitionNamesGetter interface {
|
|
GetPartitionNames() []string
|
|
}
|
|
|
|
func GetPartitionNamesFromRequest(req interface{}) (any, bool) {
|
|
getter, ok := req.(PartitionNamesGetter)
|
|
if !ok {
|
|
return nil, false
|
|
}
|
|
return getter.GetPartitionNames(), true
|
|
}
|
|
|
|
type FieldNameGetter interface {
|
|
GetFieldName() string
|
|
}
|
|
|
|
func GetFieldNameFromRequest(req interface{}) (any, bool) {
|
|
getter, ok := req.(FieldNameGetter)
|
|
if !ok {
|
|
return "", false
|
|
}
|
|
return getter.GetFieldName(), true
|
|
}
|
|
|
|
type OutputFieldsGetter interface {
|
|
GetOutputFields() []string
|
|
}
|
|
|
|
func GetOutputFieldsFromRequest(req interface{}) (any, bool) {
|
|
getter, ok := req.(OutputFieldsGetter)
|
|
if !ok {
|
|
return nil, false
|
|
}
|
|
return getter.GetOutputFields(), true
|
|
}
|
|
|
|
type QueryParamsGetter interface {
|
|
GetQueryParams() []*commonpb.KeyValuePair
|
|
}
|
|
|
|
func GetQueryParamsFromRequest(req interface{}) (any, bool) {
|
|
getter, ok := req.(QueryParamsGetter)
|
|
if !ok {
|
|
return nil, false
|
|
}
|
|
return getter.GetQueryParams(), true
|
|
}
|
|
|
|
type ExprGetter interface {
|
|
GetExpr() string
|
|
}
|
|
|
|
func GetExprFromRequest(req interface{}) (any, bool) {
|
|
getter, ok := req.(ExprGetter)
|
|
if !ok {
|
|
return "", false
|
|
}
|
|
return getter.GetExpr(), true
|
|
}
|
|
|
|
type SearchParamsGetter interface {
|
|
GetSearchParams() []*commonpb.KeyValuePair
|
|
}
|
|
|
|
func GetSearchParamsFromRequest(req interface{}) (any, bool) {
|
|
getter, ok := req.(SearchParamsGetter)
|
|
if !ok {
|
|
return nil, false
|
|
}
|
|
return getter.GetSearchParams(), true
|
|
}
|
|
|
|
type DSLGetter interface {
|
|
GetDsl() string
|
|
}
|
|
|
|
func GetDSLFromRequest(req interface{}) (any, bool) {
|
|
getter, ok := req.(DSLGetter)
|
|
if !ok {
|
|
return "", false
|
|
}
|
|
return getter.GetDsl(), true
|
|
}
|
|
|
|
type StatusGetter interface {
|
|
GetStatus() *commonpb.Status
|
|
}
|
|
|
|
func GetStatusFromResponse(resp interface{}) (*commonpb.Status, bool) {
|
|
status, ok := resp.(*commonpb.Status)
|
|
if ok {
|
|
return status, true
|
|
}
|
|
getter, ok := resp.(StatusGetter)
|
|
if !ok {
|
|
return nil, false
|
|
}
|
|
return getter.GetStatus(), true
|
|
}
|
|
|
|
type ConsistencyLevelGetter interface {
|
|
GetConsistencyLevel() commonpb.ConsistencyLevel
|
|
}
|
|
|
|
func GetConsistencyLevelFromRequst(req interface{}) (commonpb.ConsistencyLevel, bool) {
|
|
getter, ok := req.(ConsistencyLevelGetter)
|
|
if !ok {
|
|
return 0, false
|
|
}
|
|
return getter.GetConsistencyLevel(), true
|
|
}
|
|
|
|
// TemplateValuesGetter is the common interface for getting expr template values from milvus requests.
|
|
type TemplateValuesGetter interface {
|
|
GetExprTemplateValues() map[string]*schemapb.TemplateValue
|
|
}
|
|
|
|
func GetExprTemplateValues(req any) (map[string]*schemapb.TemplateValue, bool) {
|
|
getter, ok := req.(TemplateValuesGetter)
|
|
if !ok {
|
|
return nil, false
|
|
}
|
|
return getter.GetExprTemplateValues(), true
|
|
}
|
|
|
|
var TraceLogBaseInfoFuncMap = map[string]func(interface{}) (any, bool){
|
|
"collection_name": GetCollectionNameFromRequest,
|
|
"db_name": GetDbNameFromRequest,
|
|
"partition_name": GetPartitionNameFromRequest,
|
|
"partition_names": GetPartitionNamesFromRequest,
|
|
"field_name": GetFieldNameFromRequest,
|
|
"output_fields": GetOutputFieldsFromRequest,
|
|
"query_params": GetQueryParamsFromRequest,
|
|
"expr": GetExprFromRequest,
|
|
"search_params": GetSearchParamsFromRequest,
|
|
"dsl": GetDSLFromRequest,
|
|
}
|
|
|
|
var retryableCode typeutil.Set[int32] = typeutil.NewSet(
|
|
merr.Code(merr.ErrServiceRateLimit),
|
|
merr.Code(merr.ErrCollectionSchemaMismatch),
|
|
)
|
|
|
|
// func init() {
|
|
// retryableCode = typeutil.NewSet(
|
|
// merr.Code(merr.ErrServiceRateLimit),
|
|
// merr.Code(merr.ErrCollectionSchemaMismatch),
|
|
// )
|
|
// }
|
|
|
|
// ParseMetricLabel determines the Prometheus status and cause labels of a
|
|
// finished request. The status domain is the coarse outcome and is deliberately
|
|
// the same one pre-2.6.19 emitted, so a query written against it keeps its
|
|
// meaning; cause is an orthogonal dimension naming the responsible party, which
|
|
// Prometheus aggregates away for consumers that only ask for the status.
|
|
// Retryability takes priority over classification.
|
|
func ParseMetricLabel(resp any, err error) (status string, cause string) {
|
|
// A response carrying a non-OK status means the request was PROCESSED and
|
|
// failed, and takes priority over a non-nil err: the REST v2 wrappers
|
|
// reconstruct err = merr.Error(status) from that same response, which
|
|
// otherwise routes every processed REST failure into the rejected buckets
|
|
// and leaves the fail series blind to the entire REST surface.
|
|
var st *commonpb.Status
|
|
switch resp := resp.(type) {
|
|
case interface{ GetStatus() *commonpb.Status }:
|
|
st = resp.GetStatus()
|
|
case *commonpb.Status:
|
|
st = resp
|
|
}
|
|
if st != nil && !merr.Ok(st) {
|
|
// Client cancellation is neither party's failure, but it stays a "fail"
|
|
// like it was before the cause dimension existed; cause is what lets a
|
|
// consumer exclude it.
|
|
if st.GetCode() == merr.CanceledCode {
|
|
return metrics.FailLabel, metrics.CauseCancel
|
|
}
|
|
// Retryability takes priority over classification.
|
|
if retryableCode.Contain(st.GetCode()) {
|
|
return metrics.RetryLabel, metrics.CauseNA
|
|
}
|
|
|
|
// Hard failure: classify by responsible party. merr.Status already
|
|
// stamps the InputError flag into ExtraInfo, so read it directly instead
|
|
// of reconstructing the whole milvusError (this is the proxy hot path).
|
|
if st.GetExtraInfo()[merr.InputErrorFlagKey] == "true" {
|
|
return metrics.FailLabel, metrics.CauseUser
|
|
}
|
|
return metrics.FailLabel, metrics.CauseSystem
|
|
}
|
|
|
|
// No usable response status: err is the interceptor-level outcome (context
|
|
// cancellation, flow control, transport issues, auth/privilege rejection)
|
|
// — the request was rejected around processing. Classify merr first: a
|
|
// merr error has no GRPCStatus(), so grpcstatus.Code(err) degrades to
|
|
// codes.Unknown and would misbucket user input errors as system
|
|
// rejections. The auth/privilege interceptors deliberately return raw gRPC
|
|
// codes (not merr, to keep SDK retry behavior correct); those are the
|
|
// caller's fault, so bucket them as a user-side rejection. Everything else
|
|
// is a system-side rejection.
|
|
if err != nil {
|
|
if errors.Is(err, context.Canceled) {
|
|
return metrics.RejectedLabel, metrics.CauseCancel
|
|
}
|
|
if merr.GetErrorType(err) == merr.InputError {
|
|
return metrics.RejectedLabel, metrics.CauseUser
|
|
}
|
|
switch grpcstatus.Code(err) {
|
|
case codes.Unauthenticated, codes.PermissionDenied, codes.InvalidArgument:
|
|
return metrics.RejectedLabel, metrics.CauseUser
|
|
default:
|
|
return metrics.RejectedLabel, metrics.CauseSystem
|
|
}
|
|
}
|
|
return metrics.SuccessLabel, metrics.CauseNA
|
|
}
|