Files
milvus/internal/querynodev2/pipeline/delete_node.go
T
5eebaa9ad4 enhance: add WAL trace propagation (#50796)
issue: #47404

- message trace context: add trace context serialization and
restore/inject helpers for WAL messages and msgstream conversion
- WAL append trace: normalize WAL spans for autocommit, txn, broadcast,
append, appendimpl, and broadcast callback paths
- trace propagation: restore message trace context in producer,
broadcast retry, replicate primary/secondary, recovery, flusher, and
query/data flowgraph consumers

---------

Signed-off-by: chyezh <chyezh@outlook.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-07-15 02:14:37 +08:00

126 lines
4.1 KiB
Go

// Licensed to the LF AI & Data foundation under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package pipeline
import (
"context"
"fmt"
"github.com/samber/lo"
"github.com/milvus-io/milvus/internal/querynodev2/delegator"
"github.com/milvus-io/milvus/internal/storage"
base "github.com/milvus-io/milvus/internal/util/pipeline"
"github.com/milvus-io/milvus/pkg/v3/metrics"
"github.com/milvus-io/milvus/pkg/v3/mlog"
"github.com/milvus-io/milvus/pkg/v3/util/paramtable"
)
type deleteNode struct {
*BaseNode
collectionID UniqueID
channel string
manager *DataManager
delegator delegator.ShardDelegator
}
// addDeleteData find the segment of delete column in DeleteMsg and save in deleteData
func (dNode *deleteNode) addDeleteData(deleteDatas map[UniqueID]*delegator.DeleteData, msg *DeleteMsg) {
ctx := msg.TraceCtx()
deleteData, ok := deleteDatas[msg.PartitionID]
if !ok {
deleteData = &delegator.DeleteData{
PartitionID: msg.PartitionID,
}
deleteDatas[msg.PartitionID] = deleteData
}
pks := storage.ParseIDs2PrimaryKeys(msg.PrimaryKeys)
deleteData.PrimaryKeys = append(deleteData.PrimaryKeys, pks...)
deleteData.Timestamps = append(deleteData.Timestamps, msg.Timestamps...)
deleteData.RowCount += int64(len(pks))
mlog.Info(ctx, "pipeline fetch delete msg",
mlog.FieldCollectionID(dNode.collectionID),
mlog.FieldPartitionID(msg.PartitionID),
mlog.Int("deleteRowNum", len(pks)),
mlog.Uint64("timestampMin", msg.BeginTimestamp),
mlog.Uint64("timestampMax", msg.EndTimestamp))
}
func (dNode *deleteNode) Operate(in Msg) Msg {
metrics.QueryNodeWaitProcessingMsgCount.WithLabelValues(paramtable.GetStringNodeID(), metrics.DeleteLabel).Dec()
nodeMsg := in.(*deleteNodeMsg)
if len(nodeMsg.deleteMsgs) > 0 {
deleteDataByTs := make(map[uint64]map[UniqueID]*delegator.DeleteData)
// deleteMsgs are ordered by WAL timetick within a vchannel; keep first-seen EndTs order
// because the delete buffer expects non-decreasing timestamps on Put.
tsOrder := make([]uint64, 0)
for _, msg := range nodeMsg.deleteMsgs {
ts := msg.EndTs()
deleteDatas, ok := deleteDataByTs[ts]
if !ok {
deleteDatas = make(map[UniqueID]*delegator.DeleteData)
deleteDataByTs[ts] = deleteDatas
tsOrder = append(tsOrder, ts)
}
dNode.addDeleteData(deleteDatas, msg)
}
batches := make([]delegator.DeleteBatch, 0, len(tsOrder))
for _, ts := range tsOrder {
batches = append(batches, delegator.DeleteBatch{
Ts: ts,
Data: lo.Values(deleteDataByTs[ts]),
})
}
dNode.delegator.ProcessDeleteBatches(batches)
}
if nodeMsg.schema != nil {
ctx := context.TODO()
if err := dNode.delegator.UpdateSchema(ctx, nodeMsg.schema, nodeMsg.schemaBarrierTs); err != nil {
mlog.Warn(ctx, "failed to update schema in delete node",
mlog.Int64("collectionID", dNode.collectionID),
mlog.String("channel", dNode.channel),
mlog.Int32("schemaVersion", nodeMsg.schema.GetVersion()),
mlog.Uint64("schemaBarrierTs", nodeMsg.schemaBarrierTs),
mlog.Err(err))
}
}
// update tSafe
dNode.delegator.UpdateTSafe(nodeMsg.timeRange.timestampMax)
return nil
}
func newDeleteNode(
collectionID UniqueID, channel string,
manager *DataManager, delegator delegator.ShardDelegator,
maxQueueLength int32,
) *deleteNode {
return &deleteNode{
BaseNode: base.NewBaseNode(fmt.Sprintf("DeleteNode-%s", channel), maxQueueLength),
collectionID: collectionID,
channel: channel,
manager: manager,
delegator: delegator,
}
}