mirror of
https://github.com/milvus-io/milvus.git
synced 2026-07-21 10:15:43 +00:00
issue: #49156 ## Summary - Record `cost_time` / `cost_cpu_num` on DataNode index build tasks and surface them through `QueryTask` response `Properties`. - Reserve the unified `cost_time` / `cost_cpu_num` keys under `pkg/taskcommon` so future PRs can wire up the other `CreateTask`-dispatched task types. - Introduce small `internal/datanode/taskcost` helper (`NowMs`, `ElapsedMs`, `EstimateIndexBuildCPUNum`) for index build task cost accounting. - Final state/failReason and execution-end cost are written in a single `TaskManager` critical section, and `QueryTask` reads them from a single snapshot, so state and cost in one response are always consistent. ## Notes This PR is producer-side only. DataCoord / proxy / metrics exporter do not consume these properties yet; downstream consumption should land in a follow-up linked from #49156. `cost_cpu_num` is a coarse, statistics-only estimate for observability (vector index ≈ knowhere build pool size = NumCPU in cluster mode; scalar index = 1). It is not used for coordinator-side scheduling, so the standalone pool-ratio deviation (NumCPU × buildIndexThreadPoolRatio) and pool sharing across concurrent builds are intentionally not modeled. Supersedes #49157 (that PR's head branch was rebased onto latest master and force-pushed, so GitHub no longer allows reopening it). Content is identical, rebased to a single commit on top of current master. ## Test plan - [x] `go test ./taskcommon/...` from `pkg/` - [x] `go test -tags dynamic,test -gcflags="all=-N -l" -count=1 ./internal/datanode/taskcost` - [ ] `go test -tags dynamic,test -gcflags="all=-N -l" -count=1 ./internal/datanode/index -run 'TestIndexTaskSchedulerRecordsIndexTaskCost|Test_statsTaskInfoSuite/Test_IndexTaskCostMethods'` - [ ] Manual sanity: `QueryTask` returns `cost_time` / `cost_cpu_num` for DataNode index build task success and failure paths. --------- Signed-off-by: cai.zhang <cai.zhang@zilliz.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
188 lines
6.2 KiB
Go
188 lines
6.2 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package index
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/suite"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v3/commonpb"
|
|
"github.com/milvus-io/milvus/pkg/v3/common"
|
|
"github.com/milvus-io/milvus/pkg/v3/proto/datapb"
|
|
"github.com/milvus-io/milvus/pkg/v3/proto/indexpb"
|
|
)
|
|
|
|
type statsTaskInfoSuite struct {
|
|
suite.Suite
|
|
|
|
ctx context.Context
|
|
manager *TaskManager
|
|
|
|
cluster string
|
|
taskID int64
|
|
}
|
|
|
|
func Test_statsTaskInfoSuite(t *testing.T) {
|
|
suite.Run(t, new(statsTaskInfoSuite))
|
|
}
|
|
|
|
func (s *statsTaskInfoSuite) SetupSuite() {
|
|
s.manager = NewTaskManager(context.Background())
|
|
|
|
s.cluster = "test"
|
|
s.taskID = 100
|
|
}
|
|
|
|
func (s *statsTaskInfoSuite) Test_Methods() {
|
|
baseManifest := "test_base_manifest_path"
|
|
textBaseManifest := "test_text_base_manifest_path"
|
|
manifest := "test_manifest_path"
|
|
jsonKeyStatsLogs := map[int64]*datapb.JsonKeyStats{
|
|
100: {
|
|
FieldID: 100,
|
|
Version: 1,
|
|
Files: []string{"file1"},
|
|
LogSize: 1024,
|
|
MemorySize: 1024,
|
|
JsonKeyStatsDataFormat: common.JSONStatsDataFormatVersion,
|
|
},
|
|
}
|
|
|
|
s.Run("loadOrStoreStatsTask", func() {
|
|
_, cancel := context.WithCancel(s.manager.ctx) //nolint:gosec // cancel is deferred below
|
|
defer cancel()
|
|
info := &StatsTaskInfo{
|
|
Cancel: cancel,
|
|
State: indexpb.JobState_JobStateInProgress,
|
|
}
|
|
|
|
reInfo := s.manager.LoadOrStoreStatsTask(s.cluster, s.taskID, info)
|
|
s.Nil(reInfo)
|
|
|
|
reInfo = s.manager.LoadOrStoreStatsTask(s.cluster, s.taskID, info)
|
|
s.Equal(indexpb.JobState_JobStateInProgress, reInfo.State)
|
|
})
|
|
|
|
s.Run("getStatsTaskState", func() {
|
|
s.Equal(indexpb.JobState_JobStateInProgress, s.manager.GetStatsTaskState(s.cluster, s.taskID))
|
|
s.Equal(indexpb.JobState_JobStateNone, s.manager.GetStatsTaskState(s.cluster, s.taskID+1))
|
|
})
|
|
|
|
s.Run("storeStatsTaskState", func() {
|
|
s.manager.StoreStatsTaskState(s.cluster, s.taskID, indexpb.JobState_JobStateFinished, "finished")
|
|
s.Equal(indexpb.JobState_JobStateFinished, s.manager.GetStatsTaskState(s.cluster, s.taskID))
|
|
})
|
|
|
|
s.Run("storeStatsResult", func() {
|
|
s.manager.StorePKSortStatsResult(s.cluster, s.taskID, 1, 2, 3, "ch1", 65535,
|
|
[]*datapb.FieldBinlog{{FieldID: 100, Binlogs: []*datapb.Binlog{{LogID: 1}}}},
|
|
[]*datapb.FieldBinlog{{FieldID: 100, Binlogs: []*datapb.Binlog{{LogID: 2}}}},
|
|
[]*datapb.FieldBinlog{},
|
|
"test_manifest_path",
|
|
)
|
|
})
|
|
|
|
s.Run("storeStatsTextIndexResult", func() {
|
|
s.manager.StoreStatsTextIndexResult(s.cluster, s.taskID, 1, 2, 3, "ch1",
|
|
map[int64]*datapb.TextIndexStats{
|
|
100: {
|
|
FieldID: 100,
|
|
Version: 1,
|
|
Files: []string{"file1"},
|
|
LogSize: 1024,
|
|
MemorySize: 1024,
|
|
},
|
|
}, textBaseManifest, "test_manifest_path")
|
|
|
|
taskInfo := s.manager.GetStatsTaskInfo(s.cluster, s.taskID)
|
|
s.Equal(textBaseManifest, taskInfo.ToStatsResult(s.taskID).GetBaseManifest())
|
|
})
|
|
|
|
s.Run("storeStatsJsonIndexResult", func() {
|
|
s.manager.StoreJSONKeyStatsResult(s.cluster, s.taskID, 1, 2, 3, "ch1",
|
|
jsonKeyStatsLogs, baseManifest, manifest)
|
|
})
|
|
|
|
s.Run("getStatsTaskInfo", func() {
|
|
taskInfo := s.manager.GetStatsTaskInfo(s.cluster, s.taskID)
|
|
|
|
s.Equal(indexpb.JobState_JobStateFinished, taskInfo.State)
|
|
s.Equal(int64(1), taskInfo.CollID)
|
|
s.Equal(int64(2), taskInfo.PartID)
|
|
s.Equal(int64(3), taskInfo.SegID)
|
|
s.Equal("ch1", taskInfo.InsertChannel)
|
|
s.Equal(int64(65535), taskInfo.NumRows)
|
|
|
|
result := taskInfo.ToStatsResult(s.taskID)
|
|
s.Equal(baseManifest, result.GetBaseManifest())
|
|
s.Equal(manifest, result.GetManifest())
|
|
s.Equal(jsonKeyStatsLogs, result.GetJsonKeyStatsLogs())
|
|
})
|
|
|
|
s.Run("deleteStatsTaskInfos", func() {
|
|
s.manager.DeleteStatsTaskInfos(s.ctx, []Key{{ClusterID: s.cluster, TaskID: s.taskID}})
|
|
|
|
s.Nil(s.manager.GetStatsTaskInfo(s.cluster, s.taskID))
|
|
})
|
|
}
|
|
|
|
func (s *statsTaskInfoSuite) TestIndexTaskInfoReturnsIndexStorePathVersion() {
|
|
info := &IndexTaskInfo{
|
|
State: commonpb.IndexState_Finished,
|
|
IndexStorePathVersion: indexpb.IndexStorePathVersion_INDEX_STORE_PATH_VERSION_COLLECTION_ROOTED,
|
|
}
|
|
|
|
s.Equal(
|
|
indexpb.IndexStorePathVersion_INDEX_STORE_PATH_VERSION_COLLECTION_ROOTED,
|
|
info.ToIndexTaskInfo(100).GetIndexStorePathVersion(),
|
|
)
|
|
|
|
cloned := info.Clone()
|
|
s.Equal(indexpb.IndexStorePathVersion_INDEX_STORE_PATH_VERSION_COLLECTION_ROOTED, cloned.IndexStorePathVersion)
|
|
}
|
|
|
|
func (s *statsTaskInfoSuite) Test_IndexTaskCostMethods() {
|
|
buildID := int64(200)
|
|
s.manager.LoadOrStoreIndexTask(s.cluster, buildID, &IndexTaskInfo{State: commonpb.IndexState_InProgress})
|
|
|
|
s.manager.StoreIndexTaskExecutionStart(s.cluster, buildID, 111, 4)
|
|
s.manager.StoreIndexTaskExecutionEndWithState(s.cluster, buildID, 222, 111, commonpb.IndexState_Failed, "mock failure")
|
|
|
|
info := s.manager.GetIndexTaskInfo(s.cluster, buildID)
|
|
s.Require().NotNil(info)
|
|
s.Equal(int64(111), info.ExecStartMs)
|
|
s.Equal(int64(222), info.ExecEndMs)
|
|
s.Equal(int64(111), info.CostTimeMs)
|
|
s.Equal(int64(4), info.CostCPUNum)
|
|
// state/failReason land together with the cost in one critical section
|
|
s.Equal(commonpb.IndexState_Failed, info.State)
|
|
s.Equal("mock failure", info.FailReason)
|
|
|
|
info.CostCPUNum = 999
|
|
reloaded := s.manager.GetIndexTaskInfo(s.cluster, buildID)
|
|
s.Equal(int64(4), reloaded.CostCPUNum)
|
|
|
|
s.manager.StoreIndexTaskExecutionStart(s.cluster, buildID, 333, 8)
|
|
reloaded = s.manager.GetIndexTaskInfo(s.cluster, buildID)
|
|
s.Equal(int64(333), reloaded.ExecStartMs)
|
|
s.Equal(int64(8), reloaded.CostCPUNum)
|
|
s.Equal(int64(0), reloaded.ExecEndMs)
|
|
s.Equal(int64(0), reloaded.CostTimeMs)
|
|
}
|