Files
milvus/internal/datacoord/compaction_trigger.go
T
e2787d3981 enhance: standardize error handling on merr + Sys/Input classification (#50221)
issue: #47420

## What this PR does

Project-wide migration of raw `fmt.Errorf` / `errors.New` in function
bodies onto
the `merr` framework, plus the Sys-vs-Input error classification and the
machinery it drives (retriability, fine-grained metrics, segcore
unification),
plus the convention docs and a linter that keeps it from regressing.

Scope: storage, proxy, coordinators (root/data/query), query node, data
node,
`pkg/util` & `internal/util`, expression parser, message queue,
streaming, and
misc packages. Bare raw-error usages went from ~3000 to a ~340 allowlist
(package-level sentinels / build-tag / test sites).

---

## How to review this PR

It is large but the vast majority is mechanical. Changes fall into three
tiers;
spend review budget on Part 2 and Part 3.

### Part 1 — Mechanical standardization (low risk, verify by rule)

Each converted call follows one of a small fixed set of rules. To
review, check
that each site obeys the matching rule rather than reading every line:

| Pattern | Rule |
|---|---|
| `fmt.Errorf("...")` originating a new error | →
`merr.WrapErrXxxMsg("...")` with a code matching the failure's meaning |
| Adding context to an existing typed error | → `merr.Wrap(err, "...")`
/ `merr.Wrapf(...)` — **preserves** the inner code (never `WrapErr*Err`,
which overwrites it) |
| Errors inside the streaming subsystem | → `status.New*` factories
(StreamingError), **not** merr — this is the component-internal dialect
(see `docs/dev/error_handling_guide.md`) |
| Low-level / control-flow signal caught by `errors.Is` | → kept as a
package-level `errors.New` sentinel (lowercase, same-package) |

Conventions are documented in `docs/dev/error_handling_guide.md`
(how-to) and
`docs/dev/error_sentinel_convention.md` (rules + audit). A
`gocritic`/`ruleguard`
rule (`rawmerrerror`, in `rules.go`) enforces "no raw `return
errors.New/fmt.Errorf`"
under `make verifiers`.

### Part 2 — Behavior changes (review these closely)

These are the sites where the wire contract or runtime behavior changes,
not just
the source text. Listed by category; representative locations given,
full set in
the diff.

**A. gRPC wire-code shifts: `UnexpectedError(1)/Code 65535` → typed
code.**
Where a handler previously returned a raw error (collapsed to
`Code=65535` on the
wire), it now returns a typed merr, so the client sees a real code. The
most
common shift is to `IllegalArgument(5)/Code 1100` (ParameterInvalid).
Touch
points include datanode task handlers (CreateTask/Query/Drop), proxy
Upsert,
querynode GetMetrics, datacoord CreateIndex, httpserver query-response
builder,
and typeutil schema validation. One code refinement: an index-param
validation
moved `1100` → `1101` (ParameterMissing). **Client/SDK assertions and
any code
that switched on `Code=65535` for these paths must be re-checked** (the
go_client
e2e assertions were already aligned in this PR).

**B. Prometheus `status` label contract change (externally visible).**
The proxy metric's coarse `fail` / `rejected` values are split into
`fail_input` / `fail_system` and `rejected_user` / `rejected_system` (in
`requestutil.ParseMetricLabel`; auth/privilege rejections count as
`rejected_user`), so dashboards can attribute a failure to caller vs
operator.
**Dashboards/alerts querying `status="fail"` must migrate to
`status=~"fail_.*"`, and `status="rejected"` to
`status=~"rejected_.*"`.** The
in-repo Grafana dashboard is already migrated; external dashboards built
on the
old values silently go empty after upgrade. This is the one change that
requires an ops-side migration.

**C. Retriability semantics.**
- C1: `merr.Status(err)` now forces `Retriable=false` when the error is
an
`InputError` — a malformed request can never succeed on blind retry, so
clients
never get the self-contradictory "your input is wrong but you may
retry".
- C2: `retry.Do` short-circuits an `InputError` (non-retriable) — **but
only when
  the caller did not pass a `RetryErr` predicate**. The check is an
`if c.isRetryErr != nil { ... } else if InputError { ... }` *mutually
exclusive*
branch (`pkg/util/retry/retry.go`): an explicit `RetryErr` takes
precedence and
bypasses the InputError abort. `retry.Handle` deliberately does **not**
apply
the InputError abort (its callers signal abort via `shouldRetry=false`).
Four
flusher startup callsites that must retry through transient "not ready"
errors
  were given explicit `RetryErr` escape hatches.

**D. segcore (C++→Go) error classification.**
A single shared Go-side table (`pkg/util/merr/segcore.go`) maps each
segcore code
to a merr sentinel + InputError/signal category, replacing scattered
hand-written
`if errorCode == ...` switches in the cgo wrappers. **Wire `Code` values
change
for every segcore pass-through error, not just the remapped ones.**
Named
sentinels remap (C++ `2003` → merr `2001`, `2033` → `2002`,
Folly/Knowhere codes
likewise); **all remaining pass-through codes (`2004`–`2043`, previously
surfaced to clients as raw C++ enum values) now serialize as `2000`**
(`ErrSegcore`), with the original C++ code preserved in the `Reason`
text
(`segcoreCode=...`); unknown/future codes collapse to `2000` as well
(pinned by
the `wire_code_projection` test). Transient segcore classes (object
storage /
file IO / OOM / mmap / FieldNotLoaded — 11 codes) now report
`Retriable=true`.
**Any client switching on raw segcore codes in the `2004`–`2043` range
must be
re-checked**; the in-Reason code remains available for diagnostics.
Signal
codes (PretendFinished / FollyCancel) are recognized centrally.
`errors.Is`-based
control flow on these (e.g. scheduler skip/retry) is preserved.

**E. InputError classification (25 sentinels + dynamic marks).**
25 sentinels in `errors.go` carry `WithErrorType(InputError)` (the
Collection /
ResourceGroup / Database families, `ErrIndexDuplicate`,
`ErrParameterInvalid`,
`ErrPrivilegeNotAuthenticated`, `ErrImportFailed`, `ErrQueryPlan`, ...),
plus dynamic
marks for the 8 segcore input codes (ExprInvalid, DimNotMatch,
MetricTypeInvalid, FieldIDInvalid, ...) and
`WrapErrAsInputError`. The widest blast radius is `ErrParameterInvalid`
(1100):
~2335 `WrapErrParameterInvalid*` callsites now classify as input /
non-retriable. Because of C1/C2 this changes retriability for
any path that returns these. **The audit to confirm no transient path
was
mis-marked is the single most important review item** (see Part 3). One
reverse
correction: storage field-stats parsing moved from `ErrParameterInvalid`
(input)
to `ErrDataIntegrity` — a corrupted stored stat is data corruption, not
user
input.

### Part 3 — Known risks & traps (called out proactively)

1. **`merr.Wrap` vs `WrapErr*Err` (code-masking).** `WrapErr*Err` builds
a
`wrappedMilvusError{sentinel: ErrServiceInternal}` whose `code()`
returns the
*outer* sentinel — it overwrites the inner typed code and hides the
`errors.Is`
chain. This is intentional (use it to *deliberately* downgrade), but it
was a
recurring conversion defect; the rule "add context with `merr.Wrap`,
downgrade
with `WrapErr*Err`" is enforced by convention and reviewed across the
diff.
2. **InputError × `retry.Do` blast radius.** Marking a sentinel
`InputError` makes
any `retry.Do(...)` without a `RetryErr` predicate stop retrying it.
Reviewers
should sanity-check that no transient use of the 19 newly-marked
sentinels
(especially `ErrParameterInvalid`) sits inside a retry loop that needed
to keep
   spinning. The known flusher cases were handled (see C2).
3. **The ~340 raw-error allowlist.** What remains as bare `errors.New`
is, by
design: package-level sentinels (caught by `errors.Is`), `//go:build
test`
sites, and out-of-band trees (`cmd/`, `tests/`, codegen, walimpls). The
linter
only bans the *direct-return* form; assignment-then-return escapes and
the full
no-exceptions ban are deferred to an AST-based linter (Tier 2,
documented).
4. **segcore C++ second step deferred.** This PR unifies classification
on the Go
side; splitting the dual-semantic C++ codes at the source is a
follow-up.

---

## Validation

- `make verifiers`: Go side clean (gofmt + static-check across modules,
including
  the new `rawmerrerror` rule with a 0-hit baseline repo-wide).
- `make test-go`: passing; the one real regression introduced (a
datanode
`invalid_task_type` assertion shifting `1` → `5` from a ParameterInvalid
  conversion) was fixed in-tree.
- go_client e2e CreateIndex assertions aligned to the new merr messages.

---------

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-06-12 15:04:51 -07:00

937 lines
32 KiB
Go

// Licensed to the LF AI & Data foundation under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package datacoord
import (
"context"
"fmt"
"math"
"sync"
"time"
"github.com/samber/lo"
"go.uber.org/zap"
"github.com/milvus-io/milvus-proto/go-api/v3/commonpb"
"github.com/milvus-io/milvus-proto/go-api/v3/msgpb"
"github.com/milvus-io/milvus/internal/datacoord/allocator"
"github.com/milvus-io/milvus/internal/util/vecindexmgr"
"github.com/milvus-io/milvus/pkg/v3/common"
"github.com/milvus-io/milvus/pkg/v3/log"
"github.com/milvus-io/milvus/pkg/v3/proto/datapb"
"github.com/milvus-io/milvus/pkg/v3/util/lifetime"
"github.com/milvus-io/milvus/pkg/v3/util/logutil"
"github.com/milvus-io/milvus/pkg/v3/util/merr"
"github.com/milvus-io/milvus/pkg/v3/util/paramtable"
"github.com/milvus-io/milvus/pkg/v3/util/tsoutil"
"github.com/milvus-io/milvus/pkg/v3/util/typeutil"
)
type compactTime struct {
startTime Timestamp
expireTime Timestamp
collectionTTL time.Duration
}
// todo: migrate to compaction_trigger_v2
type trigger interface {
start()
stop()
TriggerCompaction(ctx context.Context, signal *compactionSignal) (signalID UniqueID, err error)
}
type compactionSignal struct {
id UniqueID
isForce bool
collectionID UniqueID
partitionID UniqueID
channel string
segmentIDs []UniqueID
pos *msgpb.MsgPosition
resultCh chan error
waitResult bool
}
func NewCompactionSignal() *compactionSignal {
return &compactionSignal{
resultCh: make(chan error, 1),
waitResult: true,
}
}
func (cs *compactionSignal) WithID(id UniqueID) *compactionSignal {
cs.id = id
return cs
}
func (cs *compactionSignal) WithIsForce(isForce bool) *compactionSignal {
cs.isForce = isForce
return cs
}
func (cs *compactionSignal) WithCollectionID(collectionID UniqueID) *compactionSignal {
cs.collectionID = collectionID
return cs
}
func (cs *compactionSignal) WithPartitionID(partitionID UniqueID) *compactionSignal {
cs.partitionID = partitionID
return cs
}
func (cs *compactionSignal) WithChannel(channel string) *compactionSignal {
cs.channel = channel
return cs
}
func (cs *compactionSignal) WithSegmentIDs(segmentIDs ...UniqueID) *compactionSignal {
cs.segmentIDs = segmentIDs
return cs
}
func (cs *compactionSignal) WithWaitResult(waitResult bool) *compactionSignal {
cs.waitResult = waitResult
return cs
}
func (cs *compactionSignal) Notify(result error) {
select {
case cs.resultCh <- result:
default:
}
}
var _ trigger = (*compactionTrigger)(nil)
type compactionTrigger struct {
handler Handler
meta *meta
allocator allocator.Allocator
signals chan *compactionSignal
manualSignals chan *compactionSignal
inspector CompactionInspector
globalTrigger *time.Ticker
closeCh lifetime.SafeChan
closeWaiter sync.WaitGroup
indexEngineVersionManager IndexEngineVersionManager
// A sloopy hack, so we can test with different segment row count without worrying that
// they are re-calculated in every compaction.
testingOnly bool
}
func newCompactionTrigger(
meta *meta,
inspector CompactionInspector,
allocator allocator.Allocator,
handler Handler,
indexVersionManager IndexEngineVersionManager,
) *compactionTrigger {
return &compactionTrigger{
meta: meta,
allocator: allocator,
signals: make(chan *compactionSignal, 100),
manualSignals: make(chan *compactionSignal, 100),
inspector: inspector,
indexEngineVersionManager: indexVersionManager,
handler: handler,
closeCh: lifetime.NewSafeChan(),
}
}
func (t *compactionTrigger) start() {
t.globalTrigger = time.NewTicker(Params.DataCoordCfg.MixCompactionTriggerInterval.GetAsDuration(time.Second))
t.closeWaiter.Add(2)
go func() {
defer t.closeWaiter.Done()
t.work()
}()
go func() {
defer t.closeWaiter.Done()
t.schedule()
}()
}
// schedule method triggers global signal by configured interval.
func (t *compactionTrigger) schedule() {
defer logutil.LogPanic()
// If AutoCompaction disabled, global loop will not start
if !Params.DataCoordCfg.EnableAutoCompaction.GetAsBool() {
return
}
for {
select {
case <-t.closeCh.CloseCh():
t.globalTrigger.Stop()
log.Info("global compaction loop exit")
return
case <-t.globalTrigger.C:
// default signal, all collections withi isGlobal = true
_, err := t.TriggerCompaction(context.Background(),
NewCompactionSignal())
if err != nil {
log.Warn("unable to triggerCompaction", zap.Error(err))
}
}
}
}
// work method listens the signal channels and generate plans from them.
func (t *compactionTrigger) work() {
defer logutil.LogPanic()
for {
var signal *compactionSignal
select {
case <-t.closeCh.CloseCh():
log.Info("compaction trigger quit")
return
case signal = <-t.signals:
case signal = <-t.manualSignals:
}
err := t.handleSignal(signal)
if err != nil {
log.Warn("unable to handleSignal", zap.Int64("signalID", signal.id), zap.Error(err))
}
signal.Notify(err)
}
}
func (t *compactionTrigger) stop() {
t.closeCh.Close()
t.closeWaiter.Wait()
}
func (t *compactionTrigger) getCollection(collectionID UniqueID) (*collectionInfo, error) {
ctx, cancel := context.WithTimeout(context.Background(), time.Second)
defer cancel()
coll, err := t.handler.GetCollection(ctx, collectionID)
if err != nil {
return nil, merr.Wrapf(err, "collection ID %d not found", collectionID)
}
return coll, nil
}
func isCollectionAutoCompactionEnabled(coll *collectionInfo) bool {
if coll == nil {
return false
}
if coll.IsExternal() {
log.Debug("collection auto compaction disabled for external collection", zap.Int64("collectionID", coll.ID))
return false
}
enabled, err := getCollectionAutoCompactionEnabled(coll.Properties)
if err != nil {
log.Warn("collection properties auto compaction not valid, returning false", zap.Error(err))
return false
}
return enabled
}
func getCompactTime(ts Timestamp, coll *collectionInfo) (*compactTime, error) {
collectionTTL, err := common.GetCollectionTTLFromMap(coll.Properties)
if err != nil {
return nil, err
}
pts, _ := tsoutil.ParseTS(ts)
if collectionTTL > 0 {
ttexpired := pts.Add(-collectionTTL)
ttexpiredLogic := tsoutil.ComposeTS(ttexpired.UnixNano()/int64(time.Millisecond), 0)
return &compactTime{ts, ttexpiredLogic, collectionTTL}, nil
}
// no expiration time
return &compactTime{ts, 0, 0}, nil
}
// TrigerCompaction is the public interface to send compaction signal to work queue.
// when waitResult = true, it waits until the result is returned from worker(via `signal.resultCh`)
// or the context is timeouted/canceled
// otherwise, it just try best to submit the signal to the channel, if the channel is full it just returns err
//
// by default, `signals` channel will be used to send compaction signal
// however, when the `isForce` flag is true, the `manualSignals` channel will be used to skip the queueing
// since manual signals shall have higher priority.
func (t *compactionTrigger) TriggerCompaction(ctx context.Context, signal *compactionSignal) (signalID UniqueID, err error) {
// If AutoCompaction disabled, flush request will not trigger compaction
if !paramtable.Get().DataCoordCfg.EnableAutoCompaction.GetAsBool() && !paramtable.Get().DataCoordCfg.EnableCompaction.GetAsBool() {
return -1, nil
}
id, err := t.allocSignalID(ctx)
if err != nil {
return -1, err
}
signal.WithID(id)
signalCh := t.signals
// use force signal channel to skip non-force signal queue
if signal.isForce {
signalCh = t.manualSignals
}
// non force mode, try best to sent signal only
if !signal.waitResult {
select {
case signalCh <- signal:
default:
log.Info("no space to send compaction signal",
zap.Int64("collectionID", signal.collectionID),
zap.Int64s("segmentID", signal.segmentIDs),
zap.String("channel", signal.channel))
return -1, merr.WrapErrServiceUnavailable("signal channel is full")
}
return id, nil
}
// force flag make sure signal is handle and returns error if any
select {
case signalCh <- signal:
case <-ctx.Done():
return -1, ctx.Err()
}
select {
case err = <-signal.resultCh:
return id, err
case <-ctx.Done():
return -1, ctx.Err()
}
}
func (t *compactionTrigger) allocSignalID(ctx context.Context) (UniqueID, error) {
ctx, cancel := context.WithTimeout(ctx, 5*time.Second)
defer cancel()
return t.allocator.AllocID(ctx)
}
// handleSignal is the internal logic to convert compactionSignal into compaction tasks.
func (t *compactionTrigger) handleSignal(signal *compactionSignal) error {
log := log.With(zap.Int64("compactionID", signal.id),
zap.Int64("signal.collectionID", signal.collectionID),
zap.Int64("signal.partitionID", signal.partitionID),
zap.Int64s("signal.segmentIDs", signal.segmentIDs))
if !signal.isForce && t.inspector.isFull() {
log.Warn("skip to generate compaction plan due to handler full")
return merr.WrapErrServiceQuotaExceeded("compaction handler full")
}
log.Info("handleSignal receive")
groups, err := t.getCandidates(signal)
if err != nil {
log.Warn("handle signal failed, get candidates return error", zap.Error(err))
return err
}
if len(groups) == 0 {
log.Info("the length of candidate group is 0, skip to handle signal")
return nil
}
for _, group := range groups {
log := log.With(
zap.Int64("group.partitionID", group.partitionID),
zap.String("group.channel", group.channelName),
)
if !signal.isForce && t.inspector.isFull() {
log.Warn("skip to generate compaction plan due to handler full")
return merr.WrapErrServiceQuotaExceeded("compaction handler full")
}
if Params.DataCoordCfg.IndexBasedCompaction.GetAsBool() {
group.segments = FilterInIndexedSegments(context.Background(), t.handler, t.meta, signal.isForce, group.segments...)
}
coll, err := t.getCollection(group.collectionID)
if err != nil {
log.Warn("get collection info failed, skip handling compaction", zap.Error(err))
if signal.collectionID != 0 {
return err
}
continue
}
if !signal.isForce && !isCollectionAutoCompactionEnabled(coll) {
log.RatedInfo(20, "collection auto compaction disabled")
return nil
}
ct, err := getCompactTime(tsoutil.ComposeTSByTime(time.Now(), 0), coll)
if err != nil {
log.Warn("get compact time failed, skip to handle compaction")
return err
}
expectedSize := getExpectedSegmentSize(t.meta, coll.ID, coll.Schema)
plans := t.generatePlans(group.segments, signal, ct, expectedSize)
for _, plan := range plans {
if !signal.isForce && t.inspector.isFull() {
log.Warn("skip to generate compaction plan due to handler full")
return merr.WrapErrServiceQuotaExceeded("compaction handler full")
}
totalRows, inputSegmentIDs := plan.A, plan.B
n := 11 * paramtable.Get().DataCoordCfg.CompactionPreAllocateIDExpansionFactor.GetAsInt64()
startID, endID, err := t.allocator.AllocN(n)
if err != nil {
log.Warn("fail to allocate id", zap.Error(err))
return err
}
start := time.Now()
pts, _ := tsoutil.ParseTS(ct.startTime)
task := &datapb.CompactionTask{
PlanID: startID,
TriggerID: signal.id,
State: datapb.CompactionTaskState_pipelining,
StartTime: pts.Unix(),
Type: datapb.CompactionType_MixCompaction,
CollectionTtl: ct.collectionTTL.Nanoseconds(),
CollectionID: group.collectionID,
PartitionID: group.partitionID,
Channel: group.channelName,
InputSegments: inputSegmentIDs,
ResultSegments: []int64{},
TotalRows: totalRows,
Schema: coll.Schema,
MaxSize: expectedSize,
PreAllocatedSegmentIDs: &datapb.IDRange{
Begin: startID + 1,
End: endID,
},
}
err = t.inspector.enqueueCompaction(task)
if err != nil {
log.Warn("failed to execute compaction task",
zap.Int64("planID", task.GetPlanID()),
zap.Int64s("inputSegments", inputSegmentIDs),
zap.Error(err))
continue
}
log.Info("time cost of generating compaction",
zap.Int64("planID", task.GetPlanID()),
zap.Int64("time cost", time.Since(start).Milliseconds()),
zap.Int64("target size", task.GetMaxSize()),
zap.Int64s("inputSegments", inputSegmentIDs))
}
}
return nil
}
func (t *compactionTrigger) generatePlans(segments []*SegmentInfo, signal *compactionSignal, compactTime *compactTime, expectedSize int64) []*typeutil.Pair[int64, []int64] {
if len(segments) == 0 {
log.Warn("the number of candidate segments is 0, skip to generate compaction plan")
return []*typeutil.Pair[int64, []int64]{}
}
// find segments need internal compaction
// TODO add low priority candidates, for example if the segment is smaller than full 0.9 * max segment size but larger than small segment boundary, we only execute compaction when there are no compaction running actively
var prioritizedCandidates []*SegmentInfo
var smallCandidates []*SegmentInfo
var nonPlannedSegments []*SegmentInfo
// TODO, currently we lack of the measurement of data distribution, there should be another compaction help on redistributing segment based on scalar/vector field distribution
for _, segment := range segments {
segment := segment.ShadowClone()
// TODO should we trigger compaction periodically even if the segment has no obvious reason to be compacted?
if signal.isForce || t.ShouldDoSingleCompaction(segment, compactTime) {
prioritizedCandidates = append(prioritizedCandidates, segment)
} else if t.isSmallSegment(segment, expectedSize) {
smallCandidates = append(smallCandidates, segment)
} else {
nonPlannedSegments = append(nonPlannedSegments, segment)
}
}
buckets := [][]*SegmentInfo{}
toUpdate := newSegmentPacker("update", prioritizedCandidates, compactTime)
toMerge := newSegmentPacker("merge", smallCandidates, compactTime)
maxSegs := int64(4096) // Deprecate the max segment limit since it is irrelevant in simple compactions.
minSegs := Params.DataCoordCfg.MinSegmentToMerge.GetAsInt64()
compactableProportion := Params.DataCoordCfg.SegmentCompactableProportion.GetAsFloat()
satisfiedSize := int64(float64(expectedSize) * compactableProportion)
maxLeftSize := expectedSize - satisfiedSize
reasons := make([]string, 0)
// 1. Merge small segments if they can make a full bucket
for {
pack, left := toMerge.pack(expectedSize, maxLeftSize, minSegs, maxSegs)
if len(pack) == 0 {
break
}
reasons = append(reasons, fmt.Sprintf("merging %d small segments with left size %d", len(pack), left))
buckets = append(buckets, pack)
}
// 2. Pack prioritized candidates with small segments
// TODO the compaction selection policy should consider if compaction workload is high
for {
// No limit on the remaining size because we want to pack all prioritized candidates
pack, _ := toUpdate.packWith(expectedSize, math.MaxInt64, 0, maxSegs, toMerge)
if len(pack) == 0 {
break
}
reasons = append(reasons, fmt.Sprintf("packing %d prioritized segments", len(pack)))
buckets = append(buckets, pack)
}
// if there is any segment toUpdate left, its size must be greater than expectedSize, add it to the buckets
for _, s := range toUpdate.candidates {
buckets = append(buckets, []*SegmentInfo{s})
reasons = append(reasons, fmt.Sprintf("force packing prioritized segment %d", s.GetID()))
}
// 2.+ legacy: squeeze small segments
// Try merge all small segments, and then squeeze
for {
pack, _ := toMerge.pack(expectedSize, math.MaxInt64, minSegs, maxSegs)
if len(pack) == 0 {
break
}
reasons = append(reasons, fmt.Sprintf("packing all %d small segments", len(pack)))
buckets = append(buckets, pack)
}
smallRemaining := t.squeezeSmallSegmentsToBuckets(toMerge.candidates, buckets, expectedSize)
tasks := make([]*typeutil.Pair[int64, []int64], len(buckets))
for i, b := range buckets {
segmentIDs := make([]int64, 0)
var totalRows int64
for _, s := range b {
totalRows += s.GetNumOfRows()
segmentIDs = append(segmentIDs, s.GetID())
}
pair := typeutil.NewPair(totalRows, segmentIDs)
tasks[i] = &pair
}
if len(tasks) > 0 {
log.Info("generated nontrivial compaction tasks",
zap.Int64("collectionID", signal.collectionID),
zap.Int("prioritizedCandidates", len(prioritizedCandidates)),
zap.Int("smallCandidates", len(smallCandidates)),
zap.Int("nonPlannedSegments", len(nonPlannedSegments)),
zap.Strings("reasons", reasons))
}
if len(smallRemaining) > 0 {
log.RatedInfo(300, "remain small segments",
zap.Int64("collectionID", signal.collectionID),
zap.Int64("partitionID", signal.partitionID),
zap.String("channel", signal.channel),
zap.Int("smallRemainingCount", len(smallRemaining)))
}
return tasks
}
// getCandidates converts signal criterion into corresponding compaction candidate groups
// since non-major compaction happens under channel+partition level
// the selected segments are grouped into these categories.
func (t *compactionTrigger) getCandidates(signal *compactionSignal) ([]chanPartSegments, error) {
// Fail-closed: if any protected snapshot's RefIndex hasn't loaded yet,
// block compaction for the entire collection.
if signal.collectionID > 0 && t.meta.isCollectionCompactionBlocked(signal.collectionID) {
log.Info("skip compaction candidates for collection due to unloaded protected snapshot RefIndex",
zap.Int64("collectionID", signal.collectionID))
return nil, nil
}
// default filter, select segments which could be compacted
filters := []SegmentFilter{
SegmentFilterFunc(func(segment *SegmentInfo) bool {
return isNormalManualCompactionCandidate(t.meta, segment)
}),
}
// add segment filter if criterion provided
if signal.collectionID > 0 {
filters = append(filters, WithCollection(signal.collectionID))
}
if signal.channel != "" {
filters = append(filters, WithChannel(signal.channel))
}
if signal.partitionID > 0 {
filters = append(filters, SegmentFilterFunc(func(si *SegmentInfo) bool {
return si.GetPartitionID() == signal.partitionID
}))
}
// segment id provided
// select these segments only
if len(signal.segmentIDs) > 0 {
idSet := typeutil.NewSet(signal.segmentIDs...)
filters = append(filters, SegmentFilterFunc(func(si *SegmentInfo) bool {
return idSet.Contain(si.GetID())
}))
}
segments := t.meta.SelectSegments(context.TODO(), filters...)
// some criterion not met or conflicted
if len(signal.segmentIDs) > 0 && len(segments) != len(signal.segmentIDs) {
// SelectSegments also filters segments that are transiently mid-flush /
// compacting / just dropped, so a count mismatch is usually server-side
// state, not a bad id from the caller.
return nil, merr.WrapErrServiceInternalMsg("not all segment ids provided could be compacted")
}
type category struct {
collectionID int64
partitionID int64
channelName string
}
groups := lo.GroupBy(segments, func(segment *SegmentInfo) category {
return category{
collectionID: segment.CollectionID,
partitionID: segment.PartitionID,
channelName: segment.InsertChannel,
}
})
return lo.MapToSlice(groups, func(c category, segments []*SegmentInfo) chanPartSegments {
return chanPartSegments{
collectionID: c.collectionID,
partitionID: c.partitionID,
channelName: c.channelName,
segments: segments,
}
}), nil
}
func (t *compactionTrigger) isSmallSegment(segment *SegmentInfo, expectedSize int64) bool {
return segment.getSegmentSize() < int64(float64(expectedSize)*Params.DataCoordCfg.SegmentSmallProportion.GetAsFloat())
}
func (t *compactionTrigger) isCompactableSegment(targetSize, expectedSize int64) bool {
smallProportion := Params.DataCoordCfg.SegmentSmallProportion.GetAsFloat()
compactableProportion := Params.DataCoordCfg.SegmentCompactableProportion.GetAsFloat()
// avoid invalid single segment compaction
if compactableProportion < smallProportion {
compactableProportion = smallProportion
}
return targetSize > int64(float64(expectedSize)*compactableProportion)
}
func isExpandableSmallSegment(segment *SegmentInfo, expectedSize int64) bool {
return segment.getSegmentSize() < int64(float64(expectedSize)*(Params.DataCoordCfg.SegmentExpansionRate.GetAsFloat()-1))
}
func hasTooManyDeletions(segment *SegmentInfo) bool {
deltaLogCount := 0
totalDeletedRows := 0
totalDeleteLogSize := int64(0)
for _, deltaLogs := range segment.GetDeltalogs() {
for _, l := range deltaLogs.GetBinlogs() {
totalDeletedRows += int(l.GetEntriesNum())
totalDeleteLogSize += l.GetMemorySize()
}
deltaLogCount += len(deltaLogs.GetBinlogs())
}
// Too many deltalog files, accumulates IO count.
if deltaLogCount > Params.DataCoordCfg.SingleCompactionDeltalogMaxNum.GetAsInt() {
log.Ctx(context.TODO()).Info("delta logs file count exceeds threshold",
zap.Int64("segmentID", segment.ID),
zap.Int("delta log count", deltaLogCount),
zap.Int("file number threshold", Params.DataCoordCfg.SingleCompactionDeltalogMaxNum.GetAsInt()),
)
return true
}
// The proportion of deleted rows is too large, int64 PK tends to accumulates deleted row counts.
if float64(totalDeletedRows)/float64(segment.GetNumOfRows()) >= Params.DataCoordCfg.SingleCompactionRatioThreshold.GetAsFloat() {
log.Ctx(context.TODO()).Info("deleted entities rows proportion exceeds threshold",
zap.Int64("segmentID", segment.ID),
zap.Int64("number of rows", segment.GetNumOfRows()),
zap.Int("deleted rows", totalDeletedRows),
zap.Float64("proportion threshold", Params.DataCoordCfg.SingleCompactionRatioThreshold.GetAsFloat()),
)
return true
}
// Delete size is too large, varchar PK tends to accumulates deltalog size.
if totalDeleteLogSize > Params.DataCoordCfg.SingleCompactionDeltaLogMaxSize.GetAsInt64() {
log.Ctx(context.TODO()).Info("total delete entries size exceeds threshold",
zap.Int64("segmentID", segment.ID),
zap.Int64("numRows", segment.GetNumOfRows()),
zap.Int64("delete entries size", totalDeleteLogSize),
zap.Int64("size threshold", Params.DataCoordCfg.SingleCompactionDeltaLogMaxSize.GetAsInt64()),
)
return true
}
return false
}
func (t *compactionTrigger) ShouldCompactExpiry(fromTs uint64, compactTime *compactTime, segment *SegmentInfo) bool {
if Params.DataCoordCfg.CompactionExpiryTolerance.GetAsInt() >= 0 {
tolerantDuration := Params.DataCoordCfg.CompactionExpiryTolerance.GetAsDuration(time.Hour)
expireTime, _ := tsoutil.ParseTS(compactTime.expireTime)
earliestTolerance := expireTime.Add(-tolerantDuration)
earliestFromTime, _ := tsoutil.ParseTS(fromTs)
if earliestFromTime.Before(earliestTolerance) {
log.Info("Trigger strict expiry compaction for segment",
zap.Int64("segmentID", segment.GetID()),
zap.Int64("collectionID", segment.GetCollectionID()),
zap.Int64("partition", segment.GetPartitionID()),
zap.String("channel", segment.GetInsertChannel()),
zap.Time("compaction expire time", expireTime),
zap.Time("earliest tolerance", earliestTolerance),
zap.Time("segment earliest from time", earliestFromTime),
)
return true
}
}
return false
}
func getExpirQuantilesIndexByRatio(ratio float64, percentilesLen int) int {
// expirQuantiles is [20%, 40%, 60%, 80%, 100%] (len = 5).
// We map ratio to the nearest lower 20% bucket:
// 0~0.39 -> 20%, 0.4~0.59 -> 40%, 0.6~0.79 -> 60%, 0.8~0.99 -> 80%, >=1.0 -> 100%
if percentilesLen <= 0 {
return 0
}
step := 0.2
idx := int((ratio+0.01)/step) - 1 // add 0.01 to avoid rounding error
if idx < 0 {
idx = 0
}
if idx >= percentilesLen {
idx = percentilesLen - 1
}
return idx
}
func (t *compactionTrigger) ShouldCompactExpiryWithTTLField(compactTime *compactTime, segment *SegmentInfo) bool {
percentiles := segment.GetExpirQuantiles()
if len(percentiles) == 0 {
return false
}
ratio := Params.DataCoordCfg.SingleCompactionRatioThreshold.GetAsFloat()
index := getExpirQuantilesIndexByRatio(ratio, len(percentiles))
expirationTime := percentiles[index]
// If current time (startTime) is greater than the expiration time at this percentile, trigger compaction
startTs := tsoutil.PhysicalTime(compactTime.startTime)
return startTs.UnixMicro() >= expirationTime && expirationTime > 0
}
func (t *compactionTrigger) ShouldDoSingleCompaction(segment *SegmentInfo, compactTime *compactTime) bool {
// no longer restricted binlog numbers because this is now related to field numbers
log := log.Ctx(context.TODO())
// if expire time is enabled, put segment into compaction candidate
totalExpiredSize := int64(0)
totalExpiredRows := 0
var earliestFromTs uint64 = math.MaxUint64
for _, binlogs := range segment.GetBinlogs() {
for _, l := range binlogs.GetBinlogs() {
// TODO, we should probably estimate expired log entries by total rows in binlog and the ralationship of timeTo, timeFrom and expire time
// For import segments, row timestamps predate the commit; use commit_timestamp
// as the effective "data age" to prevent premature TTL-triggered compaction.
if tsoutil.EffectiveTimestamp(l.TimestampTo, segment.GetCommitTimestamp()) < compactTime.expireTime {
log.RatedDebug(10, "mark binlog as expired",
zap.Int64("segmentID", segment.ID),
zap.Int64("binlogID", l.GetLogID()),
zap.Uint64("binlogTimestampTo", l.TimestampTo),
zap.Uint64("compactExpireTime", compactTime.expireTime))
totalExpiredRows += int(l.GetEntriesNum())
totalExpiredSize += l.GetMemorySize()
}
earliestFromTs = min(earliestFromTs, tsoutil.EffectiveTimestamp(l.TimestampFrom, segment.GetCommitTimestamp()))
}
}
if t.ShouldCompactExpiry(earliestFromTs, compactTime, segment) {
return true
}
if float64(totalExpiredRows)/float64(segment.GetNumOfRows()) >= Params.DataCoordCfg.SingleCompactionRatioThreshold.GetAsFloat() ||
totalExpiredSize > Params.DataCoordCfg.SingleCompactionExpiredLogMaxSize.GetAsInt64() {
log.Info("total expired entities is too much, trigger compaction", zap.Int64("segmentID", segment.ID),
zap.Int("expiredRows", totalExpiredRows), zap.Int64("expiredLogSize", totalExpiredSize),
zap.Bool("createdByCompaction", segment.CreatedByCompaction), zap.Int64s("compactionFrom", segment.CompactionFrom))
return true
}
// check if deltalog count, size, and deleted rowcount ratio exceeds threshold
if hasTooManyDeletions(segment) {
return true
}
if t.ShouldRebuildSegmentIndex(segment) {
return true
}
if t.ShouldCompactExpiryWithTTLField(compactTime, segment) {
log.Info("ttl field is expired, trigger compaction", zap.Int64("segmentID", segment.ID),
zap.Int64("collectionID", segment.CollectionID),
zap.Int64("partitionID", segment.PartitionID),
zap.String("channel", segment.InsertChannel))
return true
}
return false
}
func (t *compactionTrigger) ShouldRebuildSegmentIndex(segment *SegmentInfo) bool {
if Params.DataCoordCfg.AutoUpgradeSegmentIndex.GetAsBool() {
// index version of segment lower than current version and IndexFileKeys should have value, trigger compaction
indexIDToSegIdxes := t.meta.indexMeta.GetSegmentIndexes(segment.CollectionID, segment.ID)
for _, index := range indexIDToSegIdxes {
if len(index.IndexFileKeys) == 0 {
continue
}
indexParams := t.meta.indexMeta.GetIndexParams(segment.CollectionID, index.IndexID)
indexType := GetIndexType(indexParams)
isVectorIndex := vecindexmgr.GetVecIndexMgrInstance().IsVecIndex(indexType)
var currentEngineVersion int32
var segmentIndexVersion int32
if isVectorIndex {
currentEngineVersion = t.indexEngineVersionManager.GetCurrentIndexEngineVersion()
segmentIndexVersion = index.CurrentIndexVersion
} else {
currentEngineVersion = t.indexEngineVersionManager.GetCurrentScalarIndexEngineVersion()
segmentIndexVersion = index.CurrentScalarIndexVersion
}
if segmentIndexVersion < currentEngineVersion {
log.Info("index version is too old, trigger compaction",
zap.Int64("segmentID", segment.ID),
zap.Int64("indexID", index.IndexID),
zap.String("indexType", indexType),
zap.Bool("isVectorIndex", isVectorIndex),
zap.Strings("indexFileKeys", index.IndexFileKeys),
zap.Int32("segmentIndexVersion", segmentIndexVersion),
zap.Int32("currentEngineVersion", currentEngineVersion))
return true
}
}
}
// enable force rebuild index with target index version (only for vector index)
if Params.DataCoordCfg.ForceRebuildSegmentIndex.GetAsBool() && Params.DataCoordCfg.TargetVecIndexVersion.GetAsInt64() != -1 {
resolvedVecTarget := t.indexEngineVersionManager.ResolveVecIndexVersion()
indexIDToSegIdxes := t.meta.indexMeta.GetSegmentIndexes(segment.CollectionID, segment.ID)
for _, index := range indexIDToSegIdxes {
if len(index.IndexFileKeys) == 0 {
continue
}
indexParams := t.meta.indexMeta.GetIndexParams(segment.CollectionID, index.IndexID)
indexType := GetIndexType(indexParams)
isVectorIndex := vecindexmgr.GetVecIndexMgrInstance().IsVecIndex(indexType)
// ForceRebuildSegmentIndex with TargetVecIndexVersion only applies to vector indexes
if !isVectorIndex {
continue
}
if index.CurrentIndexVersion != resolvedVecTarget {
log.Info("index version is not equal to target vec index version, trigger compaction",
zap.Int64("segmentID", segment.ID),
zap.Int64("indexID", index.IndexID),
zap.String("indexType", indexType),
zap.Strings("indexFileKeys", index.IndexFileKeys),
zap.Int32("currentIndexVersion", index.CurrentIndexVersion),
zap.Int32("resolvedTargetVersion", resolvedVecTarget))
return true
}
}
}
// enable force rebuild scalar index with target scalar index version
if Params.DataCoordCfg.ForceRebuildScalarSegmentIndex.GetAsBool() && Params.DataCoordCfg.TargetScalarIndexVersion.GetAsInt64() != -1 {
resolvedScalarTarget := t.indexEngineVersionManager.ResolveScalarIndexVersion()
indexIDToSegIdxes := t.meta.indexMeta.GetSegmentIndexes(segment.CollectionID, segment.ID)
for _, index := range indexIDToSegIdxes {
if len(index.IndexFileKeys) == 0 {
continue
}
indexParams := t.meta.indexMeta.GetIndexParams(segment.CollectionID, index.IndexID)
indexType := GetIndexType(indexParams)
isVectorIndex := vecindexmgr.GetVecIndexMgrInstance().IsVecIndex(indexType)
if isVectorIndex {
continue
}
if index.CurrentScalarIndexVersion != resolvedScalarTarget {
log.Info("scalar index version != target, trigger compaction",
zap.Int64("segmentID", segment.ID),
zap.Int64("indexID", index.IndexID),
zap.String("indexType", indexType),
zap.Int32("currentScalarIndexVersion", index.CurrentScalarIndexVersion),
zap.Int32("resolvedTargetVersion", resolvedScalarTarget))
return true
}
}
}
return false
}
func isFlushed(segment *SegmentInfo) bool {
return segment.GetState() == commonpb.SegmentState_Flushed
}
func isFlush(segment *SegmentInfo) bool {
return segment.GetState() == commonpb.SegmentState_Flushed || segment.GetState() == commonpb.SegmentState_Flushing
}
// buckets will be updated inplace
func (t *compactionTrigger) squeezeSmallSegmentsToBuckets(small []*SegmentInfo, buckets [][]*SegmentInfo, expectedSize int64) (remaining []*SegmentInfo) {
for i := len(small) - 1; i >= 0; i-- {
s := small[i]
if !isExpandableSmallSegment(s, expectedSize) {
continue
}
// Try squeeze this segment into existing plans. This could cause segment size to exceed maxSize.
for bidx, b := range buckets {
totalSize := lo.SumBy(b, func(s *SegmentInfo) int64 { return s.getSegmentSize() })
if totalSize+s.getSegmentSize() > int64(Params.DataCoordCfg.SegmentExpansionRate.GetAsFloat()*float64(expectedSize)) {
continue
}
buckets[bidx] = append(buckets[bidx], s)
small = append(small[:i], small[i+1:]...)
break
}
}
return small
}
func canTriggerSortCompaction(segment *SegmentInfo) bool {
return segment.GetState() == commonpb.SegmentState_Flushed &&
segment.GetLevel() != datapb.SegmentLevel_L0 &&
(!segment.GetIsSorted() && !segment.GetIsSortedByNamespace()) &&
!segment.GetIsImporting() &&
!segment.isCompacting
}