mirror of
https://github.com/milvus-io/milvus.git
synced 2026-07-21 10:15:43 +00:00
issue: #47420 ## What this PR does Project-wide migration of raw `fmt.Errorf` / `errors.New` in function bodies onto the `merr` framework, plus the Sys-vs-Input error classification and the machinery it drives (retriability, fine-grained metrics, segcore unification), plus the convention docs and a linter that keeps it from regressing. Scope: storage, proxy, coordinators (root/data/query), query node, data node, `pkg/util` & `internal/util`, expression parser, message queue, streaming, and misc packages. Bare raw-error usages went from ~3000 to a ~340 allowlist (package-level sentinels / build-tag / test sites). --- ## How to review this PR It is large but the vast majority is mechanical. Changes fall into three tiers; spend review budget on Part 2 and Part 3. ### Part 1 — Mechanical standardization (low risk, verify by rule) Each converted call follows one of a small fixed set of rules. To review, check that each site obeys the matching rule rather than reading every line: | Pattern | Rule | |---|---| | `fmt.Errorf("...")` originating a new error | → `merr.WrapErrXxxMsg("...")` with a code matching the failure's meaning | | Adding context to an existing typed error | → `merr.Wrap(err, "...")` / `merr.Wrapf(...)` — **preserves** the inner code (never `WrapErr*Err`, which overwrites it) | | Errors inside the streaming subsystem | → `status.New*` factories (StreamingError), **not** merr — this is the component-internal dialect (see `docs/dev/error_handling_guide.md`) | | Low-level / control-flow signal caught by `errors.Is` | → kept as a package-level `errors.New` sentinel (lowercase, same-package) | Conventions are documented in `docs/dev/error_handling_guide.md` (how-to) and `docs/dev/error_sentinel_convention.md` (rules + audit). A `gocritic`/`ruleguard` rule (`rawmerrerror`, in `rules.go`) enforces "no raw `return errors.New/fmt.Errorf`" under `make verifiers`. ### Part 2 — Behavior changes (review these closely) These are the sites where the wire contract or runtime behavior changes, not just the source text. Listed by category; representative locations given, full set in the diff. **A. gRPC wire-code shifts: `UnexpectedError(1)/Code 65535` → typed code.** Where a handler previously returned a raw error (collapsed to `Code=65535` on the wire), it now returns a typed merr, so the client sees a real code. The most common shift is to `IllegalArgument(5)/Code 1100` (ParameterInvalid). Touch points include datanode task handlers (CreateTask/Query/Drop), proxy Upsert, querynode GetMetrics, datacoord CreateIndex, httpserver query-response builder, and typeutil schema validation. One code refinement: an index-param validation moved `1100` → `1101` (ParameterMissing). **Client/SDK assertions and any code that switched on `Code=65535` for these paths must be re-checked** (the go_client e2e assertions were already aligned in this PR). **B. Prometheus `status` label contract change (externally visible).** The proxy metric's coarse `fail` / `rejected` values are split into `fail_input` / `fail_system` and `rejected_user` / `rejected_system` (in `requestutil.ParseMetricLabel`; auth/privilege rejections count as `rejected_user`), so dashboards can attribute a failure to caller vs operator. **Dashboards/alerts querying `status="fail"` must migrate to `status=~"fail_.*"`, and `status="rejected"` to `status=~"rejected_.*"`.** The in-repo Grafana dashboard is already migrated; external dashboards built on the old values silently go empty after upgrade. This is the one change that requires an ops-side migration. **C. Retriability semantics.** - C1: `merr.Status(err)` now forces `Retriable=false` when the error is an `InputError` — a malformed request can never succeed on blind retry, so clients never get the self-contradictory "your input is wrong but you may retry". - C2: `retry.Do` short-circuits an `InputError` (non-retriable) — **but only when the caller did not pass a `RetryErr` predicate**. The check is an `if c.isRetryErr != nil { ... } else if InputError { ... }` *mutually exclusive* branch (`pkg/util/retry/retry.go`): an explicit `RetryErr` takes precedence and bypasses the InputError abort. `retry.Handle` deliberately does **not** apply the InputError abort (its callers signal abort via `shouldRetry=false`). Four flusher startup callsites that must retry through transient "not ready" errors were given explicit `RetryErr` escape hatches. **D. segcore (C++→Go) error classification.** A single shared Go-side table (`pkg/util/merr/segcore.go`) maps each segcore code to a merr sentinel + InputError/signal category, replacing scattered hand-written `if errorCode == ...` switches in the cgo wrappers. **Wire `Code` values change for every segcore pass-through error, not just the remapped ones.** Named sentinels remap (C++ `2003` → merr `2001`, `2033` → `2002`, Folly/Knowhere codes likewise); **all remaining pass-through codes (`2004`–`2043`, previously surfaced to clients as raw C++ enum values) now serialize as `2000`** (`ErrSegcore`), with the original C++ code preserved in the `Reason` text (`segcoreCode=...`); unknown/future codes collapse to `2000` as well (pinned by the `wire_code_projection` test). Transient segcore classes (object storage / file IO / OOM / mmap / FieldNotLoaded — 11 codes) now report `Retriable=true`. **Any client switching on raw segcore codes in the `2004`–`2043` range must be re-checked**; the in-Reason code remains available for diagnostics. Signal codes (PretendFinished / FollyCancel) are recognized centrally. `errors.Is`-based control flow on these (e.g. scheduler skip/retry) is preserved. **E. InputError classification (25 sentinels + dynamic marks).** 25 sentinels in `errors.go` carry `WithErrorType(InputError)` (the Collection / ResourceGroup / Database families, `ErrIndexDuplicate`, `ErrParameterInvalid`, `ErrPrivilegeNotAuthenticated`, `ErrImportFailed`, `ErrQueryPlan`, ...), plus dynamic marks for the 8 segcore input codes (ExprInvalid, DimNotMatch, MetricTypeInvalid, FieldIDInvalid, ...) and `WrapErrAsInputError`. The widest blast radius is `ErrParameterInvalid` (1100): ~2335 `WrapErrParameterInvalid*` callsites now classify as input / non-retriable. Because of C1/C2 this changes retriability for any path that returns these. **The audit to confirm no transient path was mis-marked is the single most important review item** (see Part 3). One reverse correction: storage field-stats parsing moved from `ErrParameterInvalid` (input) to `ErrDataIntegrity` — a corrupted stored stat is data corruption, not user input. ### Part 3 — Known risks & traps (called out proactively) 1. **`merr.Wrap` vs `WrapErr*Err` (code-masking).** `WrapErr*Err` builds a `wrappedMilvusError{sentinel: ErrServiceInternal}` whose `code()` returns the *outer* sentinel — it overwrites the inner typed code and hides the `errors.Is` chain. This is intentional (use it to *deliberately* downgrade), but it was a recurring conversion defect; the rule "add context with `merr.Wrap`, downgrade with `WrapErr*Err`" is enforced by convention and reviewed across the diff. 2. **InputError × `retry.Do` blast radius.** Marking a sentinel `InputError` makes any `retry.Do(...)` without a `RetryErr` predicate stop retrying it. Reviewers should sanity-check that no transient use of the 19 newly-marked sentinels (especially `ErrParameterInvalid`) sits inside a retry loop that needed to keep spinning. The known flusher cases were handled (see C2). 3. **The ~340 raw-error allowlist.** What remains as bare `errors.New` is, by design: package-level sentinels (caught by `errors.Is`), `//go:build test` sites, and out-of-band trees (`cmd/`, `tests/`, codegen, walimpls). The linter only bans the *direct-return* form; assignment-then-return escapes and the full no-exceptions ban are deferred to an AST-based linter (Tier 2, documented). 4. **segcore C++ second step deferred.** This PR unifies classification on the Go side; splitting the dual-semantic C++ codes at the source is a follow-up. --- ## Validation - `make verifiers`: Go side clean (gofmt + static-check across modules, including the new `rawmerrerror` rule with a 0-hit baseline repo-wide). - `make test-go`: passing; the one real regression introduced (a datanode `invalid_task_type` assertion shifting `1` → `5` from a ParameterInvalid conversion) was fixed in-tree. - go_client e2e CreateIndex assertions aligned to the new merr messages. --------- Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
518 lines
17 KiB
Go
518 lines
17 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package compactor
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"sort"
|
|
"strconv"
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/samber/lo"
|
|
"go.opentelemetry.io/otel"
|
|
"go.uber.org/zap"
|
|
"golang.org/x/sync/errgroup"
|
|
"google.golang.org/protobuf/proto"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v3/commonpb"
|
|
"github.com/milvus-io/milvus-proto/go-api/v3/schemapb"
|
|
"github.com/milvus-io/milvus/internal/allocator"
|
|
"github.com/milvus-io/milvus/internal/compaction"
|
|
"github.com/milvus-io/milvus/internal/datanode/util"
|
|
"github.com/milvus-io/milvus/internal/metastore/kv/binlog"
|
|
"github.com/milvus-io/milvus/internal/storage"
|
|
"github.com/milvus-io/milvus/internal/storagev2/packed"
|
|
"github.com/milvus-io/milvus/internal/util/analyzer"
|
|
"github.com/milvus-io/milvus/internal/util/fileresource"
|
|
"github.com/milvus-io/milvus/internal/util/indexcgowrapper"
|
|
"github.com/milvus-io/milvus/pkg/v3/common"
|
|
"github.com/milvus-io/milvus/pkg/v3/log"
|
|
"github.com/milvus-io/milvus/pkg/v3/proto/datapb"
|
|
"github.com/milvus-io/milvus/pkg/v3/proto/indexcgopb"
|
|
"github.com/milvus-io/milvus/pkg/v3/proto/indexpb"
|
|
"github.com/milvus-io/milvus/pkg/v3/util/merr"
|
|
"github.com/milvus-io/milvus/pkg/v3/util/metautil"
|
|
"github.com/milvus-io/milvus/pkg/v3/util/tsoutil"
|
|
"github.com/milvus-io/milvus/pkg/v3/util/typeutil"
|
|
)
|
|
|
|
const compactionBatchSize = 100
|
|
|
|
func createTextIndex(ctx context.Context,
|
|
cm storage.ChunkManager,
|
|
plan *datapb.CompactionPlan,
|
|
compactionParams compaction.Params,
|
|
storageVersion int64,
|
|
collectionID int64,
|
|
partitionID int64,
|
|
segmentID int64,
|
|
taskID int64,
|
|
segment *datapb.CompactionSegment,
|
|
) (map[int64]*datapb.TextIndexStats, error) {
|
|
log := log.Ctx(ctx).With(
|
|
zap.Int64("collectionID", collectionID),
|
|
zap.Int64("partitionID", partitionID),
|
|
zap.Int64("segmentID", segmentID),
|
|
)
|
|
|
|
fieldBinlogs := lo.GroupBy(segment.GetInsertLogs(), func(binlog *datapb.FieldBinlog) int64 {
|
|
return binlog.GetFieldID()
|
|
})
|
|
|
|
getInsertFiles := func(fieldID int64) ([]string, error) {
|
|
if storageVersion == storage.StorageV2 || storageVersion == storage.StorageV3 {
|
|
return []string{}, nil
|
|
}
|
|
binlogs, ok := fieldBinlogs[fieldID]
|
|
if !ok {
|
|
return nil, merr.WrapErrParameterInvalidMsg("field binlog not found for field %d", fieldID)
|
|
}
|
|
result := make([]string, 0, len(binlogs))
|
|
for _, binlog := range binlogs {
|
|
for _, file := range binlog.GetBinlogs() {
|
|
result = append(result, metautil.BuildInsertLogPath(compactionParams.StorageConfig.GetRootPath(),
|
|
collectionID, partitionID, segmentID, fieldID, file.GetLogID()))
|
|
}
|
|
}
|
|
return result, nil
|
|
}
|
|
|
|
newStorageConfig, err := util.ParseStorageConfig(compactionParams.StorageConfig)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
var (
|
|
mu sync.Mutex
|
|
textIndexLogs = make(map[int64]*datapb.TextIndexStats)
|
|
)
|
|
|
|
eg, egCtx := errgroup.WithContext(ctx)
|
|
|
|
var analyzerExtraInfo string
|
|
if len(plan.GetFileResources()) > 0 {
|
|
err := fileresource.GlobalFileManager.Download(ctx, cm, plan.GetFileResources()...)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
defer fileresource.GlobalFileManager.Release(plan.GetFileResources()...)
|
|
analyzerExtraInfo, err = analyzer.BuildExtraResourceInfo(compactionParams.StorageConfig.GetRootPath(), plan.GetFileResources())
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
|
|
for _, field := range plan.GetSchema().GetFields() {
|
|
field := field
|
|
h := typeutil.CreateFieldSchemaHelper(field)
|
|
if !h.EnableMatch() {
|
|
continue
|
|
}
|
|
log.Info("field enable match, ready to create text index", zap.Int64("field id", field.GetFieldID()))
|
|
|
|
eg.Go(func() error {
|
|
files, err := getInsertFiles(field.GetFieldID())
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
statsBasePath := metautil.BuildTextIndexPrefix(compactionParams.StorageConfig.GetRootPath(),
|
|
plan.GetPlanID(), 0, collectionID, partitionID, segmentID, field.GetFieldID())
|
|
if segment.GetManifest() != "" {
|
|
basePath, _, err := packed.UnmarshalManifestPath(segment.GetManifest())
|
|
if err != nil {
|
|
return merr.Wrap(err, "failed to unmarshal manifest path for text_index basePath")
|
|
}
|
|
statsBasePath = fmt.Sprintf("%s/_stats/text_index.%d", basePath, field.GetFieldID())
|
|
}
|
|
|
|
buildIndexParams := &indexcgopb.BuildIndexInfo{
|
|
BuildID: taskID,
|
|
CollectionID: collectionID,
|
|
PartitionID: partitionID,
|
|
SegmentID: segmentID,
|
|
IndexVersion: 0,
|
|
InsertFiles: files,
|
|
FieldSchema: field,
|
|
StorageConfig: newStorageConfig,
|
|
CurrentScalarIndexVersion: common.ClampScalarIndexVersion(plan.GetCurrentScalarIndexVersion()),
|
|
StorageVersion: storageVersion,
|
|
Manifest: segment.GetManifest(),
|
|
StatsBasePath: statsBasePath,
|
|
IndexParams: []*commonpb.KeyValuePair{
|
|
{Key: "index_type", Value: "INVERTED"},
|
|
{Key: "is_text_match", Value: "true"},
|
|
},
|
|
}
|
|
|
|
if len(analyzerExtraInfo) > 0 {
|
|
buildIndexParams.AnalyzerExtraInfo = analyzerExtraInfo
|
|
}
|
|
|
|
if storageVersion == storage.StorageV2 || storageVersion == storage.StorageV3 {
|
|
buildIndexParams.SegmentInsertFiles = util.GetSegmentInsertFiles(
|
|
segment.GetInsertLogs(),
|
|
compactionParams.StorageConfig,
|
|
collectionID,
|
|
partitionID,
|
|
segmentID)
|
|
}
|
|
|
|
index, err := indexcgowrapper.CreateIndex(egCtx, buildIndexParams)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer index.Delete()
|
|
|
|
indexStats, err := index.UpLoad()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
uploaded := make(map[string]int64)
|
|
for _, info := range indexStats.GetSerializedIndexInfos() {
|
|
uploaded[info.FileName] = info.FileSize
|
|
}
|
|
|
|
statsFiles := metautil.BuildStatsFilePaths(statsBasePath, lo.Keys(uploaded))
|
|
|
|
mu.Lock()
|
|
totalSize := lo.SumBy(lo.Values(uploaded), func(fileSize int64) int64 { return fileSize })
|
|
textIndexLogs[field.GetFieldID()] = &datapb.TextIndexStats{
|
|
FieldID: field.GetFieldID(),
|
|
Version: 0,
|
|
BuildID: taskID,
|
|
Files: statsFiles,
|
|
LogSize: totalSize,
|
|
MemorySize: totalSize,
|
|
CurrentScalarIndexVersion: common.ClampScalarIndexVersion(plan.GetCurrentScalarIndexVersion()),
|
|
}
|
|
mu.Unlock()
|
|
|
|
log.Info("field enable match, create text index done",
|
|
zap.Int64("segmentID", segmentID),
|
|
zap.Int64("field id", field.GetFieldID()),
|
|
zap.Strings("files", statsFiles),
|
|
)
|
|
return nil
|
|
})
|
|
}
|
|
|
|
if err := eg.Wait(); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return textIndexLogs, nil
|
|
}
|
|
|
|
// Storage readers do not share compaction's schema-reconciliation contract, so filter physical fields before opening them.
|
|
func newCompactionSegmentRecordReader(ctx context.Context, segment *datapb.CompactionSegmentBinlogs, schema *schemapb.CollectionSchema, storageConfig *indexpb.StorageConfig, opts ...storage.RwOption) (storage.RecordReader, map[int64]struct{}, error) {
|
|
existingFields, err := compactionSegmentStorageFields(segment, storageConfig)
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
return newCompactionSegmentRecordReaderWithFields(ctx, segment, schema, storageConfig, existingFields, opts...)
|
|
}
|
|
|
|
func compactionSegmentStorageFields(segment *datapb.CompactionSegmentBinlogs, storageConfig *indexpb.StorageConfig) (map[int64]struct{}, error) {
|
|
if segment.GetManifest() != "" {
|
|
return packed.GetManifestFieldIDs(segment.GetManifest(), storageConfig)
|
|
}
|
|
return compactionSegmentBinlogFields(segment), nil
|
|
}
|
|
|
|
func compactionSegmentBinlogFields(segment *datapb.CompactionSegmentBinlogs) map[int64]struct{} {
|
|
fields := make(map[int64]struct{})
|
|
for _, fieldBinlog := range segment.GetFieldBinlogs() {
|
|
if len(fieldBinlog.GetChildFields()) == 0 {
|
|
fields[fieldBinlog.GetFieldID()] = struct{}{}
|
|
continue
|
|
}
|
|
for _, childFieldID := range fieldBinlog.GetChildFields() {
|
|
fields[childFieldID] = struct{}{}
|
|
}
|
|
}
|
|
return fields
|
|
}
|
|
|
|
func collectionSchemaFields(schema *schemapb.CollectionSchema) map[int64]struct{} {
|
|
fields := make(map[int64]struct{}, typeutil.GetTotalFieldsNum(schema))
|
|
for _, field := range typeutil.GetAllFieldSchemas(schema) {
|
|
fields[field.GetFieldID()] = struct{}{}
|
|
}
|
|
return fields
|
|
}
|
|
|
|
func missingSchemaFunctions(schema *schemapb.CollectionSchema, existingFields map[int64]struct{}) []*schemapb.FunctionSchema {
|
|
var missing []*schemapb.FunctionSchema
|
|
for _, functionSchema := range schema.GetFunctions() {
|
|
for _, outputFieldID := range functionSchema.GetOutputFieldIds() {
|
|
if _, ok := existingFields[outputFieldID]; !ok {
|
|
missing = append(missing, functionSchema)
|
|
break
|
|
}
|
|
}
|
|
}
|
|
return missing
|
|
}
|
|
|
|
func droppedSchemaFieldIDs(schema *schemapb.CollectionSchema, existingFields map[int64]struct{}) []int64 {
|
|
targetFields := collectionSchemaFields(schema)
|
|
dropped := make([]int64, 0)
|
|
for fieldID := range existingFields {
|
|
if fieldID < common.StartOfUserFieldID {
|
|
continue
|
|
}
|
|
if _, ok := targetFields[fieldID]; !ok {
|
|
dropped = append(dropped, fieldID)
|
|
}
|
|
}
|
|
sort.Slice(dropped, func(i, j int) bool { return dropped[i] < dropped[j] })
|
|
return dropped
|
|
}
|
|
|
|
func segmentDroppedFieldIDs(schema *schemapb.CollectionSchema, segment *datapb.CompactionSegmentBinlogs, storageConfig *indexpb.StorageConfig) ([]int64, error) {
|
|
existingFields, err := compactionSegmentStorageFields(segment, storageConfig)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return droppedSchemaFieldIDs(schema, existingFields), nil
|
|
}
|
|
|
|
func newCompactionSegmentRecordReaderWithFields(ctx context.Context, segment *datapb.CompactionSegmentBinlogs, schema *schemapb.CollectionSchema, storageConfig *indexpb.StorageConfig, existingFields map[int64]struct{}, opts ...storage.RwOption) (storage.RecordReader, map[int64]struct{}, error) {
|
|
readSchema := compactionReadSchema(schema, existingFields)
|
|
|
|
if segment.GetManifest() != "" {
|
|
reader, err := storage.NewManifestRecordReader(ctx, segment.GetManifest(), readSchema, opts...)
|
|
return reader, existingFields, err
|
|
}
|
|
|
|
readFields := collectionSchemaFields(readSchema)
|
|
fieldBinlogs := filterCompactionFieldBinlogs(segment.GetFieldBinlogs(), readFields)
|
|
rootPath := ""
|
|
if storageConfig != nil {
|
|
rootPath = storageConfig.GetRootPath()
|
|
}
|
|
if err := binlog.DecompressBinLogWithRootPath(rootPath, storage.InsertBinlog,
|
|
segment.GetCollectionID(), segment.GetPartitionID(), segment.GetSegmentID(), fieldBinlogs); err != nil {
|
|
return nil, nil, err
|
|
}
|
|
|
|
reader, err := storage.NewBinlogRecordReader(ctx, fieldBinlogs, readSchema, opts...)
|
|
return reader, existingFields, err
|
|
}
|
|
|
|
func compactionReadSchema(schema *schemapb.CollectionSchema, existingFields map[int64]struct{}) *schemapb.CollectionSchema {
|
|
if schema == nil {
|
|
return nil
|
|
}
|
|
readSchema := proto.Clone(schema).(*schemapb.CollectionSchema)
|
|
|
|
fields := make([]*schemapb.FieldSchema, 0, len(readSchema.GetFields()))
|
|
for _, field := range readSchema.GetFields() {
|
|
if compactionFieldReadable(field, existingFields) {
|
|
fields = append(fields, field)
|
|
}
|
|
}
|
|
readSchema.Fields = fields
|
|
|
|
structFields := make([]*schemapb.StructArrayFieldSchema, 0, len(readSchema.GetStructArrayFields()))
|
|
for _, structField := range readSchema.GetStructArrayFields() {
|
|
childFields := make([]*schemapb.FieldSchema, 0, len(structField.GetFields()))
|
|
for _, field := range structField.GetFields() {
|
|
if compactionFieldReadable(field, existingFields) {
|
|
childFields = append(childFields, field)
|
|
}
|
|
}
|
|
if len(childFields) > 0 {
|
|
structField.Fields = childFields
|
|
structFields = append(structFields, structField)
|
|
}
|
|
}
|
|
readSchema.StructArrayFields = structFields
|
|
return readSchema
|
|
}
|
|
|
|
func compactionFieldReadable(field *schemapb.FieldSchema, existingFields map[int64]struct{}) bool {
|
|
_, ok := existingFields[field.GetFieldID()]
|
|
return ok
|
|
}
|
|
|
|
func filterCompactionFieldBinlogs(fieldBinlogs []*datapb.FieldBinlog, readFields map[int64]struct{}) []*datapb.FieldBinlog {
|
|
filtered := make([]*datapb.FieldBinlog, 0, len(fieldBinlogs))
|
|
for _, fieldBinlog := range fieldBinlogs {
|
|
if compactionFieldBinlogReadable(fieldBinlog, readFields) {
|
|
filtered = append(filtered, fieldBinlog)
|
|
}
|
|
}
|
|
return filtered
|
|
}
|
|
|
|
func compactionFieldBinlogReadable(fieldBinlog *datapb.FieldBinlog, readFields map[int64]struct{}) bool {
|
|
if fieldBinlog == nil {
|
|
return false
|
|
}
|
|
if _, ok := readFields[fieldBinlog.GetFieldID()]; ok {
|
|
return true
|
|
}
|
|
for _, childFieldID := range fieldBinlog.GetChildFields() {
|
|
if _, ok := readFields[childFieldID]; ok {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
type EntityFilter struct {
|
|
deletedPkTs map[interface{}]typeutil.Timestamp // pk2ts
|
|
ttl int64 // nanoseconds
|
|
currentTime time.Time
|
|
|
|
expiredCount int
|
|
deletedCount int
|
|
}
|
|
|
|
func newEntityFilter(deletedPkTs map[interface{}]typeutil.Timestamp, ttl int64, currTime time.Time) *EntityFilter {
|
|
if deletedPkTs == nil {
|
|
deletedPkTs = make(map[interface{}]typeutil.Timestamp)
|
|
}
|
|
return &EntityFilter{
|
|
deletedPkTs: deletedPkTs,
|
|
ttl: ttl,
|
|
currentTime: currTime,
|
|
}
|
|
}
|
|
|
|
func (filter *EntityFilter) Filtered(pk any, ts typeutil.Timestamp) bool {
|
|
if filter.isEntityDeleted(pk, ts) {
|
|
filter.deletedCount++
|
|
return true
|
|
}
|
|
|
|
// Filtering expired entity
|
|
if filter.isEntityExpired(ts) {
|
|
filter.expiredCount++
|
|
return true
|
|
}
|
|
return false
|
|
}
|
|
|
|
func (filter *EntityFilter) GetExpiredCount() int {
|
|
return filter.expiredCount
|
|
}
|
|
|
|
func (filter *EntityFilter) GetDeletedCount() int {
|
|
return filter.deletedCount
|
|
}
|
|
|
|
func (filter *EntityFilter) GetDeltalogDeleteCount() int {
|
|
return len(filter.deletedPkTs)
|
|
}
|
|
|
|
func (filter *EntityFilter) GetMissingDeleteCount() int {
|
|
diff := filter.GetDeltalogDeleteCount() - filter.GetDeletedCount()
|
|
if diff <= 0 {
|
|
diff = 0
|
|
}
|
|
return diff
|
|
}
|
|
|
|
func (filter *EntityFilter) isEntityDeleted(pk interface{}, pkTs typeutil.Timestamp) bool {
|
|
if deleteTs, ok := filter.deletedPkTs[pk]; ok {
|
|
// insert task and delete task has the same ts when upsert
|
|
// here should be < instead of <=
|
|
// to avoid the upsert data to be deleted after compact
|
|
if pkTs < deleteTs {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
func (filter *EntityFilter) isEntityExpired(entityTs typeutil.Timestamp) bool {
|
|
// entity expire is not enabled if duration <= 0
|
|
if filter.ttl <= 0 {
|
|
return false
|
|
}
|
|
entityTime, _ := tsoutil.ParseTS(entityTs)
|
|
|
|
// this dur can represents 292 million years before or after 1970, enough for milvus
|
|
// ttl calculation
|
|
dur := filter.currentTime.UnixMilli() - entityTime.UnixMilli()
|
|
|
|
// filter.ttl is nanoseconds
|
|
return filter.ttl/int64(time.Millisecond) <= dur
|
|
}
|
|
|
|
// TODO: remove, used in test only
|
|
func serializeWrite(ctx context.Context, allocator allocator.Interface, writer *SegmentWriter) (kvs map[string][]byte, fieldBinlogs map[int64]*datapb.FieldBinlog, err error) {
|
|
_, span := otel.Tracer(typeutil.DataNodeRole).Start(ctx, "serializeWrite")
|
|
defer span.End()
|
|
|
|
blobs, tr, err := writer.SerializeYield()
|
|
startID, _, err := allocator.Alloc(uint32(len(blobs)))
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
|
|
kvs = make(map[string][]byte)
|
|
fieldBinlogs = make(map[int64]*datapb.FieldBinlog)
|
|
for i := range blobs {
|
|
// Blob Key is generated by Serialize from int64 fieldID in collection schema, which won't raise error in ParseInt
|
|
fID, _ := strconv.ParseInt(blobs[i].GetKey(), 10, 64)
|
|
key, _ := binlog.BuildLogPath(storage.InsertBinlog, writer.GetCollectionID(), writer.GetPartitionID(), writer.GetSegmentID(), fID, startID+int64(i))
|
|
|
|
kvs[key] = blobs[i].GetValue()
|
|
fieldBinlogs[fID] = &datapb.FieldBinlog{
|
|
FieldID: fID,
|
|
Binlogs: []*datapb.Binlog{
|
|
{
|
|
LogSize: int64(len(blobs[i].GetValue())),
|
|
MemorySize: blobs[i].GetMemorySize(),
|
|
LogPath: key,
|
|
EntriesNum: blobs[i].RowNum,
|
|
TimestampFrom: tr.GetMinTimestamp(),
|
|
TimestampTo: tr.GetMaxTimestamp(),
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
return
|
|
}
|
|
|
|
func getTTLFieldID(schema *schemapb.CollectionSchema) int64 {
|
|
ttlFieldName := ""
|
|
for _, pair := range schema.GetProperties() {
|
|
if pair.GetKey() == common.CollectionTTLFieldKey {
|
|
ttlFieldName = pair.GetValue()
|
|
break
|
|
}
|
|
}
|
|
if ttlFieldName == "" {
|
|
return -1
|
|
}
|
|
for _, field := range schema.GetFields() {
|
|
if field.GetName() == ttlFieldName && field.GetDataType() == schemapb.DataType_Timestamptz {
|
|
return field.GetFieldID()
|
|
}
|
|
}
|
|
return -1
|
|
}
|