mirror of
https://github.com/milvus-io/milvus.git
synced 2026-07-21 02:05:41 +00:00
issue: #47420 ## What this PR does Project-wide migration of raw `fmt.Errorf` / `errors.New` in function bodies onto the `merr` framework, plus the Sys-vs-Input error classification and the machinery it drives (retriability, fine-grained metrics, segcore unification), plus the convention docs and a linter that keeps it from regressing. Scope: storage, proxy, coordinators (root/data/query), query node, data node, `pkg/util` & `internal/util`, expression parser, message queue, streaming, and misc packages. Bare raw-error usages went from ~3000 to a ~340 allowlist (package-level sentinels / build-tag / test sites). --- ## How to review this PR It is large but the vast majority is mechanical. Changes fall into three tiers; spend review budget on Part 2 and Part 3. ### Part 1 — Mechanical standardization (low risk, verify by rule) Each converted call follows one of a small fixed set of rules. To review, check that each site obeys the matching rule rather than reading every line: | Pattern | Rule | |---|---| | `fmt.Errorf("...")` originating a new error | → `merr.WrapErrXxxMsg("...")` with a code matching the failure's meaning | | Adding context to an existing typed error | → `merr.Wrap(err, "...")` / `merr.Wrapf(...)` — **preserves** the inner code (never `WrapErr*Err`, which overwrites it) | | Errors inside the streaming subsystem | → `status.New*` factories (StreamingError), **not** merr — this is the component-internal dialect (see `docs/dev/error_handling_guide.md`) | | Low-level / control-flow signal caught by `errors.Is` | → kept as a package-level `errors.New` sentinel (lowercase, same-package) | Conventions are documented in `docs/dev/error_handling_guide.md` (how-to) and `docs/dev/error_sentinel_convention.md` (rules + audit). A `gocritic`/`ruleguard` rule (`rawmerrerror`, in `rules.go`) enforces "no raw `return errors.New/fmt.Errorf`" under `make verifiers`. ### Part 2 — Behavior changes (review these closely) These are the sites where the wire contract or runtime behavior changes, not just the source text. Listed by category; representative locations given, full set in the diff. **A. gRPC wire-code shifts: `UnexpectedError(1)/Code 65535` → typed code.** Where a handler previously returned a raw error (collapsed to `Code=65535` on the wire), it now returns a typed merr, so the client sees a real code. The most common shift is to `IllegalArgument(5)/Code 1100` (ParameterInvalid). Touch points include datanode task handlers (CreateTask/Query/Drop), proxy Upsert, querynode GetMetrics, datacoord CreateIndex, httpserver query-response builder, and typeutil schema validation. One code refinement: an index-param validation moved `1100` → `1101` (ParameterMissing). **Client/SDK assertions and any code that switched on `Code=65535` for these paths must be re-checked** (the go_client e2e assertions were already aligned in this PR). **B. Prometheus `status` label contract change (externally visible).** The proxy metric's coarse `fail` / `rejected` values are split into `fail_input` / `fail_system` and `rejected_user` / `rejected_system` (in `requestutil.ParseMetricLabel`; auth/privilege rejections count as `rejected_user`), so dashboards can attribute a failure to caller vs operator. **Dashboards/alerts querying `status="fail"` must migrate to `status=~"fail_.*"`, and `status="rejected"` to `status=~"rejected_.*"`.** The in-repo Grafana dashboard is already migrated; external dashboards built on the old values silently go empty after upgrade. This is the one change that requires an ops-side migration. **C. Retriability semantics.** - C1: `merr.Status(err)` now forces `Retriable=false` when the error is an `InputError` — a malformed request can never succeed on blind retry, so clients never get the self-contradictory "your input is wrong but you may retry". - C2: `retry.Do` short-circuits an `InputError` (non-retriable) — **but only when the caller did not pass a `RetryErr` predicate**. The check is an `if c.isRetryErr != nil { ... } else if InputError { ... }` *mutually exclusive* branch (`pkg/util/retry/retry.go`): an explicit `RetryErr` takes precedence and bypasses the InputError abort. `retry.Handle` deliberately does **not** apply the InputError abort (its callers signal abort via `shouldRetry=false`). Four flusher startup callsites that must retry through transient "not ready" errors were given explicit `RetryErr` escape hatches. **D. segcore (C++→Go) error classification.** A single shared Go-side table (`pkg/util/merr/segcore.go`) maps each segcore code to a merr sentinel + InputError/signal category, replacing scattered hand-written `if errorCode == ...` switches in the cgo wrappers. **Wire `Code` values change for every segcore pass-through error, not just the remapped ones.** Named sentinels remap (C++ `2003` → merr `2001`, `2033` → `2002`, Folly/Knowhere codes likewise); **all remaining pass-through codes (`2004`–`2043`, previously surfaced to clients as raw C++ enum values) now serialize as `2000`** (`ErrSegcore`), with the original C++ code preserved in the `Reason` text (`segcoreCode=...`); unknown/future codes collapse to `2000` as well (pinned by the `wire_code_projection` test). Transient segcore classes (object storage / file IO / OOM / mmap / FieldNotLoaded — 11 codes) now report `Retriable=true`. **Any client switching on raw segcore codes in the `2004`–`2043` range must be re-checked**; the in-Reason code remains available for diagnostics. Signal codes (PretendFinished / FollyCancel) are recognized centrally. `errors.Is`-based control flow on these (e.g. scheduler skip/retry) is preserved. **E. InputError classification (25 sentinels + dynamic marks).** 25 sentinels in `errors.go` carry `WithErrorType(InputError)` (the Collection / ResourceGroup / Database families, `ErrIndexDuplicate`, `ErrParameterInvalid`, `ErrPrivilegeNotAuthenticated`, `ErrImportFailed`, `ErrQueryPlan`, ...), plus dynamic marks for the 8 segcore input codes (ExprInvalid, DimNotMatch, MetricTypeInvalid, FieldIDInvalid, ...) and `WrapErrAsInputError`. The widest blast radius is `ErrParameterInvalid` (1100): ~2335 `WrapErrParameterInvalid*` callsites now classify as input / non-retriable. Because of C1/C2 this changes retriability for any path that returns these. **The audit to confirm no transient path was mis-marked is the single most important review item** (see Part 3). One reverse correction: storage field-stats parsing moved from `ErrParameterInvalid` (input) to `ErrDataIntegrity` — a corrupted stored stat is data corruption, not user input. ### Part 3 — Known risks & traps (called out proactively) 1. **`merr.Wrap` vs `WrapErr*Err` (code-masking).** `WrapErr*Err` builds a `wrappedMilvusError{sentinel: ErrServiceInternal}` whose `code()` returns the *outer* sentinel — it overwrites the inner typed code and hides the `errors.Is` chain. This is intentional (use it to *deliberately* downgrade), but it was a recurring conversion defect; the rule "add context with `merr.Wrap`, downgrade with `WrapErr*Err`" is enforced by convention and reviewed across the diff. 2. **InputError × `retry.Do` blast radius.** Marking a sentinel `InputError` makes any `retry.Do(...)` without a `RetryErr` predicate stop retrying it. Reviewers should sanity-check that no transient use of the 19 newly-marked sentinels (especially `ErrParameterInvalid`) sits inside a retry loop that needed to keep spinning. The known flusher cases were handled (see C2). 3. **The ~340 raw-error allowlist.** What remains as bare `errors.New` is, by design: package-level sentinels (caught by `errors.Is`), `//go:build test` sites, and out-of-band trees (`cmd/`, `tests/`, codegen, walimpls). The linter only bans the *direct-return* form; assignment-then-return escapes and the full no-exceptions ban are deferred to an AST-based linter (Tier 2, documented). 4. **segcore C++ second step deferred.** This PR unifies classification on the Go side; splitting the dual-semantic C++ codes at the source is a follow-up. --- ## Validation - `make verifiers`: Go side clean (gofmt + static-check across modules, including the new `rawmerrerror` rule with a 0-hit baseline repo-wide). - `make test-go`: passing; the one real regression introduced (a datanode `invalid_task_type` assertion shifting `1` → `5` from a ParameterInvalid conversion) was fixed in-tree. - go_client e2e CreateIndex assertions aligned to the new merr messages. --------- Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
620 lines
24 KiB
Go
620 lines
24 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package datanode
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strconv"
|
|
|
|
"go.opentelemetry.io/otel"
|
|
"go.opentelemetry.io/otel/attribute"
|
|
"go.opentelemetry.io/otel/trace"
|
|
"go.uber.org/zap"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v3/commonpb"
|
|
"github.com/milvus-io/milvus/internal/datanode/index"
|
|
"github.com/milvus-io/milvus/internal/util/hookutil"
|
|
"github.com/milvus-io/milvus/pkg/v3/log"
|
|
"github.com/milvus-io/milvus/pkg/v3/metrics"
|
|
"github.com/milvus-io/milvus/pkg/v3/proto/indexpb"
|
|
"github.com/milvus-io/milvus/pkg/v3/proto/workerpb"
|
|
"github.com/milvus-io/milvus/pkg/v3/util/merr"
|
|
"github.com/milvus-io/milvus/pkg/v3/util/paramtable"
|
|
"github.com/milvus-io/milvus/pkg/v3/util/typeutil"
|
|
)
|
|
|
|
// CreateJob is CreateIndex
|
|
func (node *DataNode) CreateJob(ctx context.Context, req *workerpb.CreateJobRequest) (*commonpb.Status, error) {
|
|
log := log.Ctx(ctx).With(
|
|
zap.String("clusterID", req.GetClusterID()),
|
|
zap.Int64("indexBuildID", req.GetBuildID()),
|
|
)
|
|
|
|
if err := node.lifetime.Add(merr.IsHealthy); err != nil {
|
|
log.Warn("index node not ready",
|
|
zap.Error(err),
|
|
)
|
|
return merr.Status(err), nil
|
|
}
|
|
defer node.lifetime.Done()
|
|
log.Info("DataNode building index ...",
|
|
zap.Int64("collectionID", req.GetCollectionID()),
|
|
zap.Int64("partitionID", req.GetPartitionID()),
|
|
zap.Int64("segmentID", req.GetSegmentID()),
|
|
zap.Int64("indexID", req.GetIndexID()),
|
|
zap.String("indexName", req.GetIndexName()),
|
|
zap.String("indexFilePrefix", req.GetIndexFilePrefix()),
|
|
zap.Int64("indexVersion", req.GetIndexVersion()),
|
|
zap.Strings("dataPaths", req.GetDataPaths()),
|
|
zap.Any("typeParams", req.GetTypeParams()),
|
|
zap.Any("indexParams", req.GetIndexParams()),
|
|
zap.Int64("numRows", req.GetNumRows()),
|
|
zap.Int32("current_index_version", req.GetCurrentIndexVersion()),
|
|
zap.Any("storepath", req.GetStorePath()),
|
|
zap.Any("storeversion", req.GetStoreVersion()),
|
|
zap.Any("dim", req.GetDim()),
|
|
)
|
|
ctx, sp := otel.Tracer(typeutil.DataNodeRole).Start(ctx, "DataNode-CreateIndex", trace.WithAttributes(
|
|
attribute.Int64("indexBuildID", req.GetBuildID()),
|
|
attribute.String("clusterID", req.GetClusterID()),
|
|
))
|
|
defer sp.End()
|
|
metrics.DataNodeBuildIndexTaskCounter.WithLabelValues(strconv.FormatInt(paramtable.GetNodeID(), 10), metrics.TotalLabel).Inc()
|
|
|
|
taskCtx, taskCancel := context.WithCancel(node.ctx)
|
|
if oldInfo := node.taskManager.LoadOrStoreIndexTask(req.GetClusterID(), req.GetBuildID(), &index.IndexTaskInfo{
|
|
Cancel: taskCancel,
|
|
State: commonpb.IndexState_InProgress,
|
|
}); oldInfo != nil {
|
|
// Node-internal dedup of a coordinator-dispatched build task: a duplicate
|
|
// is a scheduling race, not the user re-creating an index.
|
|
err := merr.WrapErrServiceInternalMsg("building index task existed, index=%s, buildID=%d", req.GetIndexName(), req.GetBuildID())
|
|
log.Warn("duplicated index build task", zap.Error(err))
|
|
metrics.DataNodeBuildIndexTaskCounter.WithLabelValues(paramtable.GetStringNodeID(), metrics.FailLabel).Inc()
|
|
return merr.Status(err), nil
|
|
}
|
|
cm, err := node.storageFactory.NewChunkManager(node.ctx, req.GetStorageConfig())
|
|
if err != nil {
|
|
log.Error("create chunk manager failed", zap.String("bucket", req.GetStorageConfig().GetBucketName()),
|
|
zap.String("accessKey", req.GetStorageConfig().GetAccessKeyID()),
|
|
zap.Error(err),
|
|
)
|
|
node.taskManager.DeleteIndexTaskInfos(ctx, []index.Key{{ClusterID: req.GetClusterID(), TaskID: req.GetBuildID()}})
|
|
metrics.DataNodeBuildIndexTaskCounter.WithLabelValues(paramtable.GetStringNodeID(), metrics.FailLabel).Inc()
|
|
return merr.Status(err), nil
|
|
}
|
|
pluginContext, err := hookutil.GetCPluginContext(req.GetPluginContext(), req.GetCollectionID())
|
|
if err != nil {
|
|
return merr.Status(err), nil
|
|
}
|
|
task := index.NewIndexBuildTask(taskCtx, taskCancel, req, cm, node.taskManager, pluginContext)
|
|
ret := merr.Success()
|
|
if err := node.taskScheduler.TaskQueue.Enqueue(task); err != nil {
|
|
log.Warn("DataNode failed to schedule",
|
|
zap.Error(err))
|
|
ret = merr.Status(err)
|
|
metrics.DataNodeBuildIndexTaskCounter.WithLabelValues(strconv.FormatInt(paramtable.GetNodeID(), 10), metrics.FailLabel).Inc()
|
|
return ret, nil
|
|
}
|
|
metrics.DataNodeBuildIndexTaskCounter.WithLabelValues(paramtable.GetStringNodeID(), metrics.SuccessLabel).Inc()
|
|
log.Info("DataNode successfully scheduled",
|
|
zap.String("indexName", req.GetIndexName()))
|
|
return ret, nil
|
|
}
|
|
|
|
func (node *DataNode) QueryJobs(ctx context.Context, req *workerpb.QueryJobsRequest) (*workerpb.QueryJobsResponse, error) {
|
|
log := log.Ctx(ctx).With(
|
|
zap.String("clusterID", req.GetClusterID()),
|
|
).WithRateGroup("in.queryJobs", 1, 60)
|
|
if err := node.lifetime.Add(merr.IsHealthyOrStopping); err != nil {
|
|
log.Warn("index node not ready", zap.Error(err))
|
|
return &workerpb.QueryJobsResponse{
|
|
Status: merr.Status(err),
|
|
}, nil
|
|
}
|
|
defer node.lifetime.Done()
|
|
infos := make(map[typeutil.UniqueID]*index.IndexTaskInfo)
|
|
node.taskManager.ForeachIndexTaskInfo(func(ClusterID string, buildID typeutil.UniqueID, info *index.IndexTaskInfo) {
|
|
if ClusterID == req.GetClusterID() {
|
|
infos[buildID] = info.Clone()
|
|
}
|
|
})
|
|
ret := &workerpb.QueryJobsResponse{
|
|
Status: merr.Success(),
|
|
ClusterID: req.GetClusterID(),
|
|
IndexInfos: make([]*workerpb.IndexTaskInfo, 0, len(req.GetTaskIDs())),
|
|
}
|
|
for i, buildID := range req.GetTaskIDs() {
|
|
ret.IndexInfos = append(ret.IndexInfos, &workerpb.IndexTaskInfo{
|
|
BuildID: buildID,
|
|
State: commonpb.IndexState_IndexStateNone,
|
|
IndexFileKeys: nil,
|
|
SerializedSize: 0,
|
|
})
|
|
if info, ok := infos[buildID]; ok {
|
|
ret.IndexInfos[i].State = info.State
|
|
ret.IndexInfos[i].IndexFileKeys = info.FileKeys
|
|
ret.IndexInfos[i].SerializedSize = info.SerializedSize
|
|
ret.IndexInfos[i].MemSize = info.MemSize
|
|
ret.IndexInfos[i].FailReason = info.FailReason
|
|
ret.IndexInfos[i].CurrentIndexVersion = info.CurrentIndexVersion
|
|
ret.IndexInfos[i].CurrentScalarIndexVersion = info.CurrentScalarIndexVersion
|
|
log.RatedDebug(5, "querying index build task",
|
|
zap.Int64("indexBuildID", buildID),
|
|
zap.String("state", info.State.String()),
|
|
zap.String("reason", info.FailReason),
|
|
)
|
|
}
|
|
}
|
|
return ret, nil
|
|
}
|
|
|
|
func (node *DataNode) DropJobs(ctx context.Context, req *workerpb.DropJobsRequest) (*commonpb.Status, error) {
|
|
log.Ctx(ctx).Info("drop index build jobs",
|
|
zap.String("clusterID", req.ClusterID),
|
|
zap.Int64s("indexBuildIDs", req.GetTaskIDs()),
|
|
)
|
|
if err := node.lifetime.Add(merr.IsHealthyOrStopping); err != nil {
|
|
log.Ctx(ctx).Warn("index node not ready", zap.Error(err), zap.String("clusterID", req.ClusterID))
|
|
return merr.Status(err), nil
|
|
}
|
|
defer node.lifetime.Done()
|
|
keys := make([]index.Key, 0, len(req.GetTaskIDs()))
|
|
for _, taskID := range req.GetTaskIDs() {
|
|
keys = append(keys, index.Key{ClusterID: req.GetClusterID(), TaskID: taskID})
|
|
}
|
|
infos := node.taskManager.DeleteIndexTaskInfos(ctx, keys)
|
|
for _, info := range infos {
|
|
if info.Cancel != nil {
|
|
info.Cancel()
|
|
}
|
|
}
|
|
log.Ctx(ctx).Info("drop index build jobs success", zap.String("clusterID", req.GetClusterID()),
|
|
zap.Int64s("indexBuildIDs", req.GetTaskIDs()))
|
|
return merr.Success(), nil
|
|
}
|
|
|
|
// GetJobStats should be GetSlots
|
|
func (node *DataNode) GetJobStats(ctx context.Context, req *workerpb.GetJobStatsRequest) (*workerpb.GetJobStatsResponse, error) {
|
|
if err := node.lifetime.Add(merr.IsHealthyOrStopping); err != nil {
|
|
log.Ctx(ctx).Warn("index node not ready", zap.Error(err))
|
|
return &workerpb.GetJobStatsResponse{
|
|
Status: merr.Status(err),
|
|
}, nil
|
|
}
|
|
defer node.lifetime.Done()
|
|
|
|
var (
|
|
totalSlots = index.CalculateNodeSlots()
|
|
indexStatsUsed = node.taskScheduler.TaskQueue.GetUsingSlot()
|
|
compactionUsed = node.compactionExecutor.Slots()
|
|
importUsed = node.importScheduler.Slots()
|
|
)
|
|
|
|
availableSlots := totalSlots - indexStatsUsed - compactionUsed - importUsed
|
|
if availableSlots < 0 {
|
|
availableSlots = 0
|
|
}
|
|
|
|
log.Ctx(ctx).Info("query slots done",
|
|
zap.Int64("totalSlots", totalSlots),
|
|
zap.Int64("availableSlots", availableSlots),
|
|
zap.Int64("indexStatsUsed", indexStatsUsed),
|
|
zap.Int64("compactionUsed", compactionUsed),
|
|
zap.Int64("importUsed", importUsed),
|
|
)
|
|
|
|
return &workerpb.GetJobStatsResponse{
|
|
Status: merr.Success(),
|
|
TotalSlots: totalSlots,
|
|
AvailableSlots: availableSlots,
|
|
}, nil
|
|
}
|
|
|
|
// Deprecated: use CreateTask instead, keep for compatibility
|
|
func (node *DataNode) CreateJobV2(ctx context.Context, req *workerpb.CreateJobV2Request) (*commonpb.Status, error) {
|
|
log := log.Ctx(ctx).With(
|
|
zap.String("clusterID", req.GetClusterID()), zap.Int64("TaskID", req.GetTaskID()),
|
|
zap.String("jobType", req.GetJobType().String()),
|
|
)
|
|
|
|
if err := node.lifetime.Add(merr.IsHealthy); err != nil {
|
|
log.Warn("index node not ready",
|
|
zap.Error(err),
|
|
)
|
|
return merr.Status(err), nil
|
|
}
|
|
defer node.lifetime.Done()
|
|
|
|
log.Info("DataNode receive CreateJob request...")
|
|
|
|
switch req.GetJobType() {
|
|
case indexpb.JobType_JobTypeIndexJob:
|
|
indexRequest := req.GetIndexRequest()
|
|
return node.createIndexTask(ctx, indexRequest)
|
|
case indexpb.JobType_JobTypeAnalyzeJob:
|
|
analyzeRequest := req.GetAnalyzeRequest()
|
|
return node.createAnalyzeTask(ctx, analyzeRequest)
|
|
case indexpb.JobType_JobTypeStatsJob:
|
|
statsRequest := req.GetStatsRequest()
|
|
return node.createStatsTask(ctx, statsRequest)
|
|
default:
|
|
log.Warn("DataNode receive unknown type job")
|
|
return merr.Status(merr.WrapErrServiceInternalMsg("DataNode receive unknown type job with TaskID: %d", req.GetTaskID())), nil
|
|
}
|
|
}
|
|
|
|
func (node *DataNode) createIndexTask(ctx context.Context, req *workerpb.CreateJobRequest) (*commonpb.Status, error) {
|
|
log.Ctx(ctx).Info("DataNode building index ...",
|
|
zap.String("clusterID", req.GetClusterID()),
|
|
zap.Int64("taskID", req.GetBuildID()),
|
|
zap.Int64("collectionID", req.GetCollectionID()),
|
|
zap.Int64("partitionID", req.GetPartitionID()),
|
|
zap.Int64("segmentID", req.GetSegmentID()),
|
|
zap.String("indexFilePrefix", req.GetIndexFilePrefix()),
|
|
zap.Int64("indexVersion", req.GetIndexVersion()),
|
|
zap.Strings("dataPaths", req.GetDataPaths()),
|
|
zap.Any("typeParams", req.GetTypeParams()),
|
|
zap.Any("indexParams", req.GetIndexParams()),
|
|
zap.Int64("numRows", req.GetNumRows()),
|
|
zap.Int32("current_index_version", req.GetCurrentIndexVersion()),
|
|
zap.String("storePath", req.GetStorePath()),
|
|
zap.Int64("storeVersion", req.GetStoreVersion()),
|
|
zap.Int64("dim", req.GetDim()),
|
|
zap.Int64("fieldID", req.GetFieldID()),
|
|
zap.String("fieldType", req.GetFieldType().String()),
|
|
zap.Any("field", req.GetField()),
|
|
zap.Int64("taskSlot", req.GetTaskSlot()),
|
|
zap.Int64("lackBinlogRows", req.GetLackBinlogRows()),
|
|
)
|
|
if req.GetTaskSlot() <= 0 {
|
|
log.Ctx(ctx).Warn("receive index task with invalid slot, set to 64", zap.Int64("taskSlot", req.GetTaskSlot()))
|
|
req.TaskSlot = 64
|
|
}
|
|
taskCtx, taskCancel := context.WithCancel(node.ctx)
|
|
if oldInfo := node.taskManager.LoadOrStoreIndexTask(req.GetClusterID(), req.GetBuildID(), &index.IndexTaskInfo{
|
|
Cancel: taskCancel,
|
|
State: commonpb.IndexState_InProgress,
|
|
IndexStorePathVersion: req.GetIndexStorePathVersion(),
|
|
}); oldInfo != nil {
|
|
err := merr.WrapErrTaskDuplicate(indexpb.JobType_JobTypeIndexJob.String(),
|
|
fmt.Sprintf("building index task existed with %s-%d", req.GetClusterID(), req.GetBuildID()))
|
|
log.Warn("duplicated index build task", zap.Error(err))
|
|
metrics.DataNodeBuildIndexTaskCounter.WithLabelValues(paramtable.GetStringNodeID(), metrics.FailLabel).Inc()
|
|
return merr.Status(err), nil
|
|
}
|
|
cm, err := node.storageFactory.NewChunkManager(node.ctx, req.GetStorageConfig())
|
|
if err != nil {
|
|
log.Error("create chunk manager failed", zap.String("bucket", req.GetStorageConfig().GetBucketName()),
|
|
zap.String("accessKey", req.GetStorageConfig().GetAccessKeyID()),
|
|
zap.Error(err),
|
|
)
|
|
node.taskManager.DeleteIndexTaskInfos(ctx, []index.Key{{ClusterID: req.GetClusterID(), TaskID: req.GetBuildID()}})
|
|
metrics.DataNodeBuildIndexTaskCounter.WithLabelValues(paramtable.GetStringNodeID(), metrics.FailLabel).Inc()
|
|
return merr.Status(err), nil
|
|
}
|
|
|
|
pluginContext, err := hookutil.GetCPluginContext(req.GetPluginContext(), req.GetCollectionID())
|
|
if err != nil {
|
|
return merr.Status(err), nil
|
|
}
|
|
|
|
task := index.NewIndexBuildTask(taskCtx, taskCancel, req, cm, node.taskManager, pluginContext)
|
|
ret := merr.Success()
|
|
if err := node.taskScheduler.TaskQueue.Enqueue(task); err != nil {
|
|
log.Warn("DataNode failed to schedule",
|
|
zap.Error(err))
|
|
ret = merr.Status(err)
|
|
metrics.DataNodeBuildIndexTaskCounter.WithLabelValues(strconv.FormatInt(paramtable.GetNodeID(), 10), metrics.FailLabel).Inc()
|
|
return ret, nil
|
|
}
|
|
metrics.DataNodeBuildIndexTaskCounter.WithLabelValues(paramtable.GetStringNodeID(), metrics.SuccessLabel).Inc()
|
|
log.Info("DataNode index job enqueued successfully",
|
|
zap.String("indexName", req.GetIndexName()))
|
|
return ret, nil
|
|
}
|
|
|
|
func (node *DataNode) createAnalyzeTask(ctx context.Context, req *workerpb.AnalyzeRequest) (*commonpb.Status, error) {
|
|
log.Ctx(ctx).Info("receive analyze job",
|
|
zap.String("clusterID", req.GetClusterID()),
|
|
zap.Int64("taskID", req.GetTaskID()),
|
|
zap.Int64("collectionID", req.GetCollectionID()),
|
|
zap.Int64("partitionID", req.GetPartitionID()),
|
|
zap.Int64("fieldID", req.GetFieldID()),
|
|
zap.String("fieldName", req.GetFieldName()),
|
|
zap.String("dataType", req.GetFieldType().String()),
|
|
zap.Int64("version", req.GetVersion()),
|
|
zap.Int64("dim", req.GetDim()),
|
|
zap.Float64("trainSizeRatio", req.GetMaxTrainSizeRatio()),
|
|
zap.Int64("numClusters", req.GetNumClusters()),
|
|
zap.Int64("taskSlot", req.GetTaskSlot()),
|
|
)
|
|
|
|
if req.GetTaskSlot() <= 0 {
|
|
log.Ctx(ctx).Warn("receive analyze task with invalid slot, set to 65535", zap.Int64("taskSlot", req.GetTaskSlot()))
|
|
req.TaskSlot = 65535
|
|
}
|
|
|
|
taskCtx, taskCancel := context.WithCancel(node.ctx)
|
|
if oldInfo := node.taskManager.LoadOrStoreAnalyzeTask(req.GetClusterID(), req.GetTaskID(), &index.AnalyzeTaskInfo{
|
|
Cancel: taskCancel,
|
|
State: indexpb.JobState_JobStateInProgress,
|
|
}); oldInfo != nil {
|
|
err := merr.WrapErrTaskDuplicate(indexpb.JobType_JobTypeAnalyzeJob.String(),
|
|
fmt.Sprintf("analyze task already existed with %s-%d", req.GetClusterID(), req.GetTaskID()))
|
|
log.Warn("duplicated analyze task", zap.Error(err))
|
|
return merr.Status(err), nil
|
|
}
|
|
t := index.NewAnalyzeTask(taskCtx, taskCancel, req, node.taskManager)
|
|
ret := merr.Success()
|
|
if err := node.taskScheduler.TaskQueue.Enqueue(t); err != nil {
|
|
log.Warn("DataNode failed to schedule", zap.Error(err))
|
|
ret = merr.Status(err)
|
|
return ret, nil
|
|
}
|
|
log.Info("DataNode analyze job enqueued successfully")
|
|
return ret, nil
|
|
}
|
|
|
|
func (node *DataNode) createStatsTask(ctx context.Context, req *workerpb.CreateStatsRequest) (*commonpb.Status, error) {
|
|
log.Ctx(ctx).Info("receive stats job",
|
|
zap.String("clusterID", req.GetClusterID()),
|
|
zap.Int64("taskID", req.GetTaskID()),
|
|
zap.Int64("collectionID", req.GetCollectionID()),
|
|
zap.Int64("partitionID", req.GetPartitionID()),
|
|
zap.Int64("segmentID", req.GetSegmentID()),
|
|
zap.Int64("numRows", req.GetNumRows()),
|
|
zap.Int64("targetSegmentID", req.GetTargetSegmentID()),
|
|
zap.String("subJobType", req.GetSubJobType().String()),
|
|
zap.Int64("startLogID", req.GetStartLogID()),
|
|
zap.Int64("endLogID", req.GetEndLogID()),
|
|
zap.Int64("taskSlot", req.GetTaskSlot()),
|
|
)
|
|
|
|
if req.GetTaskSlot() <= 0 {
|
|
log.Ctx(ctx).Warn("receive stats task with invalid slot, set to 64", zap.Int64("taskSlot", req.GetTaskSlot()))
|
|
req.TaskSlot = 64
|
|
}
|
|
|
|
taskCtx, taskCancel := context.WithCancel(node.ctx)
|
|
if oldInfo := node.taskManager.LoadOrStoreStatsTask(req.GetClusterID(), req.GetTaskID(), &index.StatsTaskInfo{
|
|
Cancel: taskCancel,
|
|
State: indexpb.JobState_JobStateInProgress,
|
|
}); oldInfo != nil {
|
|
err := merr.WrapErrTaskDuplicate(indexpb.JobType_JobTypeStatsJob.String(),
|
|
fmt.Sprintf("stats task already existed with %s-%d", req.GetClusterID(), req.GetTaskID()))
|
|
log.Warn("duplicated stats task", zap.Error(err))
|
|
return merr.Status(err), nil
|
|
}
|
|
cm, err := node.storageFactory.NewChunkManager(node.ctx, req.GetStorageConfig())
|
|
if err != nil {
|
|
log.Error("create chunk manager failed", zap.String("bucket", req.GetStorageConfig().GetBucketName()),
|
|
zap.String("accessKey", req.GetStorageConfig().GetAccessKeyID()),
|
|
zap.Error(err),
|
|
)
|
|
node.taskManager.DeleteStatsTaskInfos(ctx, []index.Key{{ClusterID: req.GetClusterID(), TaskID: req.GetTaskID()}})
|
|
return merr.Status(err), nil
|
|
}
|
|
|
|
t := index.NewStatsTask(taskCtx, taskCancel, req, node.taskManager, cm)
|
|
ret := merr.Success()
|
|
if err := node.taskScheduler.TaskQueue.Enqueue(t); err != nil {
|
|
log.Warn("DataNode failed to schedule", zap.Error(err))
|
|
ret = merr.Status(err)
|
|
return ret, nil
|
|
}
|
|
log.Info("DataNode stats job enqueued successfully")
|
|
return ret, nil
|
|
}
|
|
|
|
// Deprecated: use QueryTask instead, keep for compatibility
|
|
func (node *DataNode) QueryJobsV2(ctx context.Context, req *workerpb.QueryJobsV2Request) (*workerpb.QueryJobsV2Response, error) {
|
|
log := log.Ctx(ctx).With(
|
|
zap.String("clusterID", req.GetClusterID()), zap.Int64s("taskIDs", req.GetTaskIDs()),
|
|
).WithRateGroup("QueryResult", 1, 60)
|
|
|
|
if err := node.lifetime.Add(merr.IsHealthyOrStopping); err != nil {
|
|
log.Warn("DataNode not ready", zap.Error(err))
|
|
return &workerpb.QueryJobsV2Response{
|
|
Status: merr.Status(err),
|
|
}, nil
|
|
}
|
|
defer node.lifetime.Done()
|
|
|
|
switch req.GetJobType() {
|
|
case indexpb.JobType_JobTypeIndexJob:
|
|
return node.queryIndexTask(ctx, &workerpb.QueryJobsRequest{
|
|
ClusterID: req.GetClusterID(),
|
|
TaskIDs: req.GetTaskIDs(),
|
|
})
|
|
case indexpb.JobType_JobTypeAnalyzeJob:
|
|
return node.queryAnalyzeTask(ctx, &workerpb.QueryJobsRequest{
|
|
ClusterID: req.GetClusterID(),
|
|
TaskIDs: req.GetTaskIDs(),
|
|
})
|
|
case indexpb.JobType_JobTypeStatsJob:
|
|
return node.queryStatsTask(ctx, &workerpb.QueryJobsRequest{
|
|
ClusterID: req.GetClusterID(),
|
|
TaskIDs: req.GetTaskIDs(),
|
|
})
|
|
default:
|
|
log.Warn("DataNode receive querying unknown type jobs")
|
|
return &workerpb.QueryJobsV2Response{
|
|
Status: merr.Status(merr.WrapErrServiceInternalMsg("DataNode receive querying unknown type jobs")),
|
|
}, nil
|
|
}
|
|
}
|
|
|
|
func (node *DataNode) queryIndexTask(ctx context.Context, req *workerpb.QueryJobsRequest) (*workerpb.QueryJobsV2Response, error) {
|
|
log := log.Ctx(ctx).With(
|
|
zap.String("clusterID", req.GetClusterID()), zap.Int64s("taskIDs", req.GetTaskIDs()),
|
|
).WithRateGroup("QueryResult", 1, 60)
|
|
|
|
infos := make(map[typeutil.UniqueID]*index.IndexTaskInfo)
|
|
node.taskManager.ForeachIndexTaskInfo(func(ClusterID string, buildID typeutil.UniqueID, info *index.IndexTaskInfo) {
|
|
if ClusterID == req.GetClusterID() {
|
|
infos[buildID] = info.Clone()
|
|
}
|
|
})
|
|
results := make([]*workerpb.IndexTaskInfo, 0, len(req.GetTaskIDs()))
|
|
for _, buildID := range req.GetTaskIDs() {
|
|
if info, ok := infos[buildID]; ok {
|
|
results = append(results, info.ToIndexTaskInfo(buildID))
|
|
}
|
|
}
|
|
log.Debug("query index jobs result success", zap.Any("results", results))
|
|
if len(results) == 0 {
|
|
return &workerpb.QueryJobsV2Response{
|
|
Status: merr.Status(merr.WrapErrServiceInternalMsg("tasks '%v' not found", req.GetTaskIDs())),
|
|
}, nil
|
|
}
|
|
return &workerpb.QueryJobsV2Response{
|
|
Status: merr.Success(),
|
|
ClusterID: req.GetClusterID(),
|
|
Result: &workerpb.QueryJobsV2Response_IndexJobResults{
|
|
IndexJobResults: &workerpb.IndexJobResults{
|
|
Results: results,
|
|
},
|
|
},
|
|
}, nil
|
|
}
|
|
|
|
func (node *DataNode) queryStatsTask(ctx context.Context, req *workerpb.QueryJobsRequest) (*workerpb.QueryJobsV2Response, error) {
|
|
log := log.Ctx(ctx).With(
|
|
zap.String("clusterID", req.GetClusterID()), zap.Int64s("taskIDs", req.GetTaskIDs()),
|
|
).WithRateGroup("QueryResult", 1, 60)
|
|
|
|
results := make([]*workerpb.StatsResult, 0, len(req.GetTaskIDs()))
|
|
for _, taskID := range req.GetTaskIDs() {
|
|
info := node.taskManager.GetStatsTaskInfo(req.GetClusterID(), taskID)
|
|
if info != nil {
|
|
results = append(results, info.ToStatsResult(taskID))
|
|
}
|
|
}
|
|
log.Debug("query stats job result success", zap.Any("results", results))
|
|
if len(results) == 0 {
|
|
return &workerpb.QueryJobsV2Response{
|
|
Status: merr.Status(merr.WrapErrServiceInternalMsg("tasks '%v' not found", req.GetTaskIDs())),
|
|
}, nil
|
|
}
|
|
return &workerpb.QueryJobsV2Response{
|
|
Status: merr.Success(),
|
|
ClusterID: req.GetClusterID(),
|
|
Result: &workerpb.QueryJobsV2Response_StatsJobResults{
|
|
StatsJobResults: &workerpb.StatsResults{
|
|
Results: results,
|
|
},
|
|
},
|
|
}, nil
|
|
}
|
|
|
|
func (node *DataNode) queryAnalyzeTask(ctx context.Context, req *workerpb.QueryJobsRequest) (*workerpb.QueryJobsV2Response, error) {
|
|
log := log.Ctx(ctx).With(
|
|
zap.String("clusterID", req.GetClusterID()), zap.Int64s("taskIDs", req.GetTaskIDs()),
|
|
).WithRateGroup("QueryResult", 1, 60)
|
|
|
|
results := make([]*workerpb.AnalyzeResult, 0, len(req.GetTaskIDs()))
|
|
for _, taskID := range req.GetTaskIDs() {
|
|
info := node.taskManager.GetAnalyzeTaskInfo(req.GetClusterID(), taskID)
|
|
if info != nil {
|
|
results = append(results, &workerpb.AnalyzeResult{
|
|
TaskID: taskID,
|
|
State: info.State,
|
|
FailReason: info.FailReason,
|
|
CentroidsFile: info.CentroidsFile,
|
|
})
|
|
}
|
|
}
|
|
log.Debug("query analyze jobs result success", zap.Any("results", results))
|
|
if len(results) == 0 {
|
|
return &workerpb.QueryJobsV2Response{
|
|
Status: merr.Status(merr.WrapErrServiceInternalMsg("tasks '%v' not found", req.GetTaskIDs())),
|
|
}, nil
|
|
}
|
|
return &workerpb.QueryJobsV2Response{
|
|
Status: merr.Success(),
|
|
ClusterID: req.GetClusterID(),
|
|
Result: &workerpb.QueryJobsV2Response_AnalyzeJobResults{
|
|
AnalyzeJobResults: &workerpb.AnalyzeResults{
|
|
Results: results,
|
|
},
|
|
},
|
|
}, nil
|
|
}
|
|
|
|
// Deprecated: use DropTask instead, keep for compatibility
|
|
func (node *DataNode) DropJobsV2(ctx context.Context, req *workerpb.DropJobsV2Request) (*commonpb.Status, error) {
|
|
log := log.Ctx(ctx).With(zap.String("clusterID", req.GetClusterID()),
|
|
zap.Int64s("taskIDs", req.GetTaskIDs()),
|
|
zap.String("jobType", req.GetJobType().String()),
|
|
)
|
|
|
|
if err := node.lifetime.Add(merr.IsHealthyOrStopping); err != nil {
|
|
log.Warn("DataNode not ready", zap.Error(err))
|
|
return merr.Status(err), nil
|
|
}
|
|
defer node.lifetime.Done()
|
|
|
|
log.Info("DataNode receive DropJobs request")
|
|
|
|
switch req.GetJobType() {
|
|
case indexpb.JobType_JobTypeIndexJob:
|
|
keys := make([]index.Key, 0, len(req.GetTaskIDs()))
|
|
for _, buildID := range req.GetTaskIDs() {
|
|
keys = append(keys, index.Key{ClusterID: req.GetClusterID(), TaskID: buildID})
|
|
}
|
|
infos := node.taskManager.DeleteIndexTaskInfos(ctx, keys)
|
|
for _, info := range infos {
|
|
if info.Cancel != nil {
|
|
info.Cancel()
|
|
}
|
|
}
|
|
log.Info("drop index build jobs success")
|
|
return merr.Success(), nil
|
|
case indexpb.JobType_JobTypeAnalyzeJob:
|
|
keys := make([]index.Key, 0, len(req.GetTaskIDs()))
|
|
for _, taskID := range req.GetTaskIDs() {
|
|
keys = append(keys, index.Key{ClusterID: req.GetClusterID(), TaskID: taskID})
|
|
}
|
|
infos := node.taskManager.DeleteAnalyzeTaskInfos(ctx, keys)
|
|
for _, info := range infos {
|
|
if info.Cancel != nil {
|
|
info.Cancel()
|
|
}
|
|
}
|
|
log.Info("drop analyze jobs success")
|
|
return merr.Success(), nil
|
|
case indexpb.JobType_JobTypeStatsJob:
|
|
keys := make([]index.Key, 0, len(req.GetTaskIDs()))
|
|
for _, taskID := range req.GetTaskIDs() {
|
|
keys = append(keys, index.Key{ClusterID: req.GetClusterID(), TaskID: taskID})
|
|
}
|
|
infos := node.taskManager.DeleteStatsTaskInfos(ctx, keys)
|
|
for _, info := range infos {
|
|
if info.Cancel != nil {
|
|
info.Cancel()
|
|
}
|
|
}
|
|
log.Info("drop stats jobs success")
|
|
return merr.Success(), nil
|
|
default:
|
|
log.Warn("DataNode receive dropping unknown type jobs")
|
|
return merr.Status(merr.WrapErrServiceInternalMsg("DataNode receive dropping unknown type jobs")), nil
|
|
}
|
|
}
|