mirror of
https://github.com/milvus-io/milvus.git
synced 2026-07-21 02:05:41 +00:00
issue: #47420 ## What this PR does Project-wide migration of raw `fmt.Errorf` / `errors.New` in function bodies onto the `merr` framework, plus the Sys-vs-Input error classification and the machinery it drives (retriability, fine-grained metrics, segcore unification), plus the convention docs and a linter that keeps it from regressing. Scope: storage, proxy, coordinators (root/data/query), query node, data node, `pkg/util` & `internal/util`, expression parser, message queue, streaming, and misc packages. Bare raw-error usages went from ~3000 to a ~340 allowlist (package-level sentinels / build-tag / test sites). --- ## How to review this PR It is large but the vast majority is mechanical. Changes fall into three tiers; spend review budget on Part 2 and Part 3. ### Part 1 — Mechanical standardization (low risk, verify by rule) Each converted call follows one of a small fixed set of rules. To review, check that each site obeys the matching rule rather than reading every line: | Pattern | Rule | |---|---| | `fmt.Errorf("...")` originating a new error | → `merr.WrapErrXxxMsg("...")` with a code matching the failure's meaning | | Adding context to an existing typed error | → `merr.Wrap(err, "...")` / `merr.Wrapf(...)` — **preserves** the inner code (never `WrapErr*Err`, which overwrites it) | | Errors inside the streaming subsystem | → `status.New*` factories (StreamingError), **not** merr — this is the component-internal dialect (see `docs/dev/error_handling_guide.md`) | | Low-level / control-flow signal caught by `errors.Is` | → kept as a package-level `errors.New` sentinel (lowercase, same-package) | Conventions are documented in `docs/dev/error_handling_guide.md` (how-to) and `docs/dev/error_sentinel_convention.md` (rules + audit). A `gocritic`/`ruleguard` rule (`rawmerrerror`, in `rules.go`) enforces "no raw `return errors.New/fmt.Errorf`" under `make verifiers`. ### Part 2 — Behavior changes (review these closely) These are the sites where the wire contract or runtime behavior changes, not just the source text. Listed by category; representative locations given, full set in the diff. **A. gRPC wire-code shifts: `UnexpectedError(1)/Code 65535` → typed code.** Where a handler previously returned a raw error (collapsed to `Code=65535` on the wire), it now returns a typed merr, so the client sees a real code. The most common shift is to `IllegalArgument(5)/Code 1100` (ParameterInvalid). Touch points include datanode task handlers (CreateTask/Query/Drop), proxy Upsert, querynode GetMetrics, datacoord CreateIndex, httpserver query-response builder, and typeutil schema validation. One code refinement: an index-param validation moved `1100` → `1101` (ParameterMissing). **Client/SDK assertions and any code that switched on `Code=65535` for these paths must be re-checked** (the go_client e2e assertions were already aligned in this PR). **B. Prometheus `status` label contract change (externally visible).** The proxy metric's coarse `fail` / `rejected` values are split into `fail_input` / `fail_system` and `rejected_user` / `rejected_system` (in `requestutil.ParseMetricLabel`; auth/privilege rejections count as `rejected_user`), so dashboards can attribute a failure to caller vs operator. **Dashboards/alerts querying `status="fail"` must migrate to `status=~"fail_.*"`, and `status="rejected"` to `status=~"rejected_.*"`.** The in-repo Grafana dashboard is already migrated; external dashboards built on the old values silently go empty after upgrade. This is the one change that requires an ops-side migration. **C. Retriability semantics.** - C1: `merr.Status(err)` now forces `Retriable=false` when the error is an `InputError` — a malformed request can never succeed on blind retry, so clients never get the self-contradictory "your input is wrong but you may retry". - C2: `retry.Do` short-circuits an `InputError` (non-retriable) — **but only when the caller did not pass a `RetryErr` predicate**. The check is an `if c.isRetryErr != nil { ... } else if InputError { ... }` *mutually exclusive* branch (`pkg/util/retry/retry.go`): an explicit `RetryErr` takes precedence and bypasses the InputError abort. `retry.Handle` deliberately does **not** apply the InputError abort (its callers signal abort via `shouldRetry=false`). Four flusher startup callsites that must retry through transient "not ready" errors were given explicit `RetryErr` escape hatches. **D. segcore (C++→Go) error classification.** A single shared Go-side table (`pkg/util/merr/segcore.go`) maps each segcore code to a merr sentinel + InputError/signal category, replacing scattered hand-written `if errorCode == ...` switches in the cgo wrappers. **Wire `Code` values change for every segcore pass-through error, not just the remapped ones.** Named sentinels remap (C++ `2003` → merr `2001`, `2033` → `2002`, Folly/Knowhere codes likewise); **all remaining pass-through codes (`2004`–`2043`, previously surfaced to clients as raw C++ enum values) now serialize as `2000`** (`ErrSegcore`), with the original C++ code preserved in the `Reason` text (`segcoreCode=...`); unknown/future codes collapse to `2000` as well (pinned by the `wire_code_projection` test). Transient segcore classes (object storage / file IO / OOM / mmap / FieldNotLoaded — 11 codes) now report `Retriable=true`. **Any client switching on raw segcore codes in the `2004`–`2043` range must be re-checked**; the in-Reason code remains available for diagnostics. Signal codes (PretendFinished / FollyCancel) are recognized centrally. `errors.Is`-based control flow on these (e.g. scheduler skip/retry) is preserved. **E. InputError classification (25 sentinels + dynamic marks).** 25 sentinels in `errors.go` carry `WithErrorType(InputError)` (the Collection / ResourceGroup / Database families, `ErrIndexDuplicate`, `ErrParameterInvalid`, `ErrPrivilegeNotAuthenticated`, `ErrImportFailed`, `ErrQueryPlan`, ...), plus dynamic marks for the 8 segcore input codes (ExprInvalid, DimNotMatch, MetricTypeInvalid, FieldIDInvalid, ...) and `WrapErrAsInputError`. The widest blast radius is `ErrParameterInvalid` (1100): ~2335 `WrapErrParameterInvalid*` callsites now classify as input / non-retriable. Because of C1/C2 this changes retriability for any path that returns these. **The audit to confirm no transient path was mis-marked is the single most important review item** (see Part 3). One reverse correction: storage field-stats parsing moved from `ErrParameterInvalid` (input) to `ErrDataIntegrity` — a corrupted stored stat is data corruption, not user input. ### Part 3 — Known risks & traps (called out proactively) 1. **`merr.Wrap` vs `WrapErr*Err` (code-masking).** `WrapErr*Err` builds a `wrappedMilvusError{sentinel: ErrServiceInternal}` whose `code()` returns the *outer* sentinel — it overwrites the inner typed code and hides the `errors.Is` chain. This is intentional (use it to *deliberately* downgrade), but it was a recurring conversion defect; the rule "add context with `merr.Wrap`, downgrade with `WrapErr*Err`" is enforced by convention and reviewed across the diff. 2. **InputError × `retry.Do` blast radius.** Marking a sentinel `InputError` makes any `retry.Do(...)` without a `RetryErr` predicate stop retrying it. Reviewers should sanity-check that no transient use of the 19 newly-marked sentinels (especially `ErrParameterInvalid`) sits inside a retry loop that needed to keep spinning. The known flusher cases were handled (see C2). 3. **The ~340 raw-error allowlist.** What remains as bare `errors.New` is, by design: package-level sentinels (caught by `errors.Is`), `//go:build test` sites, and out-of-band trees (`cmd/`, `tests/`, codegen, walimpls). The linter only bans the *direct-return* form; assignment-then-return escapes and the full no-exceptions ban are deferred to an AST-based linter (Tier 2, documented). 4. **segcore C++ second step deferred.** This PR unifies classification on the Go side; splitting the dual-semantic C++ codes at the source is a follow-up. --- ## Validation - `make verifiers`: Go side clean (gofmt + static-check across modules, including the new `rawmerrerror` rule with a 0-hit baseline repo-wide). - `make test-go`: passing; the one real regression introduced (a datanode `invalid_task_type` assertion shifting `1` → `5` from a ParameterInvalid conversion) was fixed in-tree. - go_client e2e CreateIndex assertions aligned to the new merr messages. --------- Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
567 lines
18 KiB
Go
567 lines
18 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package httpserver
|
|
|
|
import (
|
|
"github.com/gin-gonic/gin"
|
|
"google.golang.org/protobuf/proto"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v3/milvuspb"
|
|
"github.com/milvus-io/milvus/internal/types"
|
|
"github.com/milvus-io/milvus/pkg/v3/util/merr"
|
|
)
|
|
|
|
// Handlers handles http requests
|
|
type Handlers struct {
|
|
proxy types.ProxyComponent
|
|
}
|
|
|
|
// NewHandlers creates a new Handlers
|
|
func NewHandlers(proxy types.ProxyComponent) *Handlers {
|
|
return &Handlers{
|
|
proxy: proxy,
|
|
}
|
|
}
|
|
|
|
// RegisterRouters registers routes to given router
|
|
func (h *Handlers) RegisterRoutesTo(router gin.IRouter) {
|
|
router.GET("/health", wrapHandler(h.handleGetHealth))
|
|
router.POST("/dummy", wrapHandler(h.handleDummy))
|
|
|
|
router.POST("/collection", wrapHandler(h.handleCreateCollection))
|
|
router.DELETE("/collection", wrapHandler(h.handleDropCollection))
|
|
router.GET("/collection/existence", wrapHandler(h.handleHasCollection))
|
|
router.GET("/collection", wrapHandler(h.handleDescribeCollection))
|
|
router.POST("/collection/load", wrapHandler(h.handleLoadCollection))
|
|
router.DELETE("/collection/load", wrapHandler(h.handleReleaseCollection))
|
|
router.GET("/collection/statistics", wrapHandler(h.handleGetCollectionStatistics))
|
|
router.GET("/collections", wrapHandler(h.handleShowCollections))
|
|
|
|
router.POST("/partition", wrapHandler(h.handleCreatePartition))
|
|
router.DELETE("/partition", wrapHandler(h.handleDropPartition))
|
|
router.GET("/partition/existence", wrapHandler(h.handleHasPartition))
|
|
router.POST("/partitions/load", wrapHandler(h.handleLoadPartitions))
|
|
router.DELETE("/partitions/load", wrapHandler(h.handleReleasePartitions))
|
|
router.GET("/partition/statistics", wrapHandler(h.handleGetPartitionStatistics))
|
|
router.GET("/partitions", wrapHandler(h.handleShowPartitions))
|
|
|
|
router.POST("/alias", wrapHandler(h.handleCreateAlias))
|
|
router.DELETE("/alias", wrapHandler(h.handleDropAlias))
|
|
router.PATCH("/alias", wrapHandler(h.handleAlterAlias))
|
|
|
|
router.POST("/index", wrapHandler(h.handleCreateIndex))
|
|
router.GET("/index", wrapHandler(h.handleDescribeIndex))
|
|
router.GET("/index/state", wrapHandler(h.handleGetIndexState))
|
|
router.GET("/index/progress", wrapHandler(h.handleGetIndexBuildProgress))
|
|
router.DELETE("/index", wrapHandler(h.handleDropIndex))
|
|
|
|
router.POST("/entities", wrapHandler(h.handleInsert))
|
|
router.DELETE("/entities", wrapHandler(h.handleDelete))
|
|
router.POST("/search", wrapHandler(h.handleSearch))
|
|
router.POST("/query", wrapHandler(h.handleQuery))
|
|
|
|
router.POST("/persist", wrapHandler(h.handleFlush))
|
|
router.GET("/distance", wrapHandler(h.handleCalcDistance))
|
|
router.GET("/persist/state", wrapHandler(h.handleGetFlushState))
|
|
router.GET("/persist/segment-info", wrapHandler(h.handleGetPersistentSegmentInfo))
|
|
router.GET("/query-segment-info", wrapHandler(h.handleGetQuerySegmentInfo))
|
|
router.GET("/replicas", wrapHandler(h.handleGetReplicas))
|
|
|
|
router.GET("/metrics", wrapHandler(h.handleGetMetrics))
|
|
router.POST("/load-balance", wrapHandler(h.handleLoadBalance))
|
|
router.GET("/compaction/state", wrapHandler(h.handleGetCompactionState))
|
|
router.GET("/compaction/plans", wrapHandler(h.handleGetCompactionStateWithPlans))
|
|
router.POST("/compaction", wrapHandler(h.handleManualCompaction))
|
|
|
|
router.POST("/import", wrapHandler(h.handleImport))
|
|
router.GET("/import/state", wrapHandler(h.handleGetImportState))
|
|
router.GET("/import/tasks", wrapHandler(h.handleListImportTasks))
|
|
|
|
router.POST("/credential", wrapHandler(h.handleCreateCredential))
|
|
router.PATCH("/credential", wrapHandler(h.handleUpdateCredential))
|
|
router.DELETE("/credential", wrapHandler(h.handleDeleteCredential))
|
|
router.GET("/credential/users", wrapHandler(h.handleListCredUsers))
|
|
}
|
|
|
|
func (h *Handlers) handleGetHealth(c *gin.Context) (interface{}, error) {
|
|
return gin.H{"status": "ok"}, nil
|
|
}
|
|
|
|
func (h *Handlers) handleDummy(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.DummyRequest{}
|
|
// use ShouldBind to supports binding JSON, XML, YAML, and protobuf.
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.Dummy(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleCreateCollection(c *gin.Context) (interface{}, error) {
|
|
wrappedReq := WrappedCreateCollectionRequest{}
|
|
err := shouldBind(c, &wrappedReq)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
schemaProto, err := proto.Marshal(&wrappedReq.Schema)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "marshal schema failed")
|
|
}
|
|
req := &milvuspb.CreateCollectionRequest{
|
|
Base: wrappedReq.Base,
|
|
DbName: wrappedReq.DbName,
|
|
CollectionName: wrappedReq.CollectionName,
|
|
Schema: schemaProto,
|
|
ShardsNum: wrappedReq.ShardsNum,
|
|
ConsistencyLevel: wrappedReq.ConsistencyLevel,
|
|
Properties: wrappedReq.Properties,
|
|
}
|
|
return h.proxy.CreateCollection(c, req)
|
|
}
|
|
|
|
func (h *Handlers) handleDropCollection(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.DropCollectionRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.DropCollection(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleHasCollection(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.HasCollectionRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.HasCollection(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleDescribeCollection(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.DescribeCollectionRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.DescribeCollection(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleLoadCollection(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.LoadCollectionRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.LoadCollection(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleReleaseCollection(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.ReleaseCollectionRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.ReleaseCollection(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleGetCollectionStatistics(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.GetCollectionStatisticsRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.GetCollectionStatistics(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleShowCollections(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.ShowCollectionsRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.ShowCollections(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleCreatePartition(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.CreatePartitionRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.CreatePartition(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleDropPartition(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.DropPartitionRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.DropPartition(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleHasPartition(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.HasPartitionRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.HasPartition(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleLoadPartitions(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.LoadPartitionsRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.LoadPartitions(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleReleasePartitions(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.ReleasePartitionsRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.ReleasePartitions(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleGetPartitionStatistics(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.GetPartitionStatisticsRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.GetPartitionStatistics(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleShowPartitions(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.ShowPartitionsRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.ShowPartitions(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleCreateAlias(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.CreateAliasRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.CreateAlias(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleDropAlias(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.DropAliasRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.DropAlias(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleAlterAlias(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.AlterAliasRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.AlterAlias(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleCreateIndex(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.CreateIndexRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.CreateIndex(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleDescribeIndex(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.DescribeIndexRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.DescribeIndex(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleGetIndexState(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.GetIndexStateRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.GetIndexState(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleGetIndexBuildProgress(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.GetIndexBuildProgressRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.GetIndexBuildProgress(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleDropIndex(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.DropIndexRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.DropIndex(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleInsert(c *gin.Context) (interface{}, error) {
|
|
wrappedReq := WrappedInsertRequest{}
|
|
err := shouldBind(c, &wrappedReq)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
req, err := wrappedReq.AsInsertRequest()
|
|
if err != nil {
|
|
return nil, badRequestf(err, "convert body to pb failed")
|
|
}
|
|
return h.proxy.Insert(c, req)
|
|
}
|
|
|
|
func (h *Handlers) handleDelete(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.DeleteRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.Delete(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleSearch(c *gin.Context) (interface{}, error) {
|
|
wrappedReq := SearchRequest{}
|
|
err := shouldBind(c, &wrappedReq)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
if wrappedReq.HasSearchAggregation() {
|
|
return nil, badRequestf(merr.WrapErrParameterInvalidMsg("searchAggregation is not supported for low-level REST search"), "invalid request")
|
|
}
|
|
req := milvuspb.SearchRequest{
|
|
Base: wrappedReq.Base,
|
|
DbName: wrappedReq.DbName,
|
|
CollectionName: wrappedReq.CollectionName,
|
|
PartitionNames: wrappedReq.PartitionNames,
|
|
Dsl: wrappedReq.Dsl,
|
|
DslType: wrappedReq.DslType,
|
|
OutputFields: wrappedReq.OutputFields,
|
|
SearchParams: wrappedReq.SearchParams,
|
|
TravelTimestamp: wrappedReq.TravelTimestamp,
|
|
GuaranteeTimestamp: wrappedReq.GuaranteeTimestamp,
|
|
Nq: wrappedReq.Nq,
|
|
}
|
|
if len(wrappedReq.BinaryVectors) > 0 {
|
|
req.SearchInput = &milvuspb.SearchRequest_PlaceholderGroup{
|
|
PlaceholderGroup: binaryVector2Bytes(wrappedReq.BinaryVectors),
|
|
}
|
|
} else {
|
|
req.SearchInput = &milvuspb.SearchRequest_PlaceholderGroup{
|
|
PlaceholderGroup: vector2Bytes(wrappedReq.Vectors),
|
|
}
|
|
}
|
|
return h.proxy.Search(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleQuery(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.QueryRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.Query(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleFlush(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.FlushRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.Flush(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleCalcDistance(c *gin.Context) (interface{}, error) {
|
|
wrappedReq := WrappedCalcDistanceRequest{}
|
|
err := shouldBind(c, &wrappedReq)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
|
|
req := milvuspb.CalcDistanceRequest{
|
|
Base: wrappedReq.Base,
|
|
Params: wrappedReq.Params,
|
|
OpLeft: wrappedReq.OpLeft.AsPbVectorArray(),
|
|
OpRight: wrappedReq.OpRight.AsPbVectorArray(),
|
|
}
|
|
return h.proxy.CalcDistance(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleGetFlushState(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.GetFlushStateRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.GetFlushState(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleGetPersistentSegmentInfo(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.GetPersistentSegmentInfoRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.GetPersistentSegmentInfo(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleGetQuerySegmentInfo(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.GetQuerySegmentInfoRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.GetQuerySegmentInfo(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleGetReplicas(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.GetReplicasRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.GetReplicas(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleGetMetrics(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.GetMetricsRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.GetMetrics(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleLoadBalance(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.LoadBalanceRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.LoadBalance(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleGetCompactionState(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.GetCompactionStateRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.GetCompactionState(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleGetCompactionStateWithPlans(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.GetCompactionPlansRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.GetCompactionStateWithPlans(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleManualCompaction(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.ManualCompactionRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.ManualCompaction(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleImport(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.ImportRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.Import(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleGetImportState(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.GetImportStateRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.GetImportState(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleListImportTasks(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.ListImportTasksRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.ListImportTasks(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleCreateCredential(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.CreateCredentialRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.CreateCredential(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleUpdateCredential(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.UpdateCredentialRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.UpdateCredential(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleDeleteCredential(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.DeleteCredentialRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.DeleteCredential(c, &req)
|
|
}
|
|
|
|
func (h *Handlers) handleListCredUsers(c *gin.Context) (interface{}, error) {
|
|
req := milvuspb.ListCredUsersRequest{}
|
|
err := shouldBind(c, &req)
|
|
if err != nil {
|
|
return nil, badRequestf(err, "parse body failed")
|
|
}
|
|
return h.proxy.ListCredUsers(c, &req)
|
|
}
|