From 7069d957206102575e81dbee271d2acab3b3ac06 Mon Sep 17 00:00:00 2001 From: Vincent Koc Date: Sun, 21 Jun 2026 19:59:55 +0200 Subject: [PATCH] fix(test): reject diff ref flag values --- scripts/check-docs-i18n-glossary.mjs | 2 +- scripts/lib/merge-head-diff-base.mjs | 2 +- test/scripts/check-docs-i18n-glossary.test.ts | 4 ++++ test/scripts/merge-head-diff-base.test.ts | 4 ++++ 4 files changed, 10 insertions(+), 2 deletions(-) diff --git a/scripts/check-docs-i18n-glossary.mjs b/scripts/check-docs-i18n-glossary.mjs index dcbc56f7c6c..89b3478704c 100644 --- a/scripts/check-docs-i18n-glossary.mjs +++ b/scripts/check-docs-i18n-glossary.mjs @@ -24,7 +24,7 @@ const MAX_TERM_LENGTH = 80; function readRefOptionValue(argv, index, optionName) { const value = argv[index + 1]; - if (value === undefined || value === "" || value.startsWith("--")) { + if (value === undefined || value === "" || value.startsWith("-")) { throw new Error(`${optionName} requires a value`); } return value; diff --git a/scripts/lib/merge-head-diff-base.mjs b/scripts/lib/merge-head-diff-base.mjs index aa65b2cda9b..28a081ca1dd 100644 --- a/scripts/lib/merge-head-diff-base.mjs +++ b/scripts/lib/merge-head-diff-base.mjs @@ -62,7 +62,7 @@ function resolveCommit({ ref, cwd, maxBuffer }) { function readRefValue(argv, index, optionName) { const value = argv[index + 1]; - if (value === undefined || value === "" || value.startsWith("--")) { + if (value === undefined || value === "" || value.startsWith("-")) { throw new Error(`${optionName} requires a value`); } return value; diff --git a/test/scripts/check-docs-i18n-glossary.test.ts b/test/scripts/check-docs-i18n-glossary.test.ts index 2142aa21ab3..72315ab671e 100644 --- a/test/scripts/check-docs-i18n-glossary.test.ts +++ b/test/scripts/check-docs-i18n-glossary.test.ts @@ -11,7 +11,11 @@ describe("check-docs-i18n-glossary", () => { it("rejects missing diff ref values", () => { expect(() => parseArgs(["--base", "--head", "HEAD"])).toThrow("--base requires a value"); + expect(() => parseArgs(["--base", "-h", "--head", "HEAD"])).toThrow( + "--base requires a value", + ); expect(() => parseArgs(["--head"])).toThrow("--head requires a value"); + expect(() => parseArgs(["--head", "-h"])).toThrow("--head requires a value"); expect(() => parseArgs(["--base", ""])).toThrow("--base requires a value"); }); }); diff --git a/test/scripts/merge-head-diff-base.test.ts b/test/scripts/merge-head-diff-base.test.ts index f74d7865dcd..01ab7399547 100644 --- a/test/scripts/merge-head-diff-base.test.ts +++ b/test/scripts/merge-head-diff-base.test.ts @@ -12,7 +12,11 @@ describe("merge-head-diff-base", () => { it("rejects missing refs", () => { expect(() => parseArgs(["--base", "--head", "HEAD"])).toThrow("--base requires a value"); + expect(() => parseArgs(["--base", "-h", "--head", "HEAD"])).toThrow( + "--base requires a value", + ); expect(() => parseArgs(["--head"])).toThrow("--head requires a value"); + expect(() => parseArgs(["--head", "-h"])).toThrow("--head requires a value"); expect(() => parseArgs(["--base", ""])).toThrow("--base requires a value"); });