mirror of
https://github.com/openclaw/openclaw.git
synced 2026-07-21 10:16:44 +00:00
* fix(mantis): bound upload error response bodies Replace unbounded response.text() on non-ok upload error paths with readBoundedResponseText (64 KiB cap). Only swallow the size-exceeded diagnostic; propagate signal aborts and other failures so timeouts during body reading are not masked as generic upload failures. - Import shared readBoundedResponseText from scripts/lib/bounded-response.mjs - Add MANTIS_UPLOAD_ERROR_BODY_MAX_BYTES constant (64 KiB) - Catch only size-exceeded errors; re-throw timeouts and stream errors - Add test: oversized body bounded at 64 KiB - Add test: signal abort during body read propagates correctly - Add test: small error body within bound reads normally * fix(mantis): contextualize bounded upload failures Co-authored-by: 胡根深 0668000903 <hu.genshen@xydigit.com> --------- Co-authored-by: Peter Steinberger <steipete@gmail.com>
507 lines
18 KiB
TypeScript
507 lines
18 KiB
TypeScript
// Mantis Publish Pr Evidence tests cover mantis publish pr evidence script behavior.
|
|
import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import path from "node:path";
|
|
import { afterEach, describe, expect, it } from "vitest";
|
|
import {
|
|
loadEvidenceManifest,
|
|
publishArtifactFiles,
|
|
renderEvidenceComment,
|
|
shouldPublishPrComment,
|
|
} from "../../scripts/mantis/publish-pr-evidence.mjs";
|
|
|
|
const tempDirs: string[] = [];
|
|
|
|
afterEach(() => {
|
|
for (const dir of tempDirs.splice(0)) {
|
|
rmSync(dir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
function writeFixtureManifest() {
|
|
const dir = mkdtempSync(path.join(tmpdir(), "mantis-evidence-test-"));
|
|
tempDirs.push(dir);
|
|
mkdirSync(path.join(dir, "baseline"), { recursive: true });
|
|
mkdirSync(path.join(dir, "candidate"), { recursive: true });
|
|
writeFileSync(path.join(dir, "baseline", "timeline.png"), "baseline timeline");
|
|
writeFileSync(path.join(dir, "candidate", "timeline.png"), "candidate timeline");
|
|
writeFileSync(path.join(dir, "baseline", "change.mp4"), "baseline clip");
|
|
const manifestPath = path.join(dir, "mantis-evidence.json");
|
|
writeFileSync(
|
|
manifestPath,
|
|
JSON.stringify({
|
|
schemaVersion: 1,
|
|
id: "discord-status-reactions",
|
|
title: "Mantis Discord Status Reactions QA",
|
|
summary: "Mantis reran the scenario.",
|
|
scenario: "discord-status-reactions-tool-only",
|
|
comparison: {
|
|
baseline: {
|
|
expected: "queued-only",
|
|
sha: "aaa",
|
|
status: "fail",
|
|
},
|
|
candidate: {
|
|
expected: "queued -> thinking -> done",
|
|
sha: "bbb",
|
|
status: "pass",
|
|
},
|
|
pass: true,
|
|
},
|
|
artifacts: [
|
|
{
|
|
alt: "Baseline timeline",
|
|
kind: "timeline",
|
|
label: "Baseline queued-only",
|
|
lane: "baseline",
|
|
path: "baseline/timeline.png",
|
|
targetPath: "baseline.png",
|
|
},
|
|
{
|
|
alt: "Candidate timeline",
|
|
kind: "timeline",
|
|
label: "Candidate queued -> thinking -> done",
|
|
lane: "candidate",
|
|
path: "candidate/timeline.png",
|
|
targetPath: "candidate.png",
|
|
},
|
|
{
|
|
kind: "motionClip",
|
|
label: "Baseline change MP4",
|
|
lane: "baseline",
|
|
path: "baseline/change.mp4",
|
|
targetPath: "baseline-change.mp4",
|
|
},
|
|
],
|
|
}),
|
|
);
|
|
return manifestPath;
|
|
}
|
|
|
|
describe("scripts/mantis/publish-pr-evidence", () => {
|
|
it("renders a manifest-driven PR comment with inline screenshots and video links", () => {
|
|
const manifest = loadEvidenceManifest(writeFixtureManifest());
|
|
const body = renderEvidenceComment({
|
|
artifactUrl: "https://github.com/openclaw/openclaw/actions/runs/1/artifacts/2",
|
|
manifest,
|
|
marker: "<!-- mantis-discord-status-reactions -->",
|
|
rawBase: "https://qa.openclaw.ai/mantis/discord/pr-1/run-1",
|
|
requestSource: "workflow_dispatch",
|
|
runUrl: "https://github.com/openclaw/openclaw/actions/runs/1",
|
|
treeUrl: "https://qa.openclaw.ai/mantis/discord/pr-1/run-1",
|
|
});
|
|
|
|
expect(body).toContain("<!-- mantis-discord-status-reactions -->");
|
|
expect(body).toContain("Summary: Mantis reran the scenario.");
|
|
expect(body).toContain('<table width="100%">');
|
|
expect(body).toContain('<th width="50%">Baseline queued-only</th>');
|
|
expect(body).toContain('<th width="50%">Candidate queued -> thinking -> done</th>');
|
|
expect(body).toContain(
|
|
'<td width="50%" align="center"><img src="https://qa.openclaw.ai/mantis/discord/pr-1/run-1/baseline.png" width="100%"',
|
|
);
|
|
expect(body).toContain(
|
|
"[Baseline change MP4](https://qa.openclaw.ai/mantis/discord/pr-1/run-1/baseline-change.mp4)",
|
|
);
|
|
expect(body).not.toContain("raw.githubusercontent.com");
|
|
expect(body).toContain("- Overall: `true`");
|
|
});
|
|
|
|
it("uploads manifest artifacts to R2-compatible object storage", async () => {
|
|
const manifest = loadEvidenceManifest(writeFixtureManifest());
|
|
const requests: Array<{
|
|
body: Buffer;
|
|
headers: HeadersInit;
|
|
method: string;
|
|
signal: AbortSignal;
|
|
url: string;
|
|
}> = [];
|
|
const fetchImpl = async (
|
|
url: URL,
|
|
init: { body: Buffer; headers: HeadersInit; method: string; signal: AbortSignal },
|
|
) => {
|
|
requests.push({
|
|
body: init.body,
|
|
headers: init.headers,
|
|
method: init.method,
|
|
signal: init.signal,
|
|
url: url.toString(),
|
|
});
|
|
return new Response("", { status: 200 });
|
|
};
|
|
|
|
const published = await publishArtifactFiles({
|
|
artifactRoot: "mantis/discord/pr-1/run-1",
|
|
fetchImpl,
|
|
manifest,
|
|
storageConfig: {
|
|
accessKeyId: "access",
|
|
bucket: "qa-artifacts",
|
|
endpoint: "https://example.r2.cloudflarestorage.com",
|
|
publicBaseUrl: "https://qa.openclaw.ai",
|
|
region: "auto",
|
|
secretAccessKey: "secret",
|
|
},
|
|
});
|
|
|
|
expect(published).toEqual({
|
|
artifactRoot: "mantis/discord/pr-1/run-1",
|
|
rawBase: "https://qa.openclaw.ai/mantis/discord/pr-1/run-1",
|
|
treeUrl: "https://qa.openclaw.ai/mantis/discord/pr-1/run-1/index.json",
|
|
});
|
|
expect(requests.map((request) => request.method)).toEqual(["PUT", "PUT", "PUT", "PUT", "PUT"]);
|
|
expect(requests.every((request) => request.signal instanceof AbortSignal)).toBe(true);
|
|
expect(requests.map((request) => request.url)).toEqual([
|
|
"https://example.r2.cloudflarestorage.com/qa-artifacts/mantis/discord/pr-1/run-1/baseline.png",
|
|
"https://example.r2.cloudflarestorage.com/qa-artifacts/mantis/discord/pr-1/run-1/candidate.png",
|
|
"https://example.r2.cloudflarestorage.com/qa-artifacts/mantis/discord/pr-1/run-1/baseline-change.mp4",
|
|
"https://example.r2.cloudflarestorage.com/qa-artifacts/mantis/discord/pr-1/run-1/mantis-evidence.json",
|
|
"https://example.r2.cloudflarestorage.com/qa-artifacts/mantis/discord/pr-1/run-1/index.json",
|
|
]);
|
|
expect(requests[0]?.headers).toMatchObject({
|
|
"content-type": "image/png",
|
|
"x-amz-date": expect.any(String),
|
|
});
|
|
expect((requests[0]?.headers as Record<string, string> | undefined)?.authorization).toContain(
|
|
"Credential=access/",
|
|
);
|
|
expect(String(requests[4]?.body)).toContain(
|
|
'"url": "https://qa.openclaw.ai/mantis/discord/pr-1/run-1/baseline.png"',
|
|
);
|
|
});
|
|
|
|
it("aborts a stalled artifact upload after the per-object timeout", async () => {
|
|
const manifest = loadEvidenceManifest(writeFixtureManifest());
|
|
let observedSignal: AbortSignal | undefined;
|
|
|
|
const upload = publishArtifactFiles({
|
|
artifactRoot: "mantis/discord/pr-1/run-1",
|
|
fetchImpl: (_url, init) => {
|
|
observedSignal = init.signal;
|
|
return new Promise<Response>((_resolve, reject) => {
|
|
init.signal.addEventListener("abort", () => reject(init.signal.reason), { once: true });
|
|
});
|
|
},
|
|
manifest,
|
|
storageConfig: {
|
|
accessKeyId: "access",
|
|
bucket: "qa-artifacts",
|
|
endpoint: "https://example.r2.cloudflarestorage.com",
|
|
publicBaseUrl: "https://qa.openclaw.ai",
|
|
region: "auto",
|
|
secretAccessKey: "secret",
|
|
},
|
|
timeoutMs: 5,
|
|
});
|
|
|
|
await expect(upload).rejects.toMatchObject({
|
|
cause: { name: "TimeoutError" },
|
|
message: "Timed out uploading Mantis artifact baseline.png after 5ms.",
|
|
});
|
|
expect(observedSignal?.aborted).toBe(true);
|
|
});
|
|
|
|
it("bounds oversized non-ok upload error response bodies", async () => {
|
|
const manifest = loadEvidenceManifest(writeFixtureManifest());
|
|
const chunk = new Uint8Array(8 * 1024).fill("x".charCodeAt(0));
|
|
let enqueuedBytes = 0;
|
|
const body = new ReadableStream<Uint8Array>({
|
|
pull(controller) {
|
|
enqueuedBytes += chunk.byteLength;
|
|
controller.enqueue(chunk);
|
|
},
|
|
});
|
|
|
|
const upload = publishArtifactFiles({
|
|
artifactRoot: "mantis/discord/pr-1/run-1",
|
|
fetchImpl: async () =>
|
|
new Response(body, {
|
|
status: 503,
|
|
statusText: "Service Unavailable",
|
|
}),
|
|
manifest,
|
|
storageConfig: {
|
|
accessKeyId: "access",
|
|
bucket: "qa-artifacts",
|
|
endpoint: "https://example.r2.cloudflarestorage.com",
|
|
publicBaseUrl: "https://qa.openclaw.ai",
|
|
region: "auto",
|
|
secretAccessKey: "secret",
|
|
},
|
|
});
|
|
|
|
await expect(upload).rejects.toMatchObject({
|
|
message: expect.stringMatching(
|
|
/^Failed to upload Mantis artifact baseline\.png: 503 Service Unavailable\nMantis upload error response body exceeded 65536 bytes$/u,
|
|
),
|
|
});
|
|
// Unbounded response.text() would keep pulling forever; the bound cancels after ~64 KiB.
|
|
expect(enqueuedBytes).toBeGreaterThan(64 * 1024);
|
|
expect(enqueuedBytes).toBeLessThanOrEqual(256 * 1024);
|
|
});
|
|
|
|
it("propagates signal abort during non-ok upload error body reading", async () => {
|
|
const manifest = loadEvidenceManifest(writeFixtureManifest());
|
|
let cancelled = false;
|
|
// A slow-streaming error body that will stall until the signal fires.
|
|
const body = new ReadableStream<Uint8Array>({
|
|
pull() {
|
|
// Never resolves; the signal will abort the read.
|
|
return new Promise(() => {});
|
|
},
|
|
cancel() {
|
|
cancelled = true;
|
|
},
|
|
});
|
|
|
|
const upload = publishArtifactFiles({
|
|
artifactRoot: "mantis/discord/pr-1/run-1",
|
|
fetchImpl: async () =>
|
|
new Response(body, {
|
|
status: 503,
|
|
statusText: "Service Unavailable",
|
|
}),
|
|
manifest,
|
|
storageConfig: {
|
|
accessKeyId: "access",
|
|
bucket: "qa-artifacts",
|
|
endpoint: "https://example.r2.cloudflarestorage.com",
|
|
publicBaseUrl: "https://qa.openclaw.ai",
|
|
region: "auto",
|
|
secretAccessKey: "secret",
|
|
},
|
|
timeoutMs: 50,
|
|
});
|
|
|
|
await expect(upload).rejects.toMatchObject({
|
|
cause: { name: "TimeoutError" },
|
|
message: "Timed out uploading Mantis artifact baseline.png after 50ms.",
|
|
});
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
expect(cancelled).toBe(true);
|
|
});
|
|
|
|
it("reads small non-ok upload error response bodies within the bound", async () => {
|
|
const manifest = loadEvidenceManifest(writeFixtureManifest());
|
|
const smallBody = "access denied: invalid credentials";
|
|
|
|
const upload = publishArtifactFiles({
|
|
artifactRoot: "mantis/discord/pr-1/run-1",
|
|
fetchImpl: async () =>
|
|
new Response(smallBody, {
|
|
status: 403,
|
|
statusText: "Forbidden",
|
|
}),
|
|
manifest,
|
|
storageConfig: {
|
|
accessKeyId: "access",
|
|
bucket: "qa-artifacts",
|
|
endpoint: "https://example.r2.cloudflarestorage.com",
|
|
publicBaseUrl: "https://qa.openclaw.ai",
|
|
region: "auto",
|
|
secretAccessKey: "secret",
|
|
},
|
|
});
|
|
|
|
await expect(upload).rejects.toMatchObject({
|
|
message: expect.stringMatching(
|
|
/^Failed to upload Mantis artifact baseline\.png: 403 Forbidden\naccess denied: invalid credentials$/u,
|
|
),
|
|
});
|
|
});
|
|
|
|
it("allows failure manifests to omit optional visual artifacts", () => {
|
|
const dir = mkdtempSync(path.join(tmpdir(), "mantis-evidence-test-"));
|
|
tempDirs.push(dir);
|
|
writeFileSync(path.join(dir, "summary.json"), JSON.stringify({ status: "fail" }));
|
|
writeFileSync(path.join(dir, "report.md"), "bootstrap failed before screenshot");
|
|
const manifestPath = path.join(dir, "mantis-evidence.json");
|
|
writeFileSync(
|
|
manifestPath,
|
|
JSON.stringify({
|
|
schemaVersion: 1,
|
|
id: "slack-desktop-smoke",
|
|
title: "Mantis Slack Desktop Smoke QA",
|
|
summary: "Mantis could not finish VM setup.",
|
|
scenario: "slack-openclaw-desktop-smoke",
|
|
comparison: {
|
|
candidate: {
|
|
expected: "Slack QA and VM gateway setup pass",
|
|
sha: "bbb",
|
|
status: "fail",
|
|
},
|
|
pass: false,
|
|
},
|
|
artifacts: [
|
|
{
|
|
alt: "Slack Web desktop screenshot from the Mantis VM",
|
|
inline: true,
|
|
kind: "desktopScreenshot",
|
|
label: "Slack desktop/VNC browser",
|
|
lane: "candidate",
|
|
path: "slack-desktop-smoke.png",
|
|
required: false,
|
|
targetPath: "slack-desktop.png",
|
|
},
|
|
{
|
|
kind: "metadata",
|
|
label: "Slack desktop summary",
|
|
lane: "run",
|
|
path: "summary.json",
|
|
targetPath: "summary.json",
|
|
},
|
|
{
|
|
kind: "report",
|
|
label: "Slack desktop report",
|
|
lane: "run",
|
|
path: "report.md",
|
|
targetPath: "report.md",
|
|
},
|
|
],
|
|
}),
|
|
);
|
|
|
|
const manifest = loadEvidenceManifest(manifestPath);
|
|
expect(manifest.artifacts.map((artifact) => artifact.targetPath)).toEqual([
|
|
"summary.json",
|
|
"report.md",
|
|
"mantis-evidence.json",
|
|
]);
|
|
const body = renderEvidenceComment({
|
|
artifactUrl: "https://github.com/openclaw/openclaw/actions/runs/1/artifacts/2",
|
|
manifest,
|
|
marker: "<!-- mantis-slack-desktop-smoke -->",
|
|
rawBase: "https://qa.openclaw.ai/mantis/slack/pr-1/run-1",
|
|
requestSource: "workflow_dispatch",
|
|
runUrl: "https://github.com/openclaw/openclaw/actions/runs/1",
|
|
treeUrl: "https://qa.openclaw.ai/mantis/slack/pr-1/run-1",
|
|
});
|
|
|
|
expect(body).toContain("Summary: Mantis could not finish VM setup.");
|
|
expect(body).toContain("- Overall: `false`");
|
|
expect(body).not.toContain("<img ");
|
|
});
|
|
|
|
it("renders a successful no-visual-proof manifest without media tables", () => {
|
|
const dir = mkdtempSync(path.join(tmpdir(), "mantis-evidence-test-"));
|
|
tempDirs.push(dir);
|
|
const manifestPath = path.join(dir, "mantis-evidence.json");
|
|
writeFileSync(
|
|
manifestPath,
|
|
JSON.stringify({
|
|
artifacts: [],
|
|
comparison: {
|
|
baseline: {
|
|
expected: "no visible Telegram Desktop delta",
|
|
status: "skipped",
|
|
},
|
|
candidate: {
|
|
expected: "no visible Telegram Desktop delta",
|
|
status: "skipped",
|
|
},
|
|
pass: true,
|
|
},
|
|
id: "telegram-desktop-proof",
|
|
scenario: "telegram-desktop-proof",
|
|
schemaVersion: 1,
|
|
summary:
|
|
"Mantis did not generate before/after GIFs because this PR changes CI wiring only.",
|
|
title: "Mantis Telegram Desktop Proof",
|
|
}),
|
|
);
|
|
|
|
const manifest = loadEvidenceManifest(manifestPath);
|
|
const body = renderEvidenceComment({
|
|
artifactRoot: "mantis/telegram-desktop/pr-1/run-1",
|
|
manifest,
|
|
marker: "<!-- mantis-telegram-desktop-proof -->",
|
|
rawBase:
|
|
"https://raw.githubusercontent.com/openclaw/openclaw/qa-artifacts/mantis/telegram-desktop/pr-1/run-1",
|
|
requestSource: "issue_comment",
|
|
runUrl: "https://github.com/openclaw/openclaw/actions/runs/1",
|
|
treeUrl:
|
|
"https://github.com/openclaw/openclaw/tree/qa-artifacts/mantis/telegram-desktop/pr-1/run-1",
|
|
});
|
|
|
|
expect(manifest.artifacts.map((artifact) => artifact.targetPath)).toEqual([
|
|
"mantis-evidence.json",
|
|
]);
|
|
expect(body).toContain(
|
|
"Summary: Mantis did not generate before/after GIFs because this PR changes CI wiring only.",
|
|
);
|
|
expect(body).toContain("- Overall: `true`");
|
|
expect(body).not.toContain("<table");
|
|
expect(body).not.toContain("<img ");
|
|
expect(shouldPublishPrComment(manifest, { requestSource: "issue_comment" })).toBe(true);
|
|
expect(shouldPublishPrComment(manifest, { requestSource: "pull_request_target" })).toBe(false);
|
|
});
|
|
|
|
it("does not publish PR comments for Telegram capture infrastructure failures", () => {
|
|
const dir = mkdtempSync(path.join(tmpdir(), "mantis-evidence-test-"));
|
|
tempDirs.push(dir);
|
|
const manifestPath = path.join(dir, "mantis-evidence.json");
|
|
writeFileSync(
|
|
manifestPath,
|
|
JSON.stringify({
|
|
artifacts: [],
|
|
comparison: {
|
|
baseline: {
|
|
expected: "no acceptable native Telegram Desktop visual artifact",
|
|
status: "skipped",
|
|
},
|
|
candidate: {
|
|
expected: "no acceptable native Telegram Desktop visual artifact",
|
|
status: "skipped",
|
|
},
|
|
pass: false,
|
|
},
|
|
id: "telegram-desktop-proof",
|
|
scenario: "telegram-desktop-proof",
|
|
schemaVersion: 1,
|
|
summary:
|
|
"Mantis could not capture Telegram Desktop proof because native Telegram Desktop opened to the logged-out welcome screen.",
|
|
title: "Mantis Telegram Desktop Proof",
|
|
}),
|
|
);
|
|
|
|
const manifest = loadEvidenceManifest(manifestPath);
|
|
const body = renderEvidenceComment({
|
|
manifest,
|
|
marker: "<!-- mantis-telegram-desktop-proof -->",
|
|
rawBase: "https://artifacts.openclaw.ai/mantis/telegram-desktop/pr-1/run-1",
|
|
requestSource: "pull_request_target",
|
|
runUrl: "https://github.com/openclaw/openclaw/actions/runs/1",
|
|
treeUrl: "https://artifacts.openclaw.ai/mantis/telegram-desktop/pr-1/run-1/index.json",
|
|
});
|
|
|
|
expect(body).toContain(
|
|
"Summary: Mantis could not capture Telegram Desktop proof because native Telegram Desktop opened to the logged-out welcome screen.",
|
|
);
|
|
expect(body).toContain("- Overall: `false`");
|
|
expect(shouldPublishPrComment(manifest, { requestSource: "issue_comment" })).toBe(false);
|
|
expect(shouldPublishPrComment(manifest, { requestSource: "pull_request_target" })).toBe(false);
|
|
});
|
|
|
|
it("rejects artifact paths that escape the manifest directory", () => {
|
|
const dir = mkdtempSync(path.join(tmpdir(), "mantis-evidence-test-"));
|
|
tempDirs.push(dir);
|
|
const manifestPath = path.join(dir, "mantis-evidence.json");
|
|
writeFileSync(
|
|
manifestPath,
|
|
JSON.stringify({
|
|
artifacts: [
|
|
{
|
|
kind: "metadata",
|
|
path: "../outside.json",
|
|
},
|
|
],
|
|
id: "bad",
|
|
scenario: "bad",
|
|
schemaVersion: 1,
|
|
title: "Bad",
|
|
}),
|
|
);
|
|
|
|
expect(() => loadEvidenceManifest(manifestPath)).toThrow(/escapes manifest directory/u);
|
|
});
|
|
});
|