diff --git a/packages/core/src/plugin/provider/openai.ts b/packages/core/src/plugin/provider/openai.ts index 111f66105a..013388aa55 100644 --- a/packages/core/src/plugin/provider/openai.ts +++ b/packages/core/src/plugin/provider/openai.ts @@ -176,6 +176,7 @@ export const OpenAIPlugin = define({ draft.method.update(browser) draft.method.update(headless) }) + yield* load() yield* ctx.catalog.transform((evt) => { for (const item of evt.provider.list()) { if (!ProviderV2.isAISDK(item.provider.package)) continue @@ -213,7 +214,6 @@ export const OpenAIPlugin = define({ Stream.runForEach(refresh), Effect.forkScoped({ startImmediately: true }), ) - yield* refresh().pipe(Effect.forkScoped) yield* ctx.aisdk.hook( "sdk", Effect.fn(function* (evt) { diff --git a/packages/core/src/plugin/provider/opencode.ts b/packages/core/src/plugin/provider/opencode.ts index 1d0488bdad..1e8c52e6fc 100644 --- a/packages/core/src/plugin/provider/opencode.ts +++ b/packages/core/src/plugin/provider/opencode.ts @@ -114,7 +114,7 @@ export const OpencodePlugin = define { for (const [providerID, item] of Object.entries(providers ?? {})) { catalog.provider.update(providerID, (provider) => { @@ -194,7 +194,6 @@ export const OpencodePlugin = define(value: T | undefined): T { return value } -function eventually( - effect: Effect.Effect, - predicate: (value: A) => boolean, - remaining = 1000, -): Effect.Effect { - return Effect.gen(function* () { - const value = yield* effect - if (predicate(value)) return value - if (remaining === 0) return yield* Effect.fail(new Error("Timed out waiting for value")) - yield* Effect.promise(() => Bun.sleep(1)) - return yield* eventually(effect, predicate, remaining - 1) - }) -} - function fakeSelectorSdk(calls: string[]) { const make = (method: string) => (id: string) => { calls.push(`${method}:${id}`) @@ -219,12 +205,7 @@ describe("OpenAIPlugin", () => { }) yield* addPlugin() - const eligible = required( - yield* eventually( - catalog.model.get(ProviderV2.ID.openai, ModelV2.ID.make("gpt-5.5")), - (model) => model?.cost.length === 0, - ), - ) + const eligible = required(yield* catalog.model.get(ProviderV2.ID.openai, ModelV2.ID.make("gpt-5.5"))) expect(eligible.enabled).toBe(true) expect(required(yield* catalog.model.get(ProviderV2.ID.openai, ModelV2.ID.make("gpt-5.5-pro"))).enabled).toBe( false, diff --git a/packages/core/test/plugin/provider-opencode.test.ts b/packages/core/test/plugin/provider-opencode.test.ts index 1de22a03dd..ad2be81d7c 100644 --- a/packages/core/test/plugin/provider-opencode.test.ts +++ b/packages/core/test/plugin/provider-opencode.test.ts @@ -1,6 +1,6 @@ import { describe, expect } from "bun:test" import { Money } from "@opencode-ai/schema/money" -import { Effect } from "effect" +import { Effect, Fiber, Stream } from "effect" import { Catalog } from "@opencode-ai/core/catalog" import { Credential } from "@opencode-ai/core/credential" import { EventV2 } from "@opencode-ai/core/event" @@ -31,20 +31,6 @@ function required(value: T | undefined): T { return value } -function eventually( - effect: Effect.Effect, - predicate: (value: A) => boolean, - remaining = 1000, -): Effect.Effect { - return Effect.gen(function* () { - const value = yield* effect - if (predicate(value)) return value - if (remaining === 0) return yield* Effect.fail(new Error("Timed out waiting for value")) - yield* Effect.promise(() => Bun.sleep(1)) - return yield* eventually(effect, predicate, remaining - 1) - }) -} - function withEnv(vars: Record, effect: () => Effect.Effect) { return Effect.acquireUseRelease( Effect.sync(() => { @@ -124,16 +110,22 @@ describe("OpencodePlugin", () => { Effect.gen(function* () { yield* addPlugin() const integrations = yield* Integration.Service + const events = yield* EventV2.Service const integrationID = Integration.ID.make("opencode") + const updated = yield* events.subscribe(Integration.Event.ConnectionUpdated).pipe( + Stream.filter((event) => event.data.integrationID === integrationID), + Stream.runHead, + Effect.forkScoped({ startImmediately: true }), + ) const attempt = yield* integrations.oauth.connect({ integrationID, methodID: Integration.MethodID.make("device"), inputs: { server: `${server.url.origin}/console///?ignored=true#ignored` }, }) expect(attempt.url).toBe(`${server.url.origin}/verify`) - yield* eventually( - integrations.oauth.status({ integrationID, attemptID: attempt.attemptID }), - (status) => status.status === "complete", + yield* Fiber.join(updated) + expect((yield* integrations.oauth.status({ integrationID, attemptID: attempt.attemptID })).status).toBe( + "complete", ) expect(requests).toContain("POST /console/auth/device/code")