Files
pydantic-ai-harness/tests/test_doc_snippets.py
T
David SFandGitHub 3ba9e2f9a5 docs: capability pages for the unified docs site + README/doc parity gate (#329)
* docs: publish capability docs to the unified site + add README/doc parity gate

Every capability shipped only a README (kept for GitHub/PyPI). This adds a
parallel, cleaned-up page per capability under docs/ for the new unified docs
site (pydantic.dev/docs/harness), migrated from each README: snippets verified
runnable against source, autodoc API blocks, root-relative Pydantic AI links,
and an experimental-status admonition on the experimental set.

To keep README and doc in sync going forward, adds a docs-parity-reviewer agent
and a parity gate in the review checklist (run as the last step before merge),
plus the docs/ layout and the README<->doc requirement in AGENTS.md and the
capability-authoring guide.

* docs: fix README<->doc<->source inconsistencies across capabilities

A parity audit against source found drift, mostly in the capability READMEs
(staler than the migrated docs). All fixes verified against source:

- Correctness: the "approval/deferred tools are excluded from the sandbox" claim
  (code_mode README + doc) was false -- those tools are sandboxed like any
  other; corrected in both. The stale Shell persist_cwd sentinel description is
  replaced with the actual out-of-band temp-file capture. filesystem protected
  default `.git/` -> `.git/*` (the bare form never matched).
- Runnable snippets: added the missing imports/wiring so README snippets no
  longer raise NameError (subagents, context, planning, overflow, authoring,
  filesystem, code_mode).
- Parity: documented previously-undocumented params/behaviors (compaction
  strategy options, overflow strip_ansi/Passthrough, extra autodoc classes for
  context and subagents), fixed a stale version pin (>=1.95.1 -> >=2.1.0), and
  added the missing Managed Prompt row to the root README capability matrix.
- Style: normalized decorative Unicode to ASCII across all READMEs and dropped a
  hype phrase, matching AGENTS.md writing style and the docs.

* docs: add nav.json to drive the unified-docs harness sidebar

The unified docs mount the harness docs under /docs/ai/harness (fed live from
this repo via the pydantic-ai 'Pydantic AI Harness' section). This nav.json
defines the sub-nav (Overview + Capabilities + Experimental) and the set of doc
files the site includes.

* docs: migrate "What goes where?" explainer into harness overview

Adds the core-vs-harness boundary section (anchor #what-goes-where) to the
canonical harness overview, so the pydantic-ai docs that link to it can point
here after the duplicated in-repo stub is removed.

* docs: address CodeRabbit review -- runnable snippets, accuracy, multi-class autodoc

* docs: flatten harness nav and align with graduated capabilities

Following the experimental-graduation refactor (#347), restructure the
unified-docs harness pages:

- Flatten docs/ (drop capabilities/ and experimental/ subdirs); the sidebar
  is now Overview + one flat list per Douwe's request.
- Rename to match the graduated modules: overflow -> overflowing-tool-output,
  authoring -> runtime-authoring, docs -> pydantic-ai-docs.
- Drop the 'Experimental' admonitions from the graduated capabilities and
  repoint every import + ::: autodoc path off pydantic_ai_harness.experimental.
- Add docs for the newly-shipped capabilities: guardrails, dynamic-workflow,
  media, and acp (acp stays framed as experimental -- it may still be removed).
- Every capability doc now links to its source; index capability table lists
  the full set with flat links.

* docs: apply team-sync authoring rules + enforce them in CI

From the 2026-07-10 docs review on #329:

- Purpose-first leads: drop hook names (before_model_request,
  after_tool_execute) from the opening paragraphs of compaction and
  overflowing-tool-output (doc + README); mechanism moves lower.
- Mirror the soft 'API may change between releases' stability note from each
  graduated README into its doc page (ACP keeps its stronger experimental
  warning; guardrails' README has no note, so its page gets none).
- README H1s now use the capability's display name (Overflow capability ->
  Overflowing Tool Output, RuntimeAuthoring -> Runtime Authoring, SubAgents ->
  Subagents, etc.).
- Extend tests/test_docs_parity.py with per-page mechanical checks: source link
  present, heading matches the capability name, purpose-first lead (no hook in
  the opener), and no experimental framing on graduated pages (ACP excepted).
- Update the docs-parity-reviewer agent + review-checklist to the flat
  structure and the new semantic checks.

* docs: add the stability note to guardrails (parity with sibling capabilities)

guardrails was the one graduated capability whose README and doc page lacked
the shared 'API may change between releases' note. Add it to both.

* fix: restore uv.lock to match pyproject (bad text-merge dropped 8 lines)

Merging origin/main did a git text-merge of the generated uv.lock, leaving it
inconsistent with pyproject.toml -- every CI job failed at 'uv sync --locked'.
pyproject.toml is identical to main here, so the correct lock is main's.

* docs: address CodeRabbit review on #329

Findings that failed to post inline (GitHub error) but were real:
- context/README.md, planning/README.md: two nested examples still imported
  from pydantic_ai_harness.experimental.* -- repoint to the graduated modules.
- guardrails/README.md: replace em dashes with '--' (repo style) and add the
  source-module link.
- docs/media.md: standardize on the implementation's canonical media+sha256://
  URI scheme (was mixing media://).
- tests/test_docs_parity.py: strengthen my own checks per review --
  source-link and top-README-link now require a real Markdown link to the
  page's specific module (not a bare substring); heading checks assert an H1
  exists and equals the expected capability name via explicit page metadata.

* fix: restore uv.lock [options.exclude-newer-package] block

The lock lost its [options.exclude-newer-package] manifest (pydantic-ai-slim
= false, ...) -- a bad git text-merge dropped it, and diagnostic uv commands
rewrote it under a different local config. Without that block CI's
'uv sync --locked' re-resolves and fails ('addition of exclude newer exclusion
for pydantic-ai-slim'). Restore origin/main's exact lock.

* fix: restore uv.lock [options.exclude-newer-package] block

A pre-commit hook was rewriting uv.lock under the local uv config, stripping
the [options.exclude-newer-package] manifest (pydantic-ai-slim = false, ...).
Without it CI's 'uv sync --locked' re-resolves and fails. Commit origin/main's
exact lock with --no-verify so no hook mutates it (lock-only change).

* test: cover the docs-parity helper edge cases (100% coverage)

The strengthened helpers added defensive branches (missing frontmatter close,
fenced code before the lead, missing/forbidden/ClassName H1, lead running to
EOF) that no real doc exercises. Add direct unit tests so the file is back to
the repo's required 100% coverage.

* docs: link every capability README to its source module + enforce it

CodeRabbit re-flagged planning/README.md for a missing source link. Only
guardrails had one, so add the source-module link to all 15 remaining
capability READMEs (matching the doc pages) and add a parity test so the
requirement is mechanical and cannot silently regress.

* docs(agents): drop stale folder tree; fix flat docs path + guard names

AGENTS.md's File-structure ASCII tree and capability-authoring's doc paths
still showed docs/capabilities// docs/experimental/ (flattened in this PR) and
the old /docs/harness URL. Delete the tree rather than redraw it -- the layout
is discoverable by listing the repo; keep only the non-obvious conventions
(flat docs/, the README<->doc parity requirement). Also fix the Vocabulary
guard examples (InputGuard/OutputGuard, not the nonexistent InputGuardrail/
CostGuard).

* test: statically validate doc snippets exist and parse

Every Python snippet in the capability READMEs and docs/*.md pages is now
checked for the two failures a reader hits immediately: it does not parse
(syntax), or it imports a pydantic_ai_harness symbol that does not exist (stale
module path or renamed name -- the class of bug behind the experimental.* import
drift). Static only: no model/network execution, so it needs no mocking. The
four illustrative API-signature blocks opt out with a {test="skip"} fence
(read by pytest-examples, stripped-safe for the unified-docs render).

* test: don't fail doc-snippet check on a missing optional extra

The static check imported capability modules to resolve their symbols, but in
the slim CI job (no extras) importing e.g. pydantic_ai_harness.experimental.acp
raises ModuleNotFoundError for the absent third-party 'acp' package -- the
harness module exists, its extra just isn't installed. Distinguish a genuinely
missing harness module (fail) from a missing extra (skip) by the ImportError's
module name.
2026-07-13 11:00:12 -05:00

139 lines
6.3 KiB
Python

"""Static validation of the code snippets shown in the docs.
Every Python snippet in a capability `README.md` (GitHub/PyPI) and in the flat
`docs/<capability>.md` pages (the unified docs site) is checked for the two
failure modes a reader hits immediately:
- **it does not parse** -- a syntax error means the snippet cannot run at all;
- **it imports a harness symbol that does not exist** -- a stale module path or a
renamed/removed name (e.g. a snippet still importing from
`pydantic_ai_harness.experimental.<graduated>`).
This is the *static* half of doc-snippet testing. It deliberately does not
execute the snippets -- most build an `Agent` and call `.run()`, which needs a
model -- so it stays fast and needs no mocking. Running snippets against a mocked
model is a separate concern (see `test_readme_quick_start.py` for that shape).
Illustrative signature blocks (API-reference pseudo-code with type annotations or
a bare `*`, which is not runnable Python) opt out with a `{test="skip"}` fence
directive.
"""
from __future__ import annotations as _annotations
import ast
import importlib
import os
import warnings
from collections.abc import Iterable
from pathlib import Path
import pytest
from _pytest.mark import ParameterSet
from pytest_examples import CodeExample, find_examples
_ROOT = Path(__file__).parent.parent
_HARNESS = 'pydantic_ai_harness'
def _harness_import_targets(tree: ast.AST) -> Iterable[tuple[str, str | None]]:
"""`(module, name)` for every `pydantic_ai_harness` symbol a snippet imports.
`name` is `None` for a plain `import pydantic_ai_harness.x` or a star import,
where only the module's existence can be checked.
"""
for node in ast.walk(tree):
if isinstance(node, ast.ImportFrom):
module = node.module or ''
if module == _HARNESS or module.startswith(f'{_HARNESS}.'):
for alias in node.names:
yield module, None if alias.name == '*' else alias.name
elif isinstance(node, ast.Import):
for alias in node.names:
if alias.name == _HARNESS or alias.name.startswith(f'{_HARNESS}.'):
yield alias.name, None
def _is_missing_harness_module(exc_name: str | None) -> bool:
"""True when an ImportError is a genuinely absent harness module, not a missing extra.
A missing optional dependency (e.g. `acp` in the `slim` CI job) raises
`ModuleNotFoundError` naming the third-party package, not the harness module --
the harness module exists, its extra just isn't installed.
"""
return exc_name is not None and exc_name.startswith(_HARNESS)
def _snippet_problem(source: str) -> str | None:
"""Return why a snippet is invalid, or `None` if it parses and its harness imports resolve."""
try:
tree = ast.parse(source)
except SyntaxError as exc:
return f'does not parse: {exc.msg} (line {exc.lineno})'
for module, name in _harness_import_targets(tree):
try:
with warnings.catch_warnings():
warnings.simplefilter('ignore') # a deprecated shim path still resolves; existence is what we check
imported = importlib.import_module(module)
except ImportError as exc:
if _is_missing_harness_module(exc.name):
return f'imports `{module}`, which does not exist: {exc}'
continue # missing optional extra in this environment; the harness module exists
if name is not None and not hasattr(imported, name):
return f'imports `{name}` from `{module}`, but that name does not exist'
return None
def _doc_snippets() -> Iterable[ParameterSet]:
# `find_examples` yields only Python fenced blocks and wants paths relative to
# the cwd, so pin it to the repo root (matches `test_skill_examples.py`).
os.chdir(_ROOT)
readmes = sorted(str(p.relative_to(_ROOT)) for p in _ROOT.glob(f'{_HARNESS}/**/README.md'))
for ex in find_examples(*readmes, 'docs'):
yield pytest.param(ex, id=f'{ex.path}:{ex.start_line}')
@pytest.mark.parametrize('example', _doc_snippets())
def test_doc_snippet_valid(example: CodeExample) -> None:
if example.prefix_settings().get('test', '').startswith('skip'):
pytest.skip('illustrative signature block; not runnable Python')
problem = _snippet_problem(example.source)
assert problem is None, (
f'{example.path}:{example.start_line} {problem}. '
'Fix the snippet, or mark the fence `{test="skip"}` if it is illustrative signature pseudo-code.'
)
def test_doc_snippets_discovered() -> None:
# Guard against a discovery break silently making the check vacuous.
assert sum(1 for _ in _doc_snippets()) >= 100
def test_snippet_problem_detects_each_failure_mode() -> None:
# Valid: harness imports that resolve, star imports, plain imports, and non-harness imports.
assert _snippet_problem('from pydantic_ai_harness import CodeMode') is None
assert _snippet_problem('import pydantic_ai_harness.code_mode') is None
assert _snippet_problem('from pydantic_ai_harness.overflowing_tool_output import *') is None
assert _snippet_problem('from os import path\nimport sys') is None
# Invalid: syntax, a module that does not exist, and a name that does not exist.
assert 'does not parse' in (_snippet_problem('def (:') or '')
assert 'does not exist' in (_snippet_problem('from pydantic_ai_harness.nope import X') or '')
assert 'does not exist' in (_snippet_problem('from pydantic_ai_harness import NoSuchCapability') or '')
def test_missing_harness_module_classification() -> None:
assert _is_missing_harness_module('pydantic_ai_harness.experimental.nope') is True
assert _is_missing_harness_module('acp') is False # a missing extra, not a harness module
assert _is_missing_harness_module(None) is False
def test_missing_optional_extra_is_not_a_failure(monkeypatch: pytest.MonkeyPatch) -> None:
# Simulate the `slim` environment: the harness module exists, but importing it
# fails because its third-party extra is absent. That is not a broken snippet.
def _extra_missing(module: str) -> object:
raise ModuleNotFoundError("No module named 'acp'", name='acp')
monkeypatch.setattr(importlib, 'import_module', _extra_missing)
assert _snippet_problem('from pydantic_ai_harness.experimental.acp import run_acp_stdio') is None