mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-05-26 18:06:00 +00:00
AochenShen99
e344be8d94
* feat(tests): add Blockbuster runtime gate for event-loop blocking IO Adds a strict runtime gate that fails CI when sync blocking IO calls run on the asyncio event loop thread through DeerFlow business code. Components: - backend/tests/support/detectors/blocking_io_runtime.py — Blockbuster context scoped to `app.*` and `deerflow.*` so test infrastructure, pytest internals, and third-party libraries stay silent. - backend/tests/blocking_io/conftest.py — pytest_runtest_protocol hookwrapper that wraps every item (setup + call + teardown) with the strict context. Respects `@pytest.mark.allow_blocking_io` opt-out. - backend/tests/blocking_io/test_skills_load.py — regression anchor for the #1917 fix (asyncio.to_thread offload around LocalSkillStorage.load_skills). - backend/tests/blocking_io/test_sqlite_lifespan.py — regression anchor for the #1912 fix (asyncio.to_thread offload around ensure_sqlite_parent_dir). - backend/tests/blocking_io/test_gate_smoke.py — meta-test asserting the gate actually catches unoffloaded blocking IO and that the `@pytest.mark.allow_blocking_io` opt-out works. - backend/Makefile — `make test-blocking-io` target. - .github/workflows/backend-blocking-io-tests.yml — hard-fail PR gate on ubuntu-latest. Windows matrix deferred to follow-up. Dependencies: - blockbuster>=1.5.26,<1.6 added to dev group. Coverage boundary (called out in PR body): the gate only catches blocking IO on code paths the test suite actually exercises. Static AST inventory (separate, informational) is the complementary coverage tool. Three blind spot categories — untested paths, mocked-away paths, env-mismatched paths — are documented in the PR description. Findings surfaced while authoring this PR: - resolve_sqlite_conn_str in runtime/store/_sqlite_utils.py:19 does sync Path.resolve() -> os.path.abspath on the lifespan loop thread, ahead of the #1912 fix. Not addressed here; tracked as follow-up. Tests: 4 passed locally (`make test-blocking-io`). Lint/format: clean (`ruff check` and `ruff format --check`). * fix(tests): scope Blockbuster gate to blocking-io suite * fix(tests): harden Blockbuster runtime gate * test(blocking-io): add project rule extension point * test(blocking-io): address review cleanup
38 lines
1.3 KiB
Python
38 lines
1.3 KiB
Python
"""Pytest conftest for the strict Blockbuster runtime gate.
|
|
|
|
Activates `detect_blocking_io_strict()` around the entire pytest item
|
|
protocol (setup + call + teardown) so blocking IO in async fixtures and
|
|
lifespan code is also caught, not just blocking IO inside the test body.
|
|
|
|
Scope: only applies to items whose path is under `backend/tests/blocking_io/`.
|
|
Pytest registers conftest hookwrappers globally once the file is loaded,
|
|
so an explicit path filter is required to keep the strict gate from
|
|
firing on unrelated tests when the full suite is collected.
|
|
|
|
Opt-out: mark a test with `@pytest.mark.allow_blocking_io` to skip the gate.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from collections.abc import Generator
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
from support.detectors.blocking_io_runtime import detect_blocking_io_strict
|
|
|
|
_BLOCKING_IO_TEST_ROOT = Path(__file__).resolve().parent
|
|
|
|
|
|
@pytest.hookimpl(hookwrapper=True)
|
|
def pytest_runtest_protocol(item: pytest.Item, nextitem: pytest.Item | None) -> Generator[None, None, None]:
|
|
if not _is_blocking_io_item(item) or item.get_closest_marker("allow_blocking_io") is not None:
|
|
yield
|
|
return
|
|
|
|
with detect_blocking_io_strict():
|
|
yield
|
|
|
|
|
|
def _is_blocking_io_item(item: pytest.Item) -> bool:
|
|
return Path(item.path).resolve().is_relative_to(_BLOCKING_IO_TEST_ROOT)
|