mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-05-26 18:06:00 +00:00
AochenShen99
e344be8d94
* feat(tests): add Blockbuster runtime gate for event-loop blocking IO Adds a strict runtime gate that fails CI when sync blocking IO calls run on the asyncio event loop thread through DeerFlow business code. Components: - backend/tests/support/detectors/blocking_io_runtime.py — Blockbuster context scoped to `app.*` and `deerflow.*` so test infrastructure, pytest internals, and third-party libraries stay silent. - backend/tests/blocking_io/conftest.py — pytest_runtest_protocol hookwrapper that wraps every item (setup + call + teardown) with the strict context. Respects `@pytest.mark.allow_blocking_io` opt-out. - backend/tests/blocking_io/test_skills_load.py — regression anchor for the #1917 fix (asyncio.to_thread offload around LocalSkillStorage.load_skills). - backend/tests/blocking_io/test_sqlite_lifespan.py — regression anchor for the #1912 fix (asyncio.to_thread offload around ensure_sqlite_parent_dir). - backend/tests/blocking_io/test_gate_smoke.py — meta-test asserting the gate actually catches unoffloaded blocking IO and that the `@pytest.mark.allow_blocking_io` opt-out works. - backend/Makefile — `make test-blocking-io` target. - .github/workflows/backend-blocking-io-tests.yml — hard-fail PR gate on ubuntu-latest. Windows matrix deferred to follow-up. Dependencies: - blockbuster>=1.5.26,<1.6 added to dev group. Coverage boundary (called out in PR body): the gate only catches blocking IO on code paths the test suite actually exercises. Static AST inventory (separate, informational) is the complementary coverage tool. Three blind spot categories — untested paths, mocked-away paths, env-mismatched paths — are documented in the PR description. Findings surfaced while authoring this PR: - resolve_sqlite_conn_str in runtime/store/_sqlite_utils.py:19 does sync Path.resolve() -> os.path.abspath on the lifespan loop thread, ahead of the #1912 fix. Not addressed here; tracked as follow-up. Tests: 4 passed locally (`make test-blocking-io`). Lint/format: clean (`ruff check` and `ruff format --check`). * fix(tests): scope Blockbuster gate to blocking-io suite * fix(tests): harden Blockbuster runtime gate * test(blocking-io): add project rule extension point * test(blocking-io): address review cleanup
53 lines
2.0 KiB
Python
53 lines
2.0 KiB
Python
"""Regression test: sqlite path setup must run off the event loop.
|
|
|
|
Anchors the production offload from
|
|
`runtime/checkpointer/async_provider.py:_async_checkpointer`, where SQLite
|
|
path resolution and `ensure_sqlite_parent_dir` are dispatched via
|
|
`await asyncio.to_thread(...)`.
|
|
That fix addressed #1912, where the sync `Path.mkdir` / `os.mkdir` inside
|
|
`ensure_sqlite_parent_dir` ran on the FastAPI lifespan event loop thread
|
|
and blocked startup.
|
|
|
|
This test invokes the production `_async_checkpointer()` path under the
|
|
strict Blockbuster context. The target path's parent does not yet exist, so
|
|
the underlying path resolution and `os.mkdir` both execute. If either step is
|
|
regressed to run directly on the event loop, Blockbuster raises
|
|
`BlockingError` and this test fails.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import sys
|
|
from pathlib import Path
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
pytestmark = pytest.mark.asyncio
|
|
|
|
|
|
async def test_async_checkpointer_sqlite_setup_does_not_block_event_loop(tmp_path: Path) -> None:
|
|
from deerflow.config.checkpointer_config import CheckpointerConfig
|
|
from deerflow.runtime.checkpointer.async_provider import _async_checkpointer
|
|
|
|
db_file = tmp_path / "subdir" / "store.db"
|
|
|
|
mock_saver = AsyncMock()
|
|
mock_context_manager = AsyncMock()
|
|
mock_context_manager.__aenter__.return_value = mock_saver
|
|
mock_context_manager.__aexit__.return_value = False
|
|
|
|
mock_saver_cls = MagicMock()
|
|
mock_saver_cls.from_conn_string.return_value = mock_context_manager
|
|
|
|
mock_module = MagicMock()
|
|
mock_module.AsyncSqliteSaver = mock_saver_cls
|
|
|
|
with patch.dict(sys.modules, {"langgraph.checkpoint.sqlite.aio": mock_module}):
|
|
async with _async_checkpointer(CheckpointerConfig(type="sqlite", connection_string=str(db_file))) as saver:
|
|
assert saver is mock_saver
|
|
|
|
assert db_file.parent.exists()
|
|
mock_saver_cls.from_conn_string.assert_called_once_with(str(db_file.resolve()))
|
|
mock_saver.setup.assert_awaited_once()
|