mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-06-13 10:55:59 +00:00
aa015462a7
* Add user-owned IM channel connections * Fix dev startup and channel connect popup * Use async channel connect flow * Harden dev service daemon startup * Support local IM channel connections * Align IM connections with local channels * Fix safe user id digest algorithm * Address Copilot IM channel feedback * Address IM channel review comments * Support all integrated IM channel connections * Format additional channel connection tests * Keep unavailable channel connect buttons clickable * Fix IM channel provider icons * Add runtime setup for enabled IM channels * Guard global shortcut key handling * Keep configured IM channels editable * Avoid password autofill for channel secrets * Make channel threads visible to connection owners * Persist IM runtime config locally * Allow disconnecting runtime IM channels * Route no-auth channel sessions to local user * Use default user for auth-disabled local mode * Show IM channel source on threads * Prefill IM channel runtime config * Reflect IM channel runtime health * Ignore Feishu message read events * Ignore Feishu non-content message events * Let setup wizard enable IM channels * Fix frontend formatting after merge * Stabilize backend tests without local config * Isolate channel runtime config tests * Address channel connection review comments * Use sha256 user buckets with legacy migration * Ensure runtime IM channels are ready after restart * Persist disconnected IM channel state * Address channel connection review comments * Address channel connection review findings Frontend connect flow: - Open the runtime-config dialog only when a provider still needs credentials; configured providers go straight to the connect flow, so the binding-code/deep-link path is reachable from the UI again. - After saving credentials, continue into the connect flow when a user binding is still required (multi-user mode) instead of stopping at a "Connected" toast. - Extract shared provider-state helpers to core/channels/provider-state and add unit + e2e coverage for the direct-connect and configure-then-connect paths. Provider status semantics: - Report connection_status from the user's newest connection row; with no binding it is not_connected, except in auth-disabled local mode where a configured running channel is effectively connected. Concurrency and event-loop correctness: - Offload ChannelRuntimeConfigStore construction and writes, channel service construction, and Slack connection replies to threads; add a tests/blocking_io/ anchor for the runtime-config handlers. - Consume binding codes with a conditional UPDATE so a code can only be used once under concurrent workers; retry upsert_connection as an update when a concurrent insert wins the unique constraint. - Serialize ensure_channel_ready per channel so concurrent provider polls cannot double-start a channel worker. Config and migration hardening: - Stop mutating the get_app_config()-cached Telegram provider config; the runtime store now owns the UI-entered bot username. - Register channel_connections in STARTUP_ONLY_FIELDS with the standardized startup-only Field description. - Match the legacy unsafe-id bucket by recomputing its exact SHA-1 name so another user's same-prefix bucket can never be migrated. - Remove the unused Telegram process_webhook_update path and document src/core/channels in the frontend docs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Address PR review comments on authz scoping and channel runtime Security (review feedback from ShenAC-SAC): - Scope internal-token callers to the connection owner carried in X-DeerFlow-Owner-User-Id instead of bypassing owner checks outright, in both require_permission(owner_check=True) and the stateless run endpoints. Internal callers keep access to their own and shared/legacy threads, and may claim a default-owned channel thread for its real owner, but a leaked internal token no longer grants cross-user thread access. - Require admin privileges for POST/DELETE /api/channels/{provider}/ runtime-config: runtime credentials and channel workers are instance-wide shared state (same model as the MCP config API). Read-only provider listing stays available to all users. Performance (review feedback from willem-bd): - Skip the redundant thread channel-metadata PATCH after the first successful backfill per thread. - Reuse the per-connection Slack WebClient until its token changes instead of constructing one per outbound message. - Reconcile channel readiness for all providers concurrently in GET /api/channels/providers. Also resolve the code-quality unused-import flag in the blocking-io anchor by pre-importing the channel service via importlib. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Fix prettier formatting in provider-state test Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Reconcile UI runtime channel config with config reload on restart Main now reloads a channel's config.yaml entry on restart_channel() (#3514, issue #3497). Adapt the user-owned connection flow to coexist: - configure_channel() restarts with reload_config=False — the caller just supplied the authoritative config (browser-entered credentials that are never written to config.yaml), so a file reload must not clobber it with the stale on-disk entry. - _load_channel_config() re-applies the UI runtime-store overlay used at startup, so an operator-triggered restart keeps browser-entered credentials for channels without a config.yaml entry and does not resurrect a channel disconnected from the UI. - Offload the reload's disk IO (config.yaml + runtime store) with asyncio.to_thread, matching the blocking-IO policy on this branch. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
301 lines
9.1 KiB
TypeScript
301 lines
9.1 KiB
TypeScript
import { expect, test, type Route } from "@playwright/test";
|
|
|
|
import {
|
|
mockLangGraphAPI,
|
|
MOCK_THREAD_ID,
|
|
MOCK_THREAD_ID_2,
|
|
} from "./utils/mock-api";
|
|
|
|
const THREADS = [
|
|
{
|
|
thread_id: MOCK_THREAD_ID,
|
|
title: "First conversation",
|
|
updated_at: "2025-06-01T12:00:00Z",
|
|
},
|
|
{
|
|
thread_id: MOCK_THREAD_ID_2,
|
|
title: "Second conversation",
|
|
updated_at: "2025-06-02T12:00:00Z",
|
|
},
|
|
];
|
|
const DEMO_THREAD_ID = "7cfa5f8f-a2f8-47ad-acbd-da7137baf990";
|
|
const SVG_PROMPT_THREAD_ID = "00000000-0000-0000-0000-000000000777";
|
|
const SVG_PROMPT_MARKER = "LEAK-STRICT-SVG-PROMPT-SHOULD-DISAPPEAR";
|
|
const OPTIMISTIC_PROMPT_MARKER = "LEAK-OPTIMISTIC-SVG-PROMPT-SHOULD-DISAPPEAR";
|
|
|
|
test.describe("Thread history", () => {
|
|
test("sidebar shows existing threads", async ({ page }) => {
|
|
mockLangGraphAPI(page, { threads: THREADS });
|
|
|
|
await page.goto("/workspace/chats/new");
|
|
|
|
// Both thread titles should appear in the sidebar
|
|
await expect(page.getByText("First conversation")).toBeVisible({
|
|
timeout: 15_000,
|
|
});
|
|
await expect(page.getByText("Second conversation")).toBeVisible();
|
|
});
|
|
|
|
test("clicking a thread in sidebar navigates to it", async ({ page }) => {
|
|
mockLangGraphAPI(page, { threads: THREADS });
|
|
|
|
await page.goto("/workspace/chats/new");
|
|
|
|
// Wait for sidebar to populate
|
|
const firstThread = page.getByText("First conversation");
|
|
await expect(firstThread).toBeVisible({ timeout: 15_000 });
|
|
|
|
// Click on the first thread
|
|
await firstThread.click();
|
|
|
|
// Should navigate to that thread's URL
|
|
await page.waitForURL(`**/workspace/chats/${MOCK_THREAD_ID}`);
|
|
await expect(page).toHaveURL(new RegExp(MOCK_THREAD_ID));
|
|
});
|
|
|
|
test("existing thread loads historical messages", async ({ page }) => {
|
|
mockLangGraphAPI(page, { threads: THREADS });
|
|
|
|
// Navigate directly to an existing thread
|
|
await page.goto(`/workspace/chats/${MOCK_THREAD_ID}`);
|
|
|
|
// The historical AI response should be displayed
|
|
await expect(
|
|
page.getByText("Response in thread First conversation"),
|
|
).toBeVisible({ timeout: 15_000 });
|
|
});
|
|
|
|
test("new chat does not show previous thread messages after client-side navigation", async ({
|
|
page,
|
|
}) => {
|
|
mockLangGraphAPI(page, {
|
|
threads: [
|
|
{
|
|
thread_id: SVG_PROMPT_THREAD_ID,
|
|
title: "SVG artifact prompt",
|
|
updated_at: "2025-06-03T12:00:00Z",
|
|
messages: [
|
|
{
|
|
type: "human",
|
|
id: "msg-human-svg-prompt",
|
|
content: [
|
|
{
|
|
type: "text",
|
|
text: `请严格执行:\n1. 使用 write_file 创建 /mnt/user-data/outputs/shared.svg,内容包含 ${SVG_PROMPT_MARKER}\n2. 最终回复只输出 Markdown 图片。`,
|
|
},
|
|
],
|
|
},
|
|
{
|
|
type: "ai",
|
|
id: "msg-ai-svg-prompt",
|
|
content: "",
|
|
},
|
|
],
|
|
},
|
|
],
|
|
});
|
|
|
|
await page.goto(`/workspace/chats/${SVG_PROMPT_THREAD_ID}`);
|
|
await expect(page.getByText(SVG_PROMPT_MARKER)).toBeVisible({
|
|
timeout: 15_000,
|
|
});
|
|
|
|
await page.getByRole("link", { name: /new chat/i }).click();
|
|
await page.waitForURL("**/workspace/chats/new");
|
|
|
|
await expect(page.getByText(SVG_PROMPT_MARKER)).toBeHidden();
|
|
await expect(page.getByPlaceholder(/how can i assist you/i)).toBeVisible();
|
|
});
|
|
|
|
test("new chat does not show previous optimistic user message after client-side navigation", async ({
|
|
page,
|
|
}) => {
|
|
mockLangGraphAPI(page, {
|
|
threads: [
|
|
{
|
|
thread_id: MOCK_THREAD_ID_2,
|
|
title: "Destination conversation",
|
|
updated_at: "2025-06-04T12:00:00Z",
|
|
},
|
|
],
|
|
});
|
|
|
|
const metadataOnlyStream = async (route: Route) => {
|
|
const body = [
|
|
{
|
|
event: "metadata",
|
|
data: {
|
|
run_id: "00000000-0000-0000-0000-000000000778",
|
|
thread_id: MOCK_THREAD_ID,
|
|
},
|
|
},
|
|
{ event: "end", data: {} },
|
|
]
|
|
.map((e) => `event: ${e.event}\ndata: ${JSON.stringify(e.data)}\n\n`)
|
|
.join("");
|
|
|
|
await route.fulfill({
|
|
status: 200,
|
|
contentType: "text/event-stream",
|
|
body,
|
|
});
|
|
};
|
|
|
|
await page.route("**/api/langgraph/runs/stream", metadataOnlyStream);
|
|
await page.route(
|
|
"**/api/langgraph/threads/*/runs/stream",
|
|
metadataOnlyStream,
|
|
);
|
|
|
|
await page.goto("/workspace/chats/new");
|
|
const textarea = page.getByPlaceholder(/how can i assist you/i);
|
|
await expect(textarea).toBeVisible({ timeout: 15_000 });
|
|
await textarea.fill(
|
|
`请严格执行:使用 write_file 创建 shared.svg,内容包含 ${OPTIMISTIC_PROMPT_MARKER}。`,
|
|
);
|
|
await textarea.press("Enter");
|
|
|
|
await expect(page.getByText(OPTIMISTIC_PROMPT_MARKER)).toBeVisible();
|
|
|
|
await page.getByText("Destination conversation").click();
|
|
await page.waitForURL(`**/workspace/chats/${MOCK_THREAD_ID_2}`);
|
|
await expect(page.getByText(OPTIMISTIC_PROMPT_MARKER)).toHaveCount(0);
|
|
|
|
await page.getByRole("link", { name: /new chat/i }).click();
|
|
await page.waitForURL("**/workspace/chats/new");
|
|
|
|
await expect(page.getByText(OPTIMISTIC_PROMPT_MARKER)).toHaveCount(0);
|
|
await expect(page.getByPlaceholder(/how can i assist you/i)).toBeVisible();
|
|
});
|
|
|
|
test("mock thread does not load real backend run history", async ({
|
|
page,
|
|
}) => {
|
|
mockLangGraphAPI(page, {
|
|
threads: [
|
|
{
|
|
thread_id: DEMO_THREAD_ID,
|
|
title: "Forecasting 2026 Trends and Opportunities",
|
|
updated_at: "2025-06-01T12:00:00Z",
|
|
messages: [
|
|
{
|
|
type: "human",
|
|
id: `run-human-${DEMO_THREAD_ID}`,
|
|
content: [
|
|
{
|
|
type: "text",
|
|
text: "This run-message endpoint should not be called.",
|
|
},
|
|
],
|
|
},
|
|
],
|
|
},
|
|
],
|
|
});
|
|
const backendRunHistoryUrls: string[] = [];
|
|
await page.route(
|
|
/\/api\/langgraph\/threads\/[^/]+\/runs(?:\?|$)/,
|
|
(route) => {
|
|
if (
|
|
route.request().method() === "GET" &&
|
|
route
|
|
.request()
|
|
.url()
|
|
.includes(`/api/langgraph/threads/${DEMO_THREAD_ID}/runs`)
|
|
) {
|
|
backendRunHistoryUrls.push(route.request().url());
|
|
return route.fulfill({
|
|
status: 500,
|
|
contentType: "application/json",
|
|
body: JSON.stringify({
|
|
error: "mock=true must not load real runs",
|
|
}),
|
|
});
|
|
}
|
|
return route.fallback();
|
|
},
|
|
);
|
|
await page.route(
|
|
/\/api\/threads\/[^/]+\/runs\/[^/]+\/messages(?:\?|$)/,
|
|
(route) => {
|
|
if (
|
|
route.request().method() === "GET" &&
|
|
route.request().url().includes(`/api/threads/${DEMO_THREAD_ID}/runs/`)
|
|
) {
|
|
backendRunHistoryUrls.push(route.request().url());
|
|
return route.fulfill({
|
|
status: 500,
|
|
contentType: "application/json",
|
|
body: JSON.stringify({
|
|
error: "mock=true must not load real run messages",
|
|
}),
|
|
});
|
|
}
|
|
return route.fallback();
|
|
},
|
|
);
|
|
|
|
await page.goto(`/workspace/chats/${DEMO_THREAD_ID}?mock=true`);
|
|
|
|
await expect(
|
|
page.getByText("What might be the trends and opportunities in 2026?"),
|
|
).toBeVisible({ timeout: 15_000 });
|
|
await expect(
|
|
page.getByText("I've created a modern, minimalist website"),
|
|
).toBeVisible();
|
|
expect(backendRunHistoryUrls).toEqual([]);
|
|
});
|
|
|
|
test("chats list page shows all threads", async ({ page }) => {
|
|
mockLangGraphAPI(page, { threads: THREADS });
|
|
|
|
await page.goto("/workspace/chats");
|
|
|
|
// Both threads should be listed in the main content area
|
|
const main = page.locator("main");
|
|
await expect(main.getByText("First conversation")).toBeVisible({
|
|
timeout: 15_000,
|
|
});
|
|
await expect(main.getByText("Second conversation")).toBeVisible();
|
|
});
|
|
|
|
test("IM channel threads show their source in thread lists", async ({
|
|
page,
|
|
}) => {
|
|
mockLangGraphAPI(page, {
|
|
threads: [
|
|
{
|
|
thread_id: MOCK_THREAD_ID,
|
|
title: "Feishu conversation",
|
|
updated_at: "2025-06-03T12:00:00Z",
|
|
metadata: {
|
|
channel_source: {
|
|
type: "im_channel",
|
|
provider: "feishu",
|
|
chat_id: "oc_mock",
|
|
},
|
|
},
|
|
},
|
|
],
|
|
});
|
|
|
|
await page.goto("/workspace/chats/new");
|
|
|
|
const sidebarThread = page.locator(
|
|
`a[href='/workspace/chats/${MOCK_THREAD_ID}']`,
|
|
);
|
|
await expect(sidebarThread).toBeVisible({ timeout: 15_000 });
|
|
await expect(sidebarThread.getByLabel("Feishu channel")).toBeVisible();
|
|
|
|
await page.goto("/workspace/chats");
|
|
|
|
const mainThread = page
|
|
.locator("main")
|
|
.locator(`a[href='/workspace/chats/${MOCK_THREAD_ID}']`);
|
|
await expect(mainThread.getByText("Feishu conversation")).toBeVisible({
|
|
timeout: 15_000,
|
|
});
|
|
await expect(mainThread.getByText("Feishu", { exact: true })).toBeVisible();
|
|
});
|
|
});
|