mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-05-21 15:36:48 +00:00
df95154282
* fix(tracing): propagate session_id and user_id into Langfuse traces
Adds Langfuse v4 reserved trace attributes (langfuse_session_id,
langfuse_user_id, langfuse_trace_name, langfuse_tags) to
RunnableConfig.metadata inside the run worker, so the langchain
CallbackHandler can lift them onto the root trace.
- New deerflow.tracing.metadata.build_langfuse_trace_metadata() returns
the reserved keys when Langfuse is in the enabled providers, else {}.
- worker.run_agent merges them with setdefault so caller-supplied keys
win, allowing per-request overrides from upstream metadata.
- session_id mirrors the LangGraph thread_id; user_id reads
get_effective_user_id() (falls back to "default" in no-auth mode).
- trace_name defaults to "lead-agent"; tags carry env and model name
when DEER_FLOW_ENV (or ENVIRONMENT) and a model name are present.
Closes #2930
* fix(tracing): attach Langfuse callback at graph root so metadata propagates
The first commit injected ``langfuse_session_id`` / ``langfuse_user_id`` /
``langfuse_trace_name`` / ``langfuse_tags`` into ``RunnableConfig.metadata``,
but on ``main`` the Langfuse callback is attached at *model* level
(``models/factory.py``). LangChain still threads ``parent_run_id`` through
the contextvar, so the handler sees the model as a nested observation and
``__on_llm_action`` strips the ``langfuse_*`` keys
(``keep_langfuse_trace_attributes=False``). The trace's top-level
``sessionId`` / ``userId`` therefore stayed empty in deer-flow's LangGraph
runtime — confirmed live against a real Langfuse instance.
This commit moves the callback to the **graph invocation root** so the
handler fires ``on_chain_start(parent_run_id=None)`` and runs the
``propagate_attributes`` path that actually lifts ``session_id`` /
``user_id`` onto the trace:
- ``models/factory.py``: add ``attach_tracing`` keyword (default ``True``)
so standalone callers (``MemoryUpdater``, etc.) keep their direct
model-level tracing.
- ``agents/lead_agent/agent.py``: call ``build_tracing_callbacks()`` once
inside ``_make_lead_agent`` and append the result to
``config["callbacks"]``; the four in-graph ``create_chat_model`` sites
(bootstrap, default agent, sync + async summarization) pass
``attach_tracing=False`` to avoid duplicate spans.
- ``agents/middlewares/title_middleware.py``: same ``attach_tracing=False``
for the title-generation model, since it inherits the graph's
RunnableConfig via ``_get_runnable_config``.
Test updates:
- ``tests/test_lead_agent_model_resolution.py`` and
``tests/test_title_middleware_core_logic.py``: extend the fake
``create_chat_model`` signatures / mock assertions to accept the new
``attach_tracing`` kwarg.
- ``tests/test_worker_langfuse_metadata.py``: switch the no-user fallback
test from direct ContextVar mutation to ``monkeypatch.setattr`` on
``get_effective_user_id`` to avoid pollution across the langfuse OTel
global tracer provider.
- ``tests/conftest.py``: add an autouse fixture that resets
``deerflow.config.title_config._title_config`` to its pristine default
after every test. Any test that loads the real ``config.yaml`` (via
``get_app_config()``) calls ``load_title_config_from_dict`` and mutates
the module-level singleton, which previously poisoned the
title-middleware suite when run after, e.g., the new
``test_worker_langfuse_metadata.py`` cases. The fixture is independent
of this PR's main change but unblocks the cross-file test run.
Live verification (same Langfuse instance as before):
- Drove ``worker.run_agent`` against the real ``make_lead_agent`` +
``gpt-4o-mini`` for three distinct ``user_context`` identities
(``fancy-engineer``, ``alice-pm``, ``bob-designer``).
- Each run produced one ``lead-agent`` trace whose top-level
``sessionId`` / ``userId`` / ``tags`` carry the expected values, e.g.
``session=e2e-2930-8f347c-alice-pm user=alice-pm name='lead-agent'
tags=['model:gpt-4o-mini']``.
Refs #2930.
* fix(tracing): extend root-callback + metadata injection to the embedded client
Addresses Copilot review on PR #2944.
Commit 2 disabled model-level tracing for ``TitleMiddleware`` and
``_create_summarization_middleware`` because ``_make_lead_agent`` now
attaches the tracing callbacks at the graph invocation root. But the
embedded ``DeerFlowClient`` does not call ``_make_lead_agent`` — it
calls ``_build_middlewares`` directly and never appends the tracing
handlers to its ``RunnableConfig``. So under the embedded path,
title-generation and summarization LLM calls were left untraced —
a regression introduced by this PR.
This commit mirrors the gateway worker's injection in
``DeerFlowClient.stream``:
- Append ``build_tracing_callbacks()`` to ``config["callbacks"]`` so
the Langfuse handler sees ``on_chain_start(parent_run_id=None)`` at
the graph root and runs the ``propagate_attributes`` path.
- Merge ``build_langfuse_trace_metadata(...)`` into
``config["metadata"]`` with ``setdefault`` so caller-supplied keys
still win.
- ``_ensure_agent`` now creates its main model with
``attach_tracing=False`` to avoid duplicate spans now that the
callback lives at the graph root.
Docs:
- ``backend/CLAUDE.md`` Tracing section rewritten to describe the
graph-root attachment model (replacing the inaccurate
"at model-creation time" wording).
- ``README.md`` Langfuse section now lists both injection points
(worker + client) instead of only the worker path.
Tests:
- ``tests/test_client_langfuse_metadata.py`` (new, 3 cases):
callbacks + metadata are injected when Langfuse is enabled,
caller-supplied metadata overrides win via ``setdefault``, and the
injection is inert when Langfuse is disabled.
Live verification on the real Langfuse instance:
=== user=fancy-client ===
id=cbd22847.. session=client-2930-6b9491-fancy-client user=fancy-client name='lead-agent'
=== user=alice-client ===
id=b4f6f576.. session=client-2930-6b9491-alice-client user=alice-client name='lead-agent'
Refs #2930.
* refactor(tracing): address maintainer review on PR #2944
Addresses @WillemJiang's 5 comments.
1. Duplicated metadata-injection code between worker.py and client.py
New ``deerflow.tracing.inject_langfuse_metadata(config, ...)`` helper
takes the 10-line build + merge + setdefault logic that was duplicated
in ``runtime/runs/worker.py`` and ``client.py``. Both callers now share
a single source of truth, so the two paths cannot drift.
2. Direct private-attribute mutation in conftest.py and tests
Added public ``reset_tracing_config()`` / ``reset_title_config()``
functions. ``tests/conftest.py`` and every test that previously did
``tracing_module._tracing_config = None`` or
``title_module._title_config = TitleConfig()`` now goes through the
public API. A future internal rename will surface as an ImportError
instead of a silent no-op.
3. client.py reading os.environ directly
``DeerFlowClient.__init__`` grows an optional ``environment`` parameter
so programmatic callers can pass the deployment label explicitly.
``stream()`` consults ``self._environment`` first and only falls back
to ``DEER_FLOW_ENV`` / ``ENVIRONMENT`` env vars when nothing was
passed in. Backwards compatible — env-var behaviour preserved for
callers that opt to keep using it.
4. build_tracing_callbacks() cached on hot path
Not implemented. Inspected the langfuse v4 ``langchain.CallbackHandler``
constructor: it only resolves the module-level singleton client via
``get_client()`` and initialises a few dicts (no I/O, no env parsing
at construction time). The build is essentially free. Caching would
trade a non-measurable speedup for two real risks: handler instances
carry per-run state internally (``_run_states``, ``_root_run_states``,
``last_trace_id``), and tracing config can be reloaded by env-var
changes between runs. Will revisit if profiling ever shows it as
a hot spot.
5. attach_tracing=False easy to forget at new in-graph call sites
- Module docstring at the top of ``lead_agent/agent.py`` documents
the invariant ("every in-graph ``create_chat_model`` MUST pass
``attach_tracing=False``") and enumerates the current sites.
- New regression test
``test_make_lead_agent_attaches_tracing_callbacks_at_graph_root`` in
``tests/test_lead_agent_model_resolution.py`` locks both halves of
the invariant: ``config["callbacks"]`` carries the tracing handler
after ``_make_lead_agent``, AND every ``create_chat_model`` call
captured by the test passes ``attach_tracing=False``. A future
in-graph site that forgets the flag will fail this test.
Lint clean. Full touched-suite bundle: 246 passed.
---------
Co-authored-by: Willem Jiang <willem.jiang@gmail.com>
174 lines
5.5 KiB
Python
174 lines
5.5 KiB
Python
"""Tests for deerflow.tracing.factory."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import sys
|
|
import types
|
|
|
|
import pytest
|
|
|
|
from deerflow.tracing import factory as tracing_factory
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def clear_tracing_env(monkeypatch):
|
|
from deerflow.config.tracing_config import reset_tracing_config
|
|
|
|
for name in (
|
|
"LANGSMITH_TRACING",
|
|
"LANGCHAIN_TRACING_V2",
|
|
"LANGCHAIN_TRACING",
|
|
"LANGSMITH_API_KEY",
|
|
"LANGCHAIN_API_KEY",
|
|
"LANGSMITH_PROJECT",
|
|
"LANGCHAIN_PROJECT",
|
|
"LANGSMITH_ENDPOINT",
|
|
"LANGCHAIN_ENDPOINT",
|
|
"LANGFUSE_TRACING",
|
|
"LANGFUSE_PUBLIC_KEY",
|
|
"LANGFUSE_SECRET_KEY",
|
|
"LANGFUSE_BASE_URL",
|
|
):
|
|
monkeypatch.delenv(name, raising=False)
|
|
reset_tracing_config()
|
|
yield
|
|
reset_tracing_config()
|
|
|
|
|
|
def test_build_tracing_callbacks_returns_empty_list_when_disabled(monkeypatch):
|
|
monkeypatch.setattr(tracing_factory, "validate_enabled_tracing_providers", lambda: None)
|
|
monkeypatch.setattr(tracing_factory, "get_enabled_tracing_providers", lambda: [])
|
|
|
|
callbacks = tracing_factory.build_tracing_callbacks()
|
|
|
|
assert callbacks == []
|
|
|
|
|
|
def test_build_tracing_callbacks_creates_langsmith_and_langfuse(monkeypatch):
|
|
class FakeLangSmithTracer:
|
|
def __init__(self, *, project_name: str):
|
|
self.project_name = project_name
|
|
|
|
class FakeLangfuseHandler:
|
|
def __init__(self, *, public_key: str):
|
|
self.public_key = public_key
|
|
|
|
monkeypatch.setattr(tracing_factory, "get_enabled_tracing_providers", lambda: ["langsmith", "langfuse"])
|
|
monkeypatch.setattr(tracing_factory, "validate_enabled_tracing_providers", lambda: None)
|
|
monkeypatch.setattr(
|
|
tracing_factory,
|
|
"get_tracing_config",
|
|
lambda: type(
|
|
"Cfg",
|
|
(),
|
|
{
|
|
"langsmith": type("LangSmithCfg", (), {"project": "smith-project"})(),
|
|
"langfuse": type(
|
|
"LangfuseCfg",
|
|
(),
|
|
{
|
|
"secret_key": "sk-lf-test",
|
|
"public_key": "pk-lf-test",
|
|
"host": "https://langfuse.example.com",
|
|
},
|
|
)(),
|
|
},
|
|
)(),
|
|
)
|
|
monkeypatch.setattr(tracing_factory, "_create_langsmith_tracer", lambda cfg: FakeLangSmithTracer(project_name=cfg.project))
|
|
monkeypatch.setattr(
|
|
tracing_factory,
|
|
"_create_langfuse_handler",
|
|
lambda cfg: FakeLangfuseHandler(public_key=cfg.public_key),
|
|
)
|
|
|
|
callbacks = tracing_factory.build_tracing_callbacks()
|
|
|
|
assert len(callbacks) == 2
|
|
assert callbacks[0].project_name == "smith-project"
|
|
assert callbacks[1].public_key == "pk-lf-test"
|
|
|
|
|
|
def test_build_tracing_callbacks_raises_when_enabled_provider_fails(monkeypatch):
|
|
monkeypatch.setattr(tracing_factory, "get_enabled_tracing_providers", lambda: ["langfuse"])
|
|
monkeypatch.setattr(tracing_factory, "validate_enabled_tracing_providers", lambda: None)
|
|
monkeypatch.setattr(
|
|
tracing_factory,
|
|
"get_tracing_config",
|
|
lambda: type(
|
|
"Cfg",
|
|
(),
|
|
{
|
|
"langfuse": type(
|
|
"LangfuseCfg",
|
|
(),
|
|
{"secret_key": "sk-lf-test", "public_key": "pk-lf-test", "host": "https://langfuse.example.com"},
|
|
)(),
|
|
},
|
|
)(),
|
|
)
|
|
monkeypatch.setattr(tracing_factory, "_create_langfuse_handler", lambda cfg: (_ for _ in ()).throw(RuntimeError("boom")))
|
|
|
|
with pytest.raises(RuntimeError, match="Langfuse tracing initialization failed"):
|
|
tracing_factory.build_tracing_callbacks()
|
|
|
|
|
|
def test_build_tracing_callbacks_raises_for_explicitly_enabled_misconfigured_provider(monkeypatch):
|
|
from deerflow.config.tracing_config import reset_tracing_config
|
|
|
|
monkeypatch.setenv("LANGFUSE_TRACING", "true")
|
|
monkeypatch.delenv("LANGFUSE_PUBLIC_KEY", raising=False)
|
|
monkeypatch.setenv("LANGFUSE_SECRET_KEY", "sk-lf-test")
|
|
reset_tracing_config()
|
|
|
|
with pytest.raises(ValueError, match="LANGFUSE_PUBLIC_KEY"):
|
|
tracing_factory.build_tracing_callbacks()
|
|
|
|
|
|
def test_create_langfuse_handler_initializes_client_before_handler(monkeypatch):
|
|
calls: list[tuple[str, dict]] = []
|
|
|
|
class FakeLangfuse:
|
|
def __init__(self, **kwargs):
|
|
calls.append(("client", kwargs))
|
|
|
|
class FakeCallbackHandler:
|
|
def __init__(self, **kwargs):
|
|
calls.append(("handler", kwargs))
|
|
|
|
fake_langfuse_module = types.ModuleType("langfuse")
|
|
fake_langfuse_module.Langfuse = FakeLangfuse
|
|
fake_langfuse_langchain_module = types.ModuleType("langfuse.langchain")
|
|
fake_langfuse_langchain_module.CallbackHandler = FakeCallbackHandler
|
|
monkeypatch.setitem(sys.modules, "langfuse", fake_langfuse_module)
|
|
monkeypatch.setitem(sys.modules, "langfuse.langchain", fake_langfuse_langchain_module)
|
|
|
|
cfg = type(
|
|
"LangfuseCfg",
|
|
(),
|
|
{
|
|
"secret_key": "sk-lf-test",
|
|
"public_key": "pk-lf-test",
|
|
"host": "https://langfuse.example.com",
|
|
},
|
|
)()
|
|
|
|
tracing_factory._create_langfuse_handler(cfg)
|
|
|
|
assert calls == [
|
|
(
|
|
"client",
|
|
{
|
|
"secret_key": "sk-lf-test",
|
|
"public_key": "pk-lf-test",
|
|
"host": "https://langfuse.example.com",
|
|
},
|
|
),
|
|
(
|
|
"handler",
|
|
{
|
|
"public_key": "pk-lf-test",
|
|
},
|
|
),
|
|
]
|