furyhawk/milvus
1
0
Fork 0
mirror of https://github.com/milvus-io/milvus.git synced 2026-07-21 10:15:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: add null check for packed_writer_ in JsonStatsParquetWriter::Close() (#45158)

Browse Source 
Related to #45157

Fix a bug where DataNode panics when building json stats index throws an
exception before the writer is initialized. The destructor would call
Close() on an uninitialized packed_writer_ pointer, causing a null
pointer dereference.

Changes:
- Add null check for packed_writer_ before calling Flush() and Close()
- Prevents null pointer dereference in edge cases
- Ignore close status as this is a cleanup operation

This ensures safe cleanup even when initialization fails due to
exceptions.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
This commit is contained in:
congqixia
2025-10-30 17:40:09 +08:00
committed by GitHub
parent 309d564796
commit 22098c1785
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/core/src/index/json_stats/parquet_writer.cpp
+6 -2
View File
@@ -46,8 +46,12 @@ JsonStatsParquetWriter::~JsonStatsParquetWriter() {
void
JsonStatsParquetWriter::Close() {
Flush();
packed_writer_->Close();
// check packed_writer_ initialized
if (packed_writer_) {
Flush();
// ignore close status here
auto _ = packed_writer_->Close();
}
}
void