furyhawk/milvus
1
0
Fork 0
mirror of https://github.com/milvus-io/milvus.git synced 2026-07-21 10:15:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: hoist cda(i) call to local variable to avoid redundant invocation

Browse Source 
cda(i) was called twice in the hot loop — once for has_value() and
once for value() — defeating the optimization. Store the result in
a local variable before checking.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

https://claude.ai/code/session_01WBCZMph4HbaoXWowSQyY8W
Signed-off-by: Claude <noreply@anthropic.com>
This commit is contained in:
Claude
2026-04-09 11:15:02 +00:00
parent 8746f52efb
commit 7a037de3cc
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/core/src/exec/expression/ColumnExpr.cpp
+3 -2
View File
@@ -195,10 +195,11 @@ PhyColumnExpr::DoEval(OffsetVector* input) {
for (int i = chunk_id == current_chunk_id_ ? current_chunk_pos_ : 0;
i < chunk_size;
++i) {
if (!cda(i).has_value()) {
auto val = cda(i);
if (!val.has_value()) {
valid_res[processed_rows] = false;
} else {
res_value[processed_rows] = boost::get<T>(cda(i).value());
res_value[processed_rows] = boost::get<T>(val.value());
}
processed_rows++;