furyhawk/milvus
1
0
Fork 0
mirror of https://github.com/milvus-io/milvus.git synced 2026-07-21 02:05:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

enhance: use RelWithDebInfo build type for CI to reduce peak compiler memory (#48154)

Browse Source 
## Summary
Switch CI pipelines from Release (`-O3`) to RelWithDebInfo (`-O2 -g
-DNDEBUG`), reducing peak compiler memory by ~15%. RelWithDebInfo is a
standard CMake build type that uses `-O2` natively and includes debug
symbols for better crash diagnostics in CI. Production image builds
remain at Release (`-O3`).

## Changes
- Update Jenkins (PR, PR-Arm, PR-for-go-sdk, UT-CPP) to use
`mode=RelWithDebInfo`
- Update GitHub Actions (`main.yaml`) to use `mode=RelWithDebInfo`
- Allow all standard CMake build types in `3rdparty_build.sh` validation
- Add gcc>=13 implicit include workaround in `CMakeLists.txt`

## Test plan
- [ ] CI builds with `mode=RelWithDebInfo` use `-O2` instead of `-O3`
- [ ] Default builds still use Release with `-O3`
- [ ] ASAN CI jobs pass with reduced memory usage

issue: #48400

Signed-off-by: xiaofan-luan <xiaofan.xl@zilliz.com>
Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Xiaofan
2026-03-20 13:17:26 +08:00
committed by GitHub
co-authored by Claude Opus 4.6
parent 48ba5fbfcd
commit 7dbe7e89d1
8 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/main.yaml
+1 -1
View File
@@ -96,7 +96,7 @@ jobs:
kind: 'cpp'
- name: Build
run: |
./build/builder.sh /bin/bash -c "make USE_ASAN=${{env.useasan}} build-cpp && chmod -R a+rwx /home/milvus/.conan"
./build/builder.sh /bin/bash -c "make USE_ASAN=${{env.useasan}} mode=RelWithDebInfo build-cpp && chmod -R a+rwx /home/milvus/.conan"
- run: |
zip -r code.zip . -x "./.docker/*" -x "./cmake_build/thirdparty/**" -x ".git/**"
- name: Archive code
ci/jenkins/PR-Arm.groovy
+1 -1
View File
@@ -61,7 +61,7 @@ pipeline {
set +a # stop automatically
docker run --net=host -v /root/.conan:/root/.conan -v \$(pwd):/root/milvus -w /root/milvus milvusdb/milvus-env:ubuntu20.04-\${DATE_VERSION} sh -c "make clean && make install"
docker run --net=host -v /root/.conan:/root/.conan -v \$(pwd):/root/milvus -w /root/milvus milvusdb/milvus-env:ubuntu20.04-\${DATE_VERSION} sh -c "make clean && make mode=RelWithDebInfo install"
"""
withCredentials([usernamePassword(credentialsId: "${env.CI_DOCKER_CREDENTIAL_ID}", usernameVariable: 'CI_REGISTRY_USERNAME', passwordVariable: 'CI_REGISTRY_PASSWORD')]){
ci/jenkins/PR-for-go-sdk.groovy
+1 -1
View File
@@ -57,7 +57,7 @@ pipeline {
gitBaseRef: gitBaseRef,
pullRequestNumber: "$env.CHANGE_ID",
suppress_suffix_of_image_tag: true,
make_cmd: "make clean && make jobs=8 install use_disk_index=ON",
make_cmd: "make clean && make jobs=8 install mode=RelWithDebInfo use_disk_index=ON",
images: '["milvus","gotestsum","helm"]',
tekton_log_timeout: '30m',
tekton_pipeline_timeout: '3h'
ci/jenkins/PR.groovy
+1 -1
View File
@@ -56,7 +56,7 @@ pipeline {
gitBaseRef: gitBaseRef,
pullRequestNumber: "$env.CHANGE_ID",
suppress_suffix_of_image_tag: true,
make_cmd: 'make clean && make jobs=8 install USE_ASAN=ON use_disk_index=ON',
make_cmd: 'make clean && make jobs=8 install USE_ASAN=ON mode=RelWithDebInfo use_disk_index=ON',
images: '["milvus","pytest","helm"]'
milvus_image_tag = tekton.query_result job_name, 'milvus-image-tag'
ci/jenkins/UT-CPP.groovy
+1 -1
View File
@@ -54,7 +54,7 @@ pipeline {
gitMode: gitMode ,
gitBaseRef: gitBaseRef,
pullRequestNumber: "$env.CHANGE_ID",
make_cmd: "make clean && make jobs=8 USE_ASAN=ON build-cpp-with-coverage",
make_cmd: "make clean && make jobs=8 USE_ASAN=ON mode=RelWithDebInfo build-cpp-with-coverage",
test_entrypoint: "./scripts/run_cpp_codecov.sh",
codecov_report_name: "cpp-unit-test",
codecov_files: "./lcov_output.info",
internal/core/CMakeLists.txt
+1 -1
View File
@@ -142,7 +142,7 @@ if (LINUX OR MSYS)
"-Wno-error"
"-Wno-all"
)
if (USE_ASAN STREQUAL "ON")
if (USE_ASAN STREQUAL "ON")
message( STATUS "Building Milvus Core Using AddressSanitizer")
add_compile_options(-fno-stack-protector -fno-omit-frame-pointer -fno-var-tracking -fsanitize=address)
add_link_options(-fno-stack-protector -fno-omit-frame-pointer -fno-var-tracking -fsanitize=address)
scripts/3rdparty_build.sh
+2 -2
View File
@@ -64,11 +64,11 @@ done
# Validate build type
case "${BUILD_TYPE}" in
Debug|Release)
Debug|Release|RelWithDebInfo|MinSizeRel)
echo "Build type: ${BUILD_TYPE}"
;;
*)
echo "Invalid build type: ${BUILD_TYPE}. Valid options are: Debug, Release"
echo "Invalid build type: ${BUILD_TYPE}. Valid options are: Debug, Release, RelWithDebInfo, MinSizeRel"
exit 1
;;
esac
scripts/core_build.sh
+2 -2
View File
@@ -160,7 +160,7 @@ while getopts "p:t:s:n:a:y:x:o:f:ulcgbZh" arg; do
parameter:
-p: install prefix(default: $(pwd)/milvus)
-d: db data path(default: /tmp/milvus)
-t: build type(default: Debug)
-t: build type: Release/RelWithDebInfo/Debug/MinSizeRel (default: Release)
-u: building unit test options(default: OFF)
-l: run cpplint, clang-format and clang-tidy(default: OFF)
-c: code coverage(default: OFF)
@@ -175,7 +175,7 @@ parameter:
-h: help
usage:
./core_build.sh -p \${INSTALL_PREFIX} -t \${BUILD_TYPE} -s \${CUDA_ARCH} -f \${TANTIVY_FEATURES} [-u] [-l] [-r] [-c] [-z] [-g] [-m] [-e] [-h] [-b] [-o]
./core_build.sh -p \${INSTALL_PREFIX} -t \${BUILD_TYPE} -s \${CUDA_ARCH} -f \${TANTIVY_FEATURES} [-u] [-l] [-c] [-z] [-g] [-m] [-e] [-h] [-b] [-o]
"
exit 0
;;