furyhawk/milvus
1
0
Fork 0
mirror of https://github.com/milvus-io/milvus.git synced 2026-07-21 10:15:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

enhance: simply code for subscripting json data(#46826) (#47002)

Browse Source 
related: #46826

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: MrPresent-Han <chun.han@gmail.com>
This commit is contained in:
Chun Han
2026-01-14 20:05:27 +08:00
committed by GitHub
co-authored by MrPresent-Han
parent 8c2864bfea
commit ce55d128d5
2 changed files with 7 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/core/src/mmap/ChunkVector.h
+3
View File
@@ -139,6 +139,9 @@ class ThreadSafeChunkVector : public ChunkVectorBase<Type> {
src.length(),
src.byte_size(),
src.get_element_type());
} else if constexpr (std::is_same_v<Json, Type>) {
return Json(chunk[chunk_offset].c_str(),
chunk[chunk_offset].size());
} else {
return chunk[chunk_offset];
}
internal/core/src/segcore/SegmentGrowingImpl.cpp
+4 -16
View File
@@ -1441,22 +1441,10 @@ SegmentGrowingImpl::bulk_subscript_ptr_impl(
google::protobuf::RepeatedPtrField<std::string>* dst) const {
auto vec = dynamic_cast<const ConcurrentVector<S>*>(vec_raw);
auto& src = *vec;
if constexpr (std::is_same_v<S, Json>) {
// For Json type, we must use operator[] instead of view_element()
// to ensure the Json object lives long enough. view_element() returns
// a string_view that may point to memory owned by a temporary Json
// object, which gets destroyed before we can construct std::string.
// Using operator[] copies the Json object, extending its lifetime.
for (int64_t i = 0; i < count; ++i) {
auto offset = seg_offsets[i];
Json json = src[offset]; // Copy Json object to extend lifetime
dst->at(i) = std::string(json.data());
}
} else {
for (int64_t i = 0; i < count; ++i) {
auto offset = seg_offsets[i];
dst->at(i) = std::string(src.view_element(offset));
}
for (int64_t i = 0; i < count; ++i) {
auto offset = seg_offsets[i];
auto view = src.view_element(offset);
dst->at(i).assign(view.data(), view.size());
}
}