furyhawk/openclaw
1
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-07-21 10:16:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(build): tolerate plugin SDK dts variance (#109119)

Browse Source
This commit is contained in:
Peter Steinberger
2026-07-16 08:35:10 -07:00
committed by GitHub
parent 2dd0e7b822
commit 3690f02c71
4 changed files with 38 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/check-plugin-sdk-exports.mjs
+6 -2
View File
@@ -14,6 +14,7 @@ import { fileURLToPath, pathToFileURL } from "node:url";
import {
MAX_PRIVATE_QA_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES,
MAX_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES,
PLUGIN_SDK_DECLARATION_OUTPUT_VARIANCE_BYTES,
evaluatePluginSdkDeclarationBudget,
isPrivateQaPluginSdkBuild,
} from "./lib/plugin-sdk-declaration-budget.mjs";
@@ -186,15 +187,18 @@ if (declarationBudget.shouldFail) {
console.error(
`${budgetLabel} DTS TOO LARGE: ${declarationBytes} bytes exceeds ${declarationBudget.budgetBytes} bytes.`,
);
console.error(
`Budget: ${declarationBudget.ratchetBytes}-byte ratchet + ${declarationBudget.varianceBytes}-byte Rolldown output variance.`,
);
console.error("Keep plugin SDK declarations in the canonical unified tsdown graph.");
missing += 1;
} else if (declarationBudget.budgetKind === "private-qa-public-entry") {
console.log(
`Private QA build public-entry declaration graph: ${declarationBytes}/${MAX_PRIVATE_QA_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES} bytes; publication budget ${MAX_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES} bytes is not applied.`,
`Private QA build public-entry declaration graph: ${declarationBytes}/${declarationBudget.budgetBytes} bytes (${MAX_PRIVATE_QA_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES}-byte ratchet + ${PLUGIN_SDK_DECLARATION_OUTPUT_VARIANCE_BYTES}-byte output variance); publication ratchet ${MAX_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES} bytes is not applied.`,
);
} else {
console.log(
`Public plugin SDK declaration graph: ${declarationBytes}/${MAX_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES} bytes.`,
`Public plugin SDK declaration graph: ${declarationBytes}/${declarationBudget.budgetBytes} bytes (${MAX_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES}-byte ratchet + ${PLUGIN_SDK_DECLARATION_OUTPUT_VARIANCE_BYTES}-byte output variance).`,
);
}
scripts/lib/plugin-sdk-declaration-budget.d.mts
+3
View File
@@ -8,7 +8,10 @@ export function evaluatePluginSdkDeclarationBudget({
}): {
budgetBytes: number;
budgetKind: string;
ratchetBytes: number;
shouldFail: boolean;
varianceBytes: number;
};
export const MAX_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES: 5200000;
export const MAX_PRIVATE_QA_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES: 5225000;
export const PLUGIN_SDK_DECLARATION_OUTPUT_VARIANCE_BYTES: 65536;
scripts/lib/plugin-sdk-declaration-budget.mjs
+7 -1
View File
@@ -4,18 +4,24 @@ export const MAX_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES = 5_200_000;
// Private-only entrypoints reshape chunks reachable from public roots but are never published.
// Bound that topology overhead without counting local-only declarations as package surface.
export const MAX_PRIVATE_QA_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES = 5_225_000;
// Rolldown can repartition equivalent declaration chunks between clean builds; measured spread is
// about 29 KiB across hosts. Keep one 64 KiB scheduling window above the intentional size ratchet.
export const PLUGIN_SDK_DECLARATION_OUTPUT_VARIANCE_BYTES = 64 * 1024;
export function isPrivateQaPluginSdkBuild(env) {
return env.OPENCLAW_BUILD_PRIVATE_QA === "1";
}
export function evaluatePluginSdkDeclarationBudget({ declarationBytes, buildPrivateQa }) {
const budgetBytes = buildPrivateQa
const ratchetBytes = buildPrivateQa
? MAX_PRIVATE_QA_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES
: MAX_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES;
const budgetBytes = ratchetBytes + PLUGIN_SDK_DECLARATION_OUTPUT_VARIANCE_BYTES;
return {
budgetBytes,
budgetKind: buildPrivateQa ? "private-qa-public-entry" : "public",
ratchetBytes,
shouldFail: declarationBytes > budgetBytes,
varianceBytes: PLUGIN_SDK_DECLARATION_OUTPUT_VARIANCE_BYTES,
};
}
test/scripts/plugin-sdk-declaration-budget.test.ts
+22 -8
View File
@@ -2,6 +2,7 @@ import { describe, expect, it } from "vitest";
import {
MAX_PRIVATE_QA_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES,
MAX_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES,
PLUGIN_SDK_DECLARATION_OUTPUT_VARIANCE_BYTES,
evaluatePluginSdkDeclarationBudget,
isPrivateQaPluginSdkBuild,
} from "../../scripts/lib/plugin-sdk-declaration-budget.mjs";
@@ -14,48 +15,61 @@ describe("plugin SDK declaration budget", () => {
});
it("enforces the publication budget at its exact boundary", () => {
const budgetBytes =
MAX_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES + PLUGIN_SDK_DECLARATION_OUTPUT_VARIANCE_BYTES;
expect(
evaluatePluginSdkDeclarationBudget({
buildPrivateQa: false,
declarationBytes: MAX_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES,
declarationBytes: budgetBytes,
}),
).toEqual({
budgetBytes: MAX_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES,
budgetBytes,
budgetKind: "public",
ratchetBytes: MAX_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES,
shouldFail: false,
varianceBytes: PLUGIN_SDK_DECLARATION_OUTPUT_VARIANCE_BYTES,
});
expect(
evaluatePluginSdkDeclarationBudget({
buildPrivateQa: false,
declarationBytes: MAX_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES + 1,
declarationBytes: budgetBytes + 1,
}),
).toEqual({
budgetBytes: MAX_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES,
budgetBytes,
budgetKind: "public",
ratchetBytes: MAX_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES,
shouldFail: true,
varianceBytes: PLUGIN_SDK_DECLARATION_OUTPUT_VARIANCE_BYTES,
});
});
it("tracks private-build public-entry chunk growth under a separate budget", () => {
const budgetBytes =
MAX_PRIVATE_QA_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES +
PLUGIN_SDK_DECLARATION_OUTPUT_VARIANCE_BYTES;
expect(
evaluatePluginSdkDeclarationBudget({
buildPrivateQa: true,
declarationBytes: MAX_PRIVATE_QA_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES,
declarationBytes: budgetBytes,
}),
).toEqual({
budgetBytes: MAX_PRIVATE_QA_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES,
budgetBytes,
budgetKind: "private-qa-public-entry",
ratchetBytes: MAX_PRIVATE_QA_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES,
shouldFail: false,
varianceBytes: PLUGIN_SDK_DECLARATION_OUTPUT_VARIANCE_BYTES,
});
expect(
evaluatePluginSdkDeclarationBudget({
buildPrivateQa: true,
declarationBytes: MAX_PRIVATE_QA_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES + 1,
declarationBytes: budgetBytes + 1,
}),
).toEqual({
budgetBytes: MAX_PRIVATE_QA_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES,
budgetBytes,
budgetKind: "private-qa-public-entry",
ratchetBytes: MAX_PRIVATE_QA_PUBLIC_PLUGIN_SDK_DECLARATION_BYTES,
shouldFail: true,
varianceBytes: PLUGIN_SDK_DECLARATION_OUTPUT_VARIANCE_BYTES,
});
});
});