refactor(plugins): trim registry exports (#105812)

scripts/deadcode-exports.baseline.mjs

@@ -4838,7 +4838,6 @@ export const KNIP_UNUSED_EXPORT_BASELINE = [
   "src/plugins/registry.ts: PluginWebFetchProviderRegistration",
   "src/plugins/registry.ts: PluginWebSearchProviderRegistration",
   "src/plugins/registry.ts: PluginWorkerProviderRegistration",
-  "src/plugins/registry.ts: resolvePluginPath",
   "src/plugins/roots.ts: PluginCacheInputs",
   "src/plugins/runtime-channel-state.ts: ActivePluginChannelRegistrySnapshot",
   "src/plugins/runtime-channel-state.ts: PLUGIN_REGISTRY_STATE",

src/plugins/plugin-registry.test.ts

@@ -37,7 +37,6 @@ import {
   resolvePluginContributionOwners,
   resolveProviderOwners,
 } from "./plugin-registry.js";
-import { resolvePluginPath } from "./registry.js";
 import { cleanupTrackedTempDirs, makeTrackedTempDir } from "./test-helpers/fs-fixtures.js";
 
 const tempDirs: string[] = [];
@@ -210,27 +209,6 @@ function expectSnapshotPluginIds(snapshot: InstalledPluginIndex, expectedPluginI
 }
 
 describe("plugin registry facade", () => {
-  it("resolves relative plugin API paths against the plugin root", () => {
-    const pluginRoot = path.join(makeTempDir(), "plugins", "demo");
-
-    expect(resolvePluginPath("data/cache.json", pluginRoot)).toBe(
-      path.join(pluginRoot, "data", "cache.json"),
-    );
-    expect(resolvePluginPath("./data/cache.json", pluginRoot)).toBe(
-      path.join(pluginRoot, "data", "cache.json"),
-    );
-  });
-
-  it("keeps absolute and home plugin API paths user-resolved", () => {
-    const pluginRoot = path.join(makeTempDir(), "plugins", "demo");
-    const absolute = path.resolve(pluginRoot, "..", "outside.txt");
-
-    expect(resolvePluginPath(absolute, pluginRoot)).toBe(resolvePluginPath(absolute, undefined));
-    expect(resolvePluginPath("~/openclaw/plugin.txt", pluginRoot)).toBe(
-      resolvePluginPath("~/openclaw/plugin.txt", undefined),
-    );
-  });
-
   it("resolves cold plugin records and contribution owners without loading runtime", () => {
     const rootDir = makeTempDir();
     const candidate = createCandidate(rootDir);

src/plugins/registry-api.ts

@@ -37,7 +37,7 @@ function normalizeLogger(logger: PluginLogger): PluginLogger {
   };
 }
 
-export function resolvePluginPath(input: string, rootDir: string | undefined): string {
+function resolvePluginPath(input: string, rootDir: string | undefined): string {
   const trimmed = input.trim();
   if (!trimmed || path.isAbsolute(trimmed) || trimmed.startsWith("~")) {
     return resolveUserPath(input);

src/plugins/registry-registrars-capabilities.ts

@@ -158,5 +158,3 @@ export function createCapabilityRegistrars(state: PluginRegistryState) {
     registerCompactionProvider,
   };
 }
-
-export type CapabilityRegistrars = ReturnType<typeof createCapabilityRegistrars>;

src/plugins/registry-registrars-host.ts

@@ -708,5 +708,3 @@ export function createHostRegistrars(state: PluginRegistryState) {
     registerConversationBindingResolvedHandler,
   };
 }
-
-export type HostRegistrars = ReturnType<typeof createHostRegistrars>;

src/plugins/registry-registrars-memory.ts

@@ -141,5 +141,3 @@ export function createMemoryRegistrars(state: PluginRegistryState) {
     registerMemoryEmbeddingProvider,
   };
 }
-
-export type MemoryRegistrars = ReturnType<typeof createMemoryRegistrars>;

src/plugins/registry-registrars-network.ts

@@ -338,5 +338,3 @@ export function createNetworkRegistrars(state: PluginRegistryState) {
     registerChannel,
   };
 }
-
-export type NetworkRegistrars = ReturnType<typeof createNetworkRegistrars>;

src/plugins/registry-registrars-operations.ts

@@ -452,5 +452,3 @@ export function createOperationRegistrars(state: PluginRegistryState) {
     registerCommand,
   };
 }
-
-export type OperationRegistrars = ReturnType<typeof createOperationRegistrars>;

src/plugins/registry-registrars-providers.ts

@@ -499,5 +499,3 @@ export function createProviderRegistrars(state: PluginRegistryState) {
     registerMigrationProvider,
   };
 }
-
-export type ProviderRegistrars = ReturnType<typeof createProviderRegistrars>;

src/plugins/registry-registrars-tools-hooks.ts

@@ -513,5 +513,3 @@ export function createToolHookRegistrars(state: PluginRegistryState) {
     rollbackHooks,
   };
 }
-
-export type ToolHookRegistrars = ReturnType<typeof createToolHookRegistrars>;

src/plugins/registry-state.ts

@@ -16,7 +16,7 @@ export type PluginSideEffectGuard = {
   active: boolean;
 };
 
-export type PluginRegistrationCapabilities = {
+type PluginRegistrationCapabilities = {
   /** Broad registry writes that discovery and live activation both need. */
   capabilityHandlers: boolean;
   /** Setup-runtime may publish pre-listen gateway surfaces without full activation. */
@@ -37,7 +37,7 @@ export function resolvePluginRegistrationCapabilities(
   };
 }
 
-export function normalizeHookTimeoutMs(value: unknown): number | undefined {
+function normalizeHookTimeoutMs(value: unknown): number | undefined {
   if (typeof value !== "number" || !Number.isFinite(value) || value <= 0) {
     return undefined;
   }

src/plugins/registry.runtime-config.test.ts

@@ -1,6 +1,9 @@
 // Verifies plugin registry behavior with runtime config inputs.
+import os from "node:os";
+import path from "node:path";
 import { describe, expect, it, vi } from "vitest";
 import type { OpenClawConfig } from "../config/types.openclaw.js";
+import { resolveUserPath } from "../utils.js";
 import { createPluginRecord } from "./loader-records.js";
 import { createPluginRegistry } from "./registry.js";
 import { getPluginRuntimeGatewayRequestScope } from "./runtime/gateway-request-scope.js";
@@ -21,6 +24,27 @@ function createTestRegistry(runtime: PluginRuntime) {
 }
 
 describe("plugin registry runtime config scope", () => {
+  it("resolves plugin API paths against the plugin root", () => {
+    const pluginRoot = path.join(os.tmpdir(), "openclaw-plugins", "demo");
+    const pluginRegistry = createTestRegistry(createPluginRuntime());
+    const record = createPluginRecord({
+      id: "path-plugin",
+      name: "Path Plugin",
+      source: path.join(pluginRoot, "index.js"),
+      rootDir: pluginRoot,
+      origin: "global",
+      enabled: true,
+      configSchema: false,
+    });
+    const api = pluginRegistry.createApi(record, { config: {} as OpenClawConfig });
+    const absolute = path.resolve(pluginRoot, "..", "outside.txt");
+
+    expect(api.resolvePath("data/cache.json")).toBe(path.join(pluginRoot, "data", "cache.json"));
+    expect(api.resolvePath("./data/cache.json")).toBe(path.join(pluginRoot, "data", "cache.json"));
+    expect(api.resolvePath(absolute)).toBe(absolute);
+    expect(api.resolvePath("~/openclaw/plugin.txt")).toBe(resolveUserPath("~/openclaw/plugin.txt"));
+  });
+
   it("adds plugin context to lazy runtime resolution failures", () => {
     const runtime = new Proxy({} as PluginRuntime, {
       get() {

src/plugins/registry.ts

@@ -55,7 +55,6 @@ export type {
   PluginSessionExtensionRegistryRegistration,
 } from "./registry-types.js";
 export { createEmptyPluginRegistry } from "./registry-empty.js";
-export { resolvePluginPath } from "./registry-api.js";
 
 /**
  * Compose the registry state, domain registrars, scoped runtime, and plugin API.