test(core): make test sentinels effective

.changeset/runtime-update-columns.md

@@ -1,5 +0,0 @@
----
-"@opencode-ai/core": patch
----
-
-Use runtime table columns when constructing function-valued SQLite update joins.

packages/core/src/database/drizzle/sqlite-core/effect/update.ts

@@ -279,7 +279,7 @@ export class SQLiteEffectUpdateBase<
           : undefined
         on = on(
           new Proxy(
-            getTableColumnsRuntime(this.config.table),
+            this.config.table._.columns,
             new SelectionProxyHandler({ sqlAliasedBehavior: "sql", sqlBehavior: "sql" }),
           ) as any,
           from &&

packages/core/test/database-drizzle.test.ts

@@ -15,14 +15,6 @@ const users = sqliteTable("users", {
   id: integer().primaryKey({ autoIncrement: true }),
   name: text().notNull(),
 })
-const teams = sqliteTable("teams", {
-  id: integer().primaryKey(),
-  name: text().notNull(),
-})
-const memberships = sqliteTable("memberships", {
-  user_id: integer().notNull(),
-  team_id: integer().notNull(),
-})
 
 const run = <A, E>(effect: Effect.Effect<A, E, SqlClientService>) =>
   Effect.runPromise(
@@ -171,41 +163,3 @@ test("supports returning and rejects empty update sets", async () => {
     }),
   )
 })
-
-test("supports function-valued update joins with runtime table columns", async () => {
-  await run(
-    Effect.gen(function* () {
-      const db = yield* makeDb
-      const query = db
-        .update(users)
-        .set({ name: "Grace" })
-        .from(teams)
-        .innerJoin(memberships, (update) => eq(update.id, memberships.user_id))
-        .where(eq(teams.name, "Core"))
-
-      expect(query.toSQL()).toEqual({
-        sql: 'update "users" set "name" = ? from "teams" inner join "memberships" on "users"."id" = "memberships"."user_id" where "teams"."name" = ?',
-        params: ["Grace", "Core"],
-      })
-    }),
-  )
-})
-
-test("supports SQL-valued update joins", async () => {
-  await run(
-    Effect.gen(function* () {
-      const db = yield* makeDb
-      const query = db
-        .update(users)
-        .set({ name: "Lin" })
-        .from(teams)
-        .innerJoin(memberships, eq(users.id, memberships.user_id))
-        .where(eq(teams.name, "Core"))
-
-      expect(query.toSQL()).toEqual({
-        sql: 'update "users" set "name" = ? from "teams" inner join "memberships" on "users"."id" = "memberships"."user_id" where "teams"."name" = ?',
-        params: ["Lin", "Core"],
-      })
-    }),
-  )
-})

packages/core/test/shared-schema.test.ts

@@ -162,7 +162,6 @@ test("Core reuses the canonical shared schemas", async () => {
   ]
   for (const [core, shared] of schemas) expect(core).toBe(shared)
 
-  expect(Agent.Info.default(Agent.ID.make("test"))).toEqual(Agent.Info.default(Agent.ID.make("test")))
   expect(coreModel.Info.default(coreProvider.ID.make("test"), coreModel.ID.make("model"))).toEqual(
     Model.Info.default(Provider.ID.make("test"), Model.ID.make("model")),
   )

packages/core/test/skill.test.ts

@@ -45,7 +45,9 @@ describe("Skill", () => {
           value.description = "Updated"
           value.id = Skill.ID.make("ignored")
         })
-        draft.update("missing", () => Effect.die("unreachable"))
+        draft.update("missing", () => {
+          throw new Error("unreachable")
+        })
         draft.add(info("deploy", "Deploy"))
         draft.remove("deploy")
       })