fix(opencode): ignore unknown config fields (#41312)

packages/opencode/src/config/parse.ts

@@ -37,22 +37,11 @@ export function schema<S extends EffectSchema.Decoder<unknown, never>>(
   data: unknown,
   source: string,
 ): DeepMutable<S["Type"]> {
-  const extra = topLevelExtraKeys(schema, data)
-  if (extra.length) {
-    throw new InvalidError({
-      path: source,
-      issues: [
-        {
-          code: "unrecognized_keys",
-          keys: extra,
-          path: [],
-          message: `Unrecognized key${extra.length === 1 ? "" : "s"}: ${extra.join(", ")}`,
-        },
-      ],
-    })
-  }
-
-  const decoded = EffectSchema.decodeUnknownExit(schema)(data, { errors: "all", propertyOrder: "original" })
+  const decoded = EffectSchema.decodeUnknownExit(schema)(data, {
+    errors: "all",
+    onExcessProperty: "ignore",
+    propertyOrder: "original",
+  })
   if (Exit.isSuccess(decoded)) return decoded.value as DeepMutable<S["Type"]>
   const error = Cause.squash(decoded.cause)
 
@@ -70,10 +59,3 @@ export function schema<S extends EffectSchema.Decoder<unknown, never>>(
     { cause: error },
   )
 }
-
-function topLevelExtraKeys(schema: EffectSchema.Top, data: unknown) {
-  if (typeof data !== "object" || data === null || Array.isArray(data)) return []
-  if (schema.ast._tag !== "Objects" || schema.ast.indexSignatures.length > 0) return []
-  const known = new Set(schema.ast.propertySignatures.map((item) => String(item.name)))
-  return Object.keys(data).filter((key) => !known.has(key))
-}

packages/opencode/src/provider/transform.ts

@@ -431,7 +431,6 @@ function unsupportedParts(msgs: ModelMessage[], model: Provider.Model): ModelMes
       const modality = mimeToModality(mime)
       if (!modality) return part
       if (model.capabilities.input[modality]) return part
-      if ((modality === "image" || modality === "pdf") && model.capabilities.attachment) return part
 
       const name = filename ? `"${filename}"` : modality
       return {

packages/opencode/src/session/message-v2.ts

@@ -145,10 +145,6 @@ export const toModelMessagesEffect = Effect.fnUntraced(function* (
   // Only apply this workaround if the model actually supports that media input -
   // otherwise unsupportedParts() will turn it into a user-visible error.
   const supportsMediaInToolResult = (attachment: { mime: string }) => {
-    if (attachment.mime.startsWith("image/") && !model.capabilities.attachment && !model.capabilities.input.image)
-      return false
-    if (attachment.mime === "application/pdf" && !model.capabilities.attachment && !model.capabilities.input.pdf)
-      return false
     if (model.api.npm === "@ai-sdk/anthropic") return true
     if (model.api.npm === "@ai-sdk/openai") return true
     if (model.api.npm === "@ai-sdk/amazon-bedrock/mantle") return true

packages/opencode/test/config/config.test.ts

@@ -597,12 +597,12 @@ accountTokenIt.instance("resolves env templates in account config with account t
   }),
 )
 
-it.instance("validates config schema and throws on invalid fields", () =>
+it.instance("validates config schema and throws on invalid values", () =>
   Effect.gen(function* () {
     const test = yield* TestInstance
     yield* writeConfigEffect(test.directory, {
       $schema: "https://opencode.ai/config.json",
-      invalid_field: "should cause error",
+      model: 42,
     })
     const exit = yield* Config.use.get().pipe(Effect.exit)
     expect(Exit.isFailure(exit)).toBe(true)
@@ -1331,7 +1331,7 @@ it.instance("permission config preserves user key order", () =>
   }),
 )
 
-test("config parser preserves permission order while rejecting unknown top-level keys", () => {
+test("config parser preserves permission order while ignoring unknown top-level keys", () => {
   const config = ConfigParse.schema(
     ConfigV1.Info,
     {
@@ -1340,18 +1340,13 @@ test("config parser preserves permission order while rejecting unknown top-level
         "*": "deny",
         edit: "ask",
       },
+      plugins: ["example"],
     },
     "test",
   )
 
   expect(Object.keys(config.permission!)).toEqual(["bash", "*", "edit"])
-  try {
-    ConfigParse.schema(ConfigV1.Info, { invalid_field: true }, "test")
-    throw new Error("expected config parse to fail")
-  } catch (err) {
-    const error = err as { data?: { issues?: Array<{ code?: string; keys?: string[]; path?: string[] }> } }
-    expect(error.data?.issues?.[0]).toMatchObject({ code: "unrecognized_keys", keys: ["invalid_field"], path: [] })
-  }
+  expect(config).not.toHaveProperty("plugins")
 })
 
 // MCP config merging tests

packages/opencode/test/session/message-v2.test.ts

@@ -322,16 +322,6 @@ describe("session.message-v2.toModelMessage", () => {
   test("converts assistant tool completion into tool-call + tool-result messages with attachments", async () => {
     const userID = "m-user"
     const assistantID = "m-assistant"
-    const imageModel: Provider.Model = {
-      ...model,
-      capabilities: {
-        ...model.capabilities,
-        input: {
-          ...model.capabilities.input,
-          image: true,
-        },
-      },
-    }
 
     const input: SessionV1.WithParts[] = [
       {
@@ -381,7 +371,7 @@ describe("session.message-v2.toModelMessage", () => {
       },
     ]
 
-    expect(await MessageV2.toModelMessages(input, imageModel)).toStrictEqual([
+    expect(await MessageV2.toModelMessages(input, model)).toStrictEqual([
       {
         role: "user",
         content: [{ type: "text", text: "run tool" }],
@@ -419,58 +409,6 @@ describe("session.message-v2.toModelMessage", () => {
         ],
       },
     ])
-
-    const unsupported = await MessageV2.toModelMessages(input, model)
-    expect(unsupported).toMatchObject([
-      { role: "user" },
-      { role: "assistant" },
-      {
-        role: "tool",
-        content: [{ output: { type: "text", value: "ok" } }],
-      },
-      {
-        role: "user",
-        content: [
-          { type: "text", text: MessageV2.SYNTHETIC_ATTACHMENT_PROMPT },
-          { type: "file", mediaType: "image/png" },
-        ],
-      },
-    ])
-    expect(ProviderTransform.message(unsupported, model, {})).toMatchObject([
-      { role: "user" },
-      { role: "assistant" },
-      { role: "tool" },
-      {
-        role: "user",
-        content: [
-          { type: "text", text: MessageV2.SYNTHETIC_ATTACHMENT_PROMPT },
-          {
-            type: "text",
-            text: 'ERROR: Cannot read "attachment.png" (this model does not support image input). Inform the user.',
-          },
-        ],
-      },
-    ])
-
-    const legacyModel: Provider.Model = {
-      ...model,
-      api: { ...model.api, npm: "@ai-sdk/openai-compatible" },
-      capabilities: { ...model.capabilities, attachment: true },
-    }
-    expect(
-      ProviderTransform.message(await MessageV2.toModelMessages(input, legacyModel), legacyModel, {}),
-    ).toMatchObject([
-      { role: "user" },
-      { role: "assistant" },
-      { role: "tool" },
-      {
-        role: "user",
-        content: [
-          { type: "text", text: MessageV2.SYNTHETIC_ATTACHMENT_PROMPT },
-          { type: "file", mediaType: "image/png" },
-        ],
-      },
-    ])
   })
 
   test("preserves jpeg tool-result media for anthropic models", async () => {